Re: [PATCH 1/1] net: Allow all multicast packets to be received on a interface.

From: kernel test robot <lkp@intel.com>
To: Callum Sinclair <callum.sinclair@alliedtelesis.co.nz>,
	dsahern@kernel.org, nikolay@nvidia.com
Cc: kbuild-all@lists.01.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linus.luessing@c0d3.blue,
	Callum Sinclair <callum.sinclair@alliedtelesis.co.nz>
Subject: Re: [PATCH 1/1] net: Allow all multicast packets to be received on a interface.
Date: Fri, 18 Jun 2021 04:17:15 +0800	[thread overview]
Message-ID: <202106180412.oIlu8hOD-lkp@intel.com> (raw)
In-Reply-To: <20210617095020.28628-2-callum.sinclair@alliedtelesis.co.nz>

[-- Attachment #1: Type: text/plain, Size: 2869 bytes --]

Hi Callum,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.13-rc6 next-20210617]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Callum-Sinclair/Create-multicast-snooping-sysctl-option/20210617-175212
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 70585216fe7730d9fb5453d3e2804e149d0fe201
config: x86_64-rhel-8.3-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/4220b6837f4315ff557bd44f7aada23b69e181b6
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Callum-Sinclair/Create-multicast-snooping-sysctl-option/20210617-175212
        git checkout 4220b6837f4315ff557bd44f7aada23b69e181b6
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from net/ipv4/devinet.c:47:
   net/ipv4/devinet.c: In function 'inet_netconf_fill_devconf':
>> include/linux/inetdevice.h:53:45: error: 'IPV4_DEVCONF_NETCONFA_MC_SNOOPING' undeclared (first use in this function); did you mean 'IPV4_DEVCONF_MC_SNOOPING'?
      53 | #define IPV4_DEVCONF(cnf, attr) ((cnf).data[IPV4_DEVCONF_ ## attr - 1])
         |                                             ^~~~~~~~~~~~~
   net/ipv4/devinet.c:2069:4: note: in expansion of macro 'IPV4_DEVCONF'
    2069 |    IPV4_DEVCONF(*devconf, NETCONFA_MC_SNOOPING)) < 0)
         |    ^~~~~~~~~~~~
   include/linux/inetdevice.h:53:45: note: each undeclared identifier is reported only once for each function it appears in
      53 | #define IPV4_DEVCONF(cnf, attr) ((cnf).data[IPV4_DEVCONF_ ## attr - 1])
         |                                             ^~~~~~~~~~~~~
   net/ipv4/devinet.c:2069:4: note: in expansion of macro 'IPV4_DEVCONF'
    2069 |    IPV4_DEVCONF(*devconf, NETCONFA_MC_SNOOPING)) < 0)
         |    ^~~~~~~~~~~~

vim +53 include/linux/inetdevice.h

^1da177e4c3f41 Linus Torvalds    2005-04-16  52  
02291680ffba92 Eric W. Biederman 2010-02-14 @53  #define IPV4_DEVCONF(cnf, attr) ((cnf).data[IPV4_DEVCONF_ ## attr - 1])
586f12115264b7 Pavel Emelyanov   2007-12-16  54  #define IPV4_DEVCONF_ALL(net, attr) \
586f12115264b7 Pavel Emelyanov   2007-12-16  55  	IPV4_DEVCONF((*(net)->ipv4.devconf_all), attr)
42f811b8bcdf66 Herbert Xu        2007-06-04  56  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41894 bytes --]