All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] block: Include mm_types.h instead of mm.h
@ 2021-06-21 12:24 Matthew Wilcox (Oracle)
  2021-06-21 15:52 ` Bart Van Assche
  2021-06-21 15:55 ` Jens Axboe
  0 siblings, 2 replies; 3+ messages in thread
From: Matthew Wilcox (Oracle) @ 2021-06-21 12:24 UTC (permalink / raw)
  To: Ming Lei, Jens Axboe, linux-kernel, linux-block; +Cc: Matthew Wilcox (Oracle)

There's no need to include all of mm.h in bvec.h.  It only needs a few
things like the definition of struct page, PAGE_SIZE, PAGE_MASK and so
on, all of which are provided by mm_types.h.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 include/linux/bvec.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/bvec.h b/include/linux/bvec.h
index ff832e698efb..a0f3ccc09aba 100644
--- a/include/linux/bvec.h
+++ b/include/linux/bvec.h
@@ -11,7 +11,7 @@
 #include <linux/errno.h>
 #include <linux/limits.h>
 #include <linux/minmax.h>
-#include <linux/mm.h>
+#include <linux/mm_types.h>
 #include <linux/types.h>
 
 struct page;
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] block: Include mm_types.h instead of mm.h
  2021-06-21 12:24 [PATCH] block: Include mm_types.h instead of mm.h Matthew Wilcox (Oracle)
@ 2021-06-21 15:52 ` Bart Van Assche
  2021-06-21 15:55 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Bart Van Assche @ 2021-06-21 15:52 UTC (permalink / raw)
  To: Matthew Wilcox (Oracle), Ming Lei, Jens Axboe, linux-kernel, linux-block

On 6/21/21 5:24 AM, Matthew Wilcox (Oracle) wrote:
> There's no need to include all of mm.h in bvec.h.  It only needs a few
> things like the definition of struct page, PAGE_SIZE, PAGE_MASK and so
> on, all of which are provided by mm_types.h.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] block: Include mm_types.h instead of mm.h
  2021-06-21 12:24 [PATCH] block: Include mm_types.h instead of mm.h Matthew Wilcox (Oracle)
  2021-06-21 15:52 ` Bart Van Assche
@ 2021-06-21 15:55 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2021-06-21 15:55 UTC (permalink / raw)
  To: Matthew Wilcox (Oracle), Ming Lei, linux-kernel, linux-block

On 6/21/21 6:24 AM, Matthew Wilcox (Oracle) wrote:
> There's no need to include all of mm.h in bvec.h.  It only needs a few
> things like the definition of struct page, PAGE_SIZE, PAGE_MASK and so
> on, all of which are provided by mm_types.h.

Applied, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-21 15:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-21 12:24 [PATCH] block: Include mm_types.h instead of mm.h Matthew Wilcox (Oracle)
2021-06-21 15:52 ` Bart Van Assche
2021-06-21 15:55 ` Jens Axboe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.