* [PATCH] dt-bindings: net: dwmac: ingenic: Drop snps,dwmac compatible
@ 2021-06-22 13:40 Thierry Reding
2021-06-22 16:32 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Thierry Reding @ 2021-06-22 13:40 UTC (permalink / raw)
To: Rob Herring; +Cc: zhouyanjie, devicetree, netdev
From: Thierry Reding <treding@nvidia.com>
The DT binding doesn't specify snps,dwmac as a valid compatible string,
so remove it from the example to avoid validation failures.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
Documentation/devicetree/bindings/net/ingenic,mac.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/ingenic,mac.yaml b/Documentation/devicetree/bindings/net/ingenic,mac.yaml
index 5e93d4f9a080..d08a88125a5c 100644
--- a/Documentation/devicetree/bindings/net/ingenic,mac.yaml
+++ b/Documentation/devicetree/bindings/net/ingenic,mac.yaml
@@ -61,7 +61,7 @@ examples:
#include <dt-bindings/clock/x1000-cgu.h>
mac: ethernet@134b0000 {
- compatible = "ingenic,x1000-mac", "snps,dwmac";
+ compatible = "ingenic,x1000-mac";
reg = <0x134b0000 0x2000>;
interrupt-parent = <&intc>;
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: net: dwmac: ingenic: Drop snps,dwmac compatible
2021-06-22 13:40 [PATCH] dt-bindings: net: dwmac: ingenic: Drop snps,dwmac compatible Thierry Reding
@ 2021-06-22 16:32 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2021-06-22 16:32 UTC (permalink / raw)
To: Thierry Reding; +Cc: 周琰杰 (Zhou Yanjie), devicetree, netdev
On Tue, Jun 22, 2021 at 7:39 AM Thierry Reding <thierry.reding@gmail.com> wrote:
>
> From: Thierry Reding <treding@nvidia.com>
There's another fix already[1], but I think your commit message is better.
> The DT binding doesn't specify snps,dwmac as a valid compatible string,
> so remove it from the example to avoid validation failures.
>
Fixes: 3b8401066e5a ("dt-bindings: dwmac: Add bindings for new Ingenic SoCs.")
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Documentation/devicetree/bindings/net/ingenic,mac.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Rob Herring <robh@kernel.org>
[1] https://lore.kernel.org/r/1624192730-43276-2-git-send-email-zhouyanjie@wanyeetech.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-22 16:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-22 13:40 [PATCH] dt-bindings: net: dwmac: ingenic: Drop snps,dwmac compatible Thierry Reding
2021-06-22 16:32 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.