From: kernel test robot <lkp@intel.com> To: Jussi Maki <joamaki@gmail.com>, bpf@vger.kernel.org Cc: kbuild-all@lists.01.org, netdev@vger.kernel.org, daniel@iogearbox.net, j.vosburgh@gmail.com, andy@greyhouse.net, vfalico@gmail.com, andrii@kernel.org, Jussi Maki <joamaki@gmail.com> Subject: Re: [PATCH bpf-next 1/3] net: bonding: Add XDP support to the bonding driver Date: Tue, 22 Jun 2021 15:24:28 +0800 [thread overview] Message-ID: <202106221509.kwNvAAZg-lkp@intel.com> (raw) In-Reply-To: <20210609135537.1460244-2-joamaki@gmail.com> [-- Attachment #1: Type: text/plain, Size: 5208 bytes --] Hi Jussi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Jussi-Maki/XDP-bonding-support/20210617-053146 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: x86_64-randconfig-s031-20210622 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-341-g8af24329-dirty # https://github.com/0day-ci/linux/commit/61fabab38aec5b8e0cdc33867e35ea9740da84c8 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jussi-Maki/XDP-bonding-support/20210617-053146 git checkout 61fabab38aec5b8e0cdc33867e35ea9740da84c8 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> sparse warnings: (new ones prefixed by >>) drivers/net/bonding/bond_main.c:2660:26: sparse: sparse: restricted __be16 degrades to integer drivers/net/bonding/bond_main.c:2666:20: sparse: sparse: restricted __be16 degrades to integer drivers/net/bonding/bond_main.c:2713:40: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be16 [usertype] vlan_proto @@ got int @@ drivers/net/bonding/bond_main.c:2713:40: sparse: expected restricted __be16 [usertype] vlan_proto drivers/net/bonding/bond_main.c:2713:40: sparse: got int drivers/net/bonding/bond_main.c:3561:25: sparse: sparse: restricted __be16 degrades to integer drivers/net/bonding/bond_main.c:3571:32: sparse: sparse: restricted __be16 degrades to integer >> drivers/net/bonding/bond_main.c:3640:48: sparse: sparse: incorrect type in argument 5 (different base types) @@ expected int l2_proto @@ got restricted __be16 [usertype] l2_proto @@ drivers/net/bonding/bond_main.c:3640:48: sparse: expected int l2_proto drivers/net/bonding/bond_main.c:3640:48: sparse: got restricted __be16 [usertype] l2_proto drivers/net/bonding/bond_main.c:3661:58: sparse: sparse: incorrect type in argument 5 (different base types) @@ expected int l2_proto @@ got restricted __be16 [usertype] l2_proto @@ drivers/net/bonding/bond_main.c:3661:58: sparse: expected int l2_proto drivers/net/bonding/bond_main.c:3661:58: sparse: got restricted __be16 [usertype] l2_proto >> drivers/net/bonding/bond_main.c:4633:16: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct bond_up_slave *slaves @@ got struct bond_up_slave [noderef] __rcu *usable_slaves @@ drivers/net/bonding/bond_main.c:4633:16: sparse: expected struct bond_up_slave *slaves drivers/net/bonding/bond_main.c:4633:16: sparse: got struct bond_up_slave [noderef] __rcu *usable_slaves drivers/net/bonding/bond_main.c:3552:52: sparse: sparse: restricted __be16 degrades to integer drivers/net/bonding/bond_main.c:3552:52: sparse: sparse: restricted __be16 degrades to integer vim +3640 drivers/net/bonding/bond_main.c 3615 3616 /* Extract the appropriate headers based on bond's xmit policy */ 3617 static bool bond_flow_dissect(struct bonding *bond, 3618 struct sk_buff *skb, 3619 const void *data, 3620 __be16 l2_proto, 3621 int nhoff, 3622 int hlen, 3623 struct flow_keys *fk) 3624 { 3625 bool l34 = bond->params.xmit_policy == BOND_XMIT_POLICY_LAYER34; 3626 int ip_proto = -1; 3627 3628 switch (bond->params.xmit_policy) { 3629 case BOND_XMIT_POLICY_ENCAP23: 3630 case BOND_XMIT_POLICY_ENCAP34: 3631 memset(fk, 0, sizeof(*fk)); 3632 return __skb_flow_dissect(NULL, skb, &flow_keys_bonding, 3633 fk, data, l2_proto, nhoff, hlen, 0); 3634 default: 3635 break; 3636 } 3637 3638 fk->ports.ports = 0; 3639 memset(&fk->icmp, 0, sizeof(fk->icmp)); > 3640 if (!bond_flow_ip(skb, fk, data, hlen, l2_proto, &nhoff, &ip_proto, l34)) 3641 return false; 3642 3643 /* ICMP error packets contains at least 8 bytes of the header 3644 * of the packet which generated the error. Use this information 3645 * to correlate ICMP error packets within the same flow which 3646 * generated the error. 3647 */ 3648 if (ip_proto == IPPROTO_ICMP || ip_proto == IPPROTO_ICMPV6) { 3649 skb_flow_get_icmp_tci(skb, &fk->icmp, data, nhoff, hlen); 3650 if (ip_proto == IPPROTO_ICMP) { 3651 if (!icmp_is_err(fk->icmp.type)) 3652 return true; 3653 3654 nhoff += sizeof(struct icmphdr); 3655 } else if (ip_proto == IPPROTO_ICMPV6) { 3656 if (!icmpv6_is_err(fk->icmp.type)) 3657 return true; 3658 3659 nhoff += sizeof(struct icmp6hdr); 3660 } 3661 return bond_flow_ip(skb, fk, data, hlen, l2_proto, &nhoff, &ip_proto, l34); 3662 } 3663 3664 return true; 3665 } 3666 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 47225 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH bpf-next 1/3] net: bonding: Add XDP support to the bonding driver Date: Tue, 22 Jun 2021 15:24:28 +0800 [thread overview] Message-ID: <202106221509.kwNvAAZg-lkp@intel.com> (raw) In-Reply-To: <20210609135537.1460244-2-joamaki@gmail.com> [-- Attachment #1: Type: text/plain, Size: 5312 bytes --] Hi Jussi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Jussi-Maki/XDP-bonding-support/20210617-053146 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: x86_64-randconfig-s031-20210622 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-341-g8af24329-dirty # https://github.com/0day-ci/linux/commit/61fabab38aec5b8e0cdc33867e35ea9740da84c8 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jussi-Maki/XDP-bonding-support/20210617-053146 git checkout 61fabab38aec5b8e0cdc33867e35ea9740da84c8 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> sparse warnings: (new ones prefixed by >>) drivers/net/bonding/bond_main.c:2660:26: sparse: sparse: restricted __be16 degrades to integer drivers/net/bonding/bond_main.c:2666:20: sparse: sparse: restricted __be16 degrades to integer drivers/net/bonding/bond_main.c:2713:40: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be16 [usertype] vlan_proto @@ got int @@ drivers/net/bonding/bond_main.c:2713:40: sparse: expected restricted __be16 [usertype] vlan_proto drivers/net/bonding/bond_main.c:2713:40: sparse: got int drivers/net/bonding/bond_main.c:3561:25: sparse: sparse: restricted __be16 degrades to integer drivers/net/bonding/bond_main.c:3571:32: sparse: sparse: restricted __be16 degrades to integer >> drivers/net/bonding/bond_main.c:3640:48: sparse: sparse: incorrect type in argument 5 (different base types) @@ expected int l2_proto @@ got restricted __be16 [usertype] l2_proto @@ drivers/net/bonding/bond_main.c:3640:48: sparse: expected int l2_proto drivers/net/bonding/bond_main.c:3640:48: sparse: got restricted __be16 [usertype] l2_proto drivers/net/bonding/bond_main.c:3661:58: sparse: sparse: incorrect type in argument 5 (different base types) @@ expected int l2_proto @@ got restricted __be16 [usertype] l2_proto @@ drivers/net/bonding/bond_main.c:3661:58: sparse: expected int l2_proto drivers/net/bonding/bond_main.c:3661:58: sparse: got restricted __be16 [usertype] l2_proto >> drivers/net/bonding/bond_main.c:4633:16: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct bond_up_slave *slaves @@ got struct bond_up_slave [noderef] __rcu *usable_slaves @@ drivers/net/bonding/bond_main.c:4633:16: sparse: expected struct bond_up_slave *slaves drivers/net/bonding/bond_main.c:4633:16: sparse: got struct bond_up_slave [noderef] __rcu *usable_slaves drivers/net/bonding/bond_main.c:3552:52: sparse: sparse: restricted __be16 degrades to integer drivers/net/bonding/bond_main.c:3552:52: sparse: sparse: restricted __be16 degrades to integer vim +3640 drivers/net/bonding/bond_main.c 3615 3616 /* Extract the appropriate headers based on bond's xmit policy */ 3617 static bool bond_flow_dissect(struct bonding *bond, 3618 struct sk_buff *skb, 3619 const void *data, 3620 __be16 l2_proto, 3621 int nhoff, 3622 int hlen, 3623 struct flow_keys *fk) 3624 { 3625 bool l34 = bond->params.xmit_policy == BOND_XMIT_POLICY_LAYER34; 3626 int ip_proto = -1; 3627 3628 switch (bond->params.xmit_policy) { 3629 case BOND_XMIT_POLICY_ENCAP23: 3630 case BOND_XMIT_POLICY_ENCAP34: 3631 memset(fk, 0, sizeof(*fk)); 3632 return __skb_flow_dissect(NULL, skb, &flow_keys_bonding, 3633 fk, data, l2_proto, nhoff, hlen, 0); 3634 default: 3635 break; 3636 } 3637 3638 fk->ports.ports = 0; 3639 memset(&fk->icmp, 0, sizeof(fk->icmp)); > 3640 if (!bond_flow_ip(skb, fk, data, hlen, l2_proto, &nhoff, &ip_proto, l34)) 3641 return false; 3642 3643 /* ICMP error packets contains at least 8 bytes of the header 3644 * of the packet which generated the error. Use this information 3645 * to correlate ICMP error packets within the same flow which 3646 * generated the error. 3647 */ 3648 if (ip_proto == IPPROTO_ICMP || ip_proto == IPPROTO_ICMPV6) { 3649 skb_flow_get_icmp_tci(skb, &fk->icmp, data, nhoff, hlen); 3650 if (ip_proto == IPPROTO_ICMP) { 3651 if (!icmp_is_err(fk->icmp.type)) 3652 return true; 3653 3654 nhoff += sizeof(struct icmphdr); 3655 } else if (ip_proto == IPPROTO_ICMPV6) { 3656 if (!icmpv6_is_err(fk->icmp.type)) 3657 return true; 3658 3659 nhoff += sizeof(struct icmp6hdr); 3660 } 3661 return bond_flow_ip(skb, fk, data, hlen, l2_proto, &nhoff, &ip_proto, l34); 3662 } 3663 3664 return true; 3665 } 3666 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 47225 bytes --]
next prev parent reply other threads:[~2021-06-22 7:25 UTC|newest] Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-09 13:55 [PATCH bpf-next 0/3] XDP bonding support Jussi Maki 2021-06-09 13:55 ` [PATCH bpf-next 1/3] net: bonding: Add XDP support to the bonding driver Jussi Maki 2021-06-09 22:29 ` Maciej Fijalkowski 2021-06-09 23:29 ` Jay Vosburgh 2021-06-14 8:02 ` Jussi Maki 2021-06-17 3:40 ` kernel test robot 2021-06-17 3:40 ` kernel test robot 2021-06-17 6:35 ` kernel test robot 2021-06-17 6:35 ` kernel test robot 2021-06-22 7:24 ` kernel test robot [this message] 2021-06-22 7:24 ` kernel test robot 2021-06-09 13:55 ` [PATCH bpf-next 2/3] net: bonding: Use per-cpu rr_tx_counter Jussi Maki 2021-06-10 0:04 ` Jay Vosburgh 2021-06-14 7:54 ` Jussi Maki 2021-06-09 13:55 ` [PATCH bpf-next 3/3] selftests/bpf: Add tests for XDP bonding Jussi Maki 2021-06-09 22:07 ` Maciej Fijalkowski 2021-06-14 8:08 ` Jussi Maki 2021-06-14 8:48 ` Magnus Karlsson 2021-06-14 12:20 ` Jussi Maki 2021-06-10 17:24 ` [PATCH bpf-next 0/3] XDP bonding support Andrii Nakryiko 2021-06-14 12:25 ` Jussi Maki 2021-06-14 15:37 ` Jay Vosburgh 2021-06-15 5:34 ` Andrii Nakryiko 2021-06-24 9:18 ` [PATCH bpf-next v2 0/4] " joamaki 2021-06-24 9:18 ` [PATCH bpf-next v2 1/4] net: bonding: Refactor bond_xmit_hash for use with xdp_buff joamaki 2021-06-24 9:18 ` [PATCH bpf-next v2 2/4] net: core: Add support for XDP redirection to slave device joamaki 2021-06-24 9:18 ` [PATCH bpf-next v2 3/4] net: bonding: Add XDP support to the bonding driver joamaki 2021-06-24 9:18 ` [PATCH bpf-next v2 4/4] devmap: Exclude XDP broadcast to master device joamaki 2021-07-01 18:12 ` Jay Vosburgh 2021-07-05 11:44 ` Jussi Maki 2021-07-01 18:20 ` [PATCH bpf-next v2 0/4] XDP bonding support Jay Vosburgh 2021-07-05 10:32 ` Jussi Maki 2021-07-07 11:25 ` [PATCH bpf-next v3 0/5] " Jussi Maki 2021-07-07 11:25 ` [PATCH bpf-next v3 1/5] net: bonding: Refactor bond_xmit_hash for use with xdp_buff Jussi Maki 2021-07-07 11:25 ` [PATCH bpf-next v3 2/5] net: core: Add support for XDP redirection to slave device Jussi Maki 2021-07-07 11:25 ` [PATCH bpf-next v3 3/5] net: bonding: Add XDP support to the bonding driver Jussi Maki 2021-07-13 7:14 ` kernel test robot 2021-07-13 7:14 ` kernel test robot 2021-07-07 11:25 ` [PATCH bpf-next v3 4/5] devmap: Exclude XDP broadcast to master device Jussi Maki 2021-07-07 11:25 ` [PATCH bpf-next v3 5/5] net: core: Allow netdev_lower_get_next_private_rcu in bh context Jussi Maki 2021-07-28 23:43 ` [PATCH bpf-next v4 0/6] XDP bonding support joamaki 2021-07-28 23:43 ` [PATCH bpf-next v4 1/6] net: bonding: Refactor bond_xmit_hash for use with xdp_buff joamaki 2021-07-28 23:43 ` [PATCH bpf-next v4 2/6] net: core: Add support for XDP redirection to slave device joamaki 2021-07-28 23:43 ` [PATCH bpf-next v4 3/6] net: bonding: Add XDP support to the bonding driver joamaki 2021-07-28 23:43 ` [PATCH bpf-next v4 4/6] devmap: Exclude XDP broadcast to master device joamaki 2021-07-28 23:43 ` [PATCH bpf-next v4 5/6] net: core: Allow netdev_lower_get_next_private_rcu in bh context joamaki 2021-07-28 23:43 ` [PATCH bpf-next v4 6/6] selftests/bpf: Add tests for XDP bonding joamaki 2021-08-03 0:19 ` Andrii Nakryiko 2021-08-03 9:40 ` Jussi Maki 2021-07-30 6:18 ` [PATCH bpf-next v5 0/7] XDP bonding support Jussi Maki 2021-07-30 6:18 ` [PATCH bpf-next v5 1/7] net: bonding: Refactor bond_xmit_hash for use with xdp_buff Jussi Maki 2021-07-30 6:18 ` [PATCH bpf-next v5 2/7] net: core: Add support for XDP redirection to slave device Jussi Maki 2021-07-30 6:18 ` [PATCH bpf-next v5 3/7] net: bonding: Add XDP support to the bonding driver Jussi Maki 2021-07-30 6:18 ` [PATCH bpf-next v5 4/7] devmap: Exclude XDP broadcast to master device Jussi Maki 2021-07-30 6:18 ` [PATCH bpf-next v5 5/7] net: core: Allow netdev_lower_get_next_private_rcu in bh context Jussi Maki 2021-07-30 6:18 ` [PATCH bpf-next v5 6/7] selftests/bpf: Fix xdp_tx.c prog section name Jussi Maki 2021-08-04 23:35 ` Andrii Nakryiko 2021-07-30 6:18 ` [PATCH bpf-next v5 7/7] selftests/bpf: Add tests for XDP bonding Jussi Maki 2021-08-04 23:33 ` Andrii Nakryiko 2021-07-31 5:57 ` [PATCH bpf-next v6 0/7]: XDP bonding support Jussi Maki 2021-07-31 5:57 ` [PATCH bpf-next v6 1/7] net: bonding: Refactor bond_xmit_hash for use with xdp_buff Jussi Maki 2021-08-11 1:52 ` Jonathan Toppins 2021-08-11 8:22 ` Jussi Maki 2021-08-11 14:05 ` Jonathan Toppins 2021-08-16 9:05 ` Jussi Maki 2021-07-31 5:57 ` [PATCH bpf-next v6 2/7] net: core: Add support for XDP redirection to slave device Jussi Maki 2021-07-31 5:57 ` [PATCH bpf-next v6 3/7] net: bonding: Add XDP support to the bonding driver Jussi Maki 2021-07-31 5:57 ` [PATCH bpf-next v6 4/7] devmap: Exclude XDP broadcast to master device Jussi Maki 2021-07-31 5:57 ` [PATCH bpf-next v6 5/7] net: core: Allow netdev_lower_get_next_private_rcu in bh context Jussi Maki 2021-07-31 5:57 ` [PATCH bpf-next v6 6/7] selftests/bpf: Fix xdp_tx.c prog section name Jussi Maki 2021-08-06 22:53 ` Andrii Nakryiko 2021-07-31 5:57 ` [PATCH bpf-next v6 7/7] selftests/bpf: Add tests for XDP bonding Jussi Maki 2021-08-06 22:50 ` Andrii Nakryiko 2021-08-09 14:24 ` Jussi Maki 2021-08-09 21:41 ` Daniel Borkmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202106221509.kwNvAAZg-lkp@intel.com \ --to=lkp@intel.com \ --cc=andrii@kernel.org \ --cc=andy@greyhouse.net \ --cc=bpf@vger.kernel.org \ --cc=daniel@iogearbox.net \ --cc=j.vosburgh@gmail.com \ --cc=joamaki@gmail.com \ --cc=kbuild-all@lists.01.org \ --cc=netdev@vger.kernel.org \ --cc=vfalico@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.