From: Guenter Roeck <linux@roeck-us.net>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: Art Nikpal <email2tema@gmail.com>,
wim@linux-watchdog.org, Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Christian Hewitt <christianshewitt@gmail.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-watchdog@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
linux-kernel@vger.kernel.org, Artem Lapkin <art@khadas.com>,
Nick Xie <nick@khadas.com>, Gouwa Wang <gouwa@khadas.com>
Subject: Re: [PATCH] watchdog: meson_gxbb_wdt: improve
Date: Tue, 22 Jun 2021 10:00:37 -0700 [thread overview]
Message-ID: <20210622170037.GA3440464@roeck-us.net> (raw)
In-Reply-To: <0d5e53b2-873e-0ffa-32eb-87e96b51e263@baylibre.com>
On Tue, Jun 22, 2021 at 02:43:45PM +0200, Neil Armstrong wrote:
> Hi,
>
> On 22/06/2021 13:53, Art Nikpal wrote:
> >> Neil
> >> Can you split the patch in 4 distinct changes ?
> >
> > yes no problem i can try to do it tomorrow !
> > maybe somebody have other ideas, suggestion, comments ...
>
> The changeset is clean, and overall I'm ok with the changes, but I'm pretty sure the wdt maintainers
> will prefer separate changes in order to comment of each.
Correct. As per guidelines, "one logical change per patch".
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: Art Nikpal <email2tema@gmail.com>,
wim@linux-watchdog.org, Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Christian Hewitt <christianshewitt@gmail.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-watchdog@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
linux-kernel@vger.kernel.org, Artem Lapkin <art@khadas.com>,
Nick Xie <nick@khadas.com>, Gouwa Wang <gouwa@khadas.com>
Subject: Re: [PATCH] watchdog: meson_gxbb_wdt: improve
Date: Tue, 22 Jun 2021 10:00:37 -0700 [thread overview]
Message-ID: <20210622170037.GA3440464@roeck-us.net> (raw)
In-Reply-To: <0d5e53b2-873e-0ffa-32eb-87e96b51e263@baylibre.com>
On Tue, Jun 22, 2021 at 02:43:45PM +0200, Neil Armstrong wrote:
> Hi,
>
> On 22/06/2021 13:53, Art Nikpal wrote:
> >> Neil
> >> Can you split the patch in 4 distinct changes ?
> >
> > yes no problem i can try to do it tomorrow !
> > maybe somebody have other ideas, suggestion, comments ...
>
> The changeset is clean, and overall I'm ok with the changes, but I'm pretty sure the wdt maintainers
> will prefer separate changes in order to comment of each.
Correct. As per guidelines, "one logical change per patch".
Guenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: Art Nikpal <email2tema@gmail.com>,
wim@linux-watchdog.org, Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Christian Hewitt <christianshewitt@gmail.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-watchdog@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
linux-kernel@vger.kernel.org, Artem Lapkin <art@khadas.com>,
Nick Xie <nick@khadas.com>, Gouwa Wang <gouwa@khadas.com>
Subject: Re: [PATCH] watchdog: meson_gxbb_wdt: improve
Date: Tue, 22 Jun 2021 10:00:37 -0700 [thread overview]
Message-ID: <20210622170037.GA3440464@roeck-us.net> (raw)
In-Reply-To: <0d5e53b2-873e-0ffa-32eb-87e96b51e263@baylibre.com>
On Tue, Jun 22, 2021 at 02:43:45PM +0200, Neil Armstrong wrote:
> Hi,
>
> On 22/06/2021 13:53, Art Nikpal wrote:
> >> Neil
> >> Can you split the patch in 4 distinct changes ?
> >
> > yes no problem i can try to do it tomorrow !
> > maybe somebody have other ideas, suggestion, comments ...
>
> The changeset is clean, and overall I'm ok with the changes, but I'm pretty sure the wdt maintainers
> will prefer separate changes in order to comment of each.
Correct. As per guidelines, "one logical change per patch".
Guenter
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2021-06-22 17:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 9:56 [PATCH] watchdog: meson_gxbb_wdt: improve Artem Lapkin
2021-06-22 9:56 ` Artem Lapkin
2021-06-22 9:56 ` Artem Lapkin
2021-06-22 11:08 ` Neil Armstrong
2021-06-22 11:08 ` Neil Armstrong
2021-06-22 11:08 ` Neil Armstrong
2021-06-22 11:53 ` Art Nikpal
2021-06-22 11:53 ` Art Nikpal
2021-06-22 11:53 ` Art Nikpal
2021-06-22 12:43 ` Neil Armstrong
2021-06-22 12:43 ` Neil Armstrong
2021-06-22 12:43 ` Neil Armstrong
2021-06-22 17:00 ` Guenter Roeck [this message]
2021-06-22 17:00 ` Guenter Roeck
2021-06-22 17:00 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210622170037.GA3440464@roeck-us.net \
--to=linux@roeck-us.net \
--cc=art@khadas.com \
--cc=christianshewitt@gmail.com \
--cc=email2tema@gmail.com \
--cc=gouwa@khadas.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=nick@khadas.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.