* [PATCH] add "else {...}" according coding style
@ 2021-06-23 7:32 ` Cai Huoqing
0 siblings, 0 replies; 2+ messages in thread
From: Cai Huoqing @ 2021-06-23 7:32 UTC (permalink / raw)
To: mst, jasowang, davem, kuba
Cc: virtualization, netdev, linux-kernel, kvm, Cai Huoqing
coding-style.rst shows that:
if (condition) {
do_this();
do_that();
} else {
otherwise();
}
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/net/virtio_net.c | 3 ++-
drivers/vhost/vringh.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 21ff7b9e49c2..7cd062cb468e 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -314,8 +314,9 @@ static struct page *get_a_page(struct receive_queue *rq, gfp_t gfp_mask)
rq->pages = (struct page *)p->private;
/* clear private here, it is used to chain pages */
p->private = 0;
- } else
+ } else {
p = alloc_page(gfp_mask);
+ }
return p;
}
diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c
index 4af8fa259d65..79542cad1072 100644
--- a/drivers/vhost/vringh.c
+++ b/drivers/vhost/vringh.c
@@ -454,8 +454,9 @@ static inline int __vringh_complete(struct vringh *vrh,
if (!err)
err = putused(vrh, &used_ring->ring[0], used + part,
num_used - part);
- } else
+ } else {
err = putused(vrh, &used_ring->ring[off], used, num_used);
+ }
if (err) {
vringh_bad("Failed to write %u used entries %u at %p",
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] add "else {...}" according coding style
@ 2021-06-23 7:32 ` Cai Huoqing
0 siblings, 0 replies; 2+ messages in thread
From: Cai Huoqing @ 2021-06-23 7:32 UTC (permalink / raw)
To: mst, jasowang, davem, kuba; +Cc: netdev, linux-kernel, kvm, virtualization
coding-style.rst shows that:
if (condition) {
do_this();
do_that();
} else {
otherwise();
}
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/net/virtio_net.c | 3 ++-
drivers/vhost/vringh.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 21ff7b9e49c2..7cd062cb468e 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -314,8 +314,9 @@ static struct page *get_a_page(struct receive_queue *rq, gfp_t gfp_mask)
rq->pages = (struct page *)p->private;
/* clear private here, it is used to chain pages */
p->private = 0;
- } else
+ } else {
p = alloc_page(gfp_mask);
+ }
return p;
}
diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c
index 4af8fa259d65..79542cad1072 100644
--- a/drivers/vhost/vringh.c
+++ b/drivers/vhost/vringh.c
@@ -454,8 +454,9 @@ static inline int __vringh_complete(struct vringh *vrh,
if (!err)
err = putused(vrh, &used_ring->ring[0], used + part,
num_used - part);
- } else
+ } else {
err = putused(vrh, &used_ring->ring[off], used, num_used);
+ }
if (err) {
vringh_bad("Failed to write %u used entries %u at %p",
--
2.17.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-23 7:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-23 7:32 [PATCH] add "else {...}" according coding style Cai Huoqing
2021-06-23 7:32 ` Cai Huoqing
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.