All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] ALSA: hda: Release display power reference during shutdown/reboot
@ 2021-06-21 17:44 Imre Deak
  2021-06-21 18:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (7 more replies)
  0 siblings, 8 replies; 13+ messages in thread
From: Imre Deak @ 2021-06-21 17:44 UTC (permalink / raw)
  To: intel-gfx; +Cc: Takashi Iwai, Thomas Voegtle

Make sure the HDA driver's display power reference is released during
shutdown/reboot.

During the shutdown/reboot sequence the pci device core calls the
pm_runtime_resume handler for all devices before calling the driver's
shutdown callback and so the HDA driver's runtime resume callback will
acquire a display power reference (on HSW/BDW). This triggers a power
reference held WARN on HSW/BDW in the i915 driver's subsequent shutdown
handler, which expects all display power references to be released by
that time.

Since the HDA controller is stopped in the shutdown handler in any case,
let's follow here the same sequence as the one during runtime suspend.
This will also reset the HDA link and drop the display power reference,
getting rid of the above WARN.

Tested on HSW.

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3618
Reported-and-tested-by: Thomas Voegtle <tv@lio96.de>
Cc: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 sound/pci/hda/hda_intel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 7f8f11536a3dc..d0993c22c5e60 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2383,7 +2383,7 @@ static void azx_shutdown(struct pci_dev *pci)
 		return;
 	chip = card->private_data;
 	if (chip && chip->running)
-		azx_stop_chip(chip);
+		__azx_runtime_suspend(chip);
 }
 
 /* PCI IDs */
-- 
2.27.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2021-06-23 13:45 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-21 17:44 [Intel-gfx] [PATCH] ALSA: hda: Release display power reference during shutdown/reboot Imre Deak
2021-06-21 18:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-06-21 20:48 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-06-21 21:38 ` [Intel-gfx] [PATCH] " kernel test robot
2021-06-21 21:38   ` kernel test robot
2021-06-22 14:18 ` Takashi Iwai
2021-06-22 19:58   ` Imre Deak
2021-06-23  8:07     ` Takashi Iwai
2021-06-23 13:44       ` Imre Deak
2021-06-22 20:06 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for ALSA: hda: Release display power reference during shutdown/reboot (rev2) Patchwork
2021-06-23  9:04 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for ALSA: hda: Release display power reference during shutdown/reboot (rev3) Patchwork
2021-06-23  9:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-06-23 11:16 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.