From: kernel test robot <lkp@intel.com>
To: Yizhuo Zhai <yzhai003@ucr.edu>
Cc: kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: [linux-next:master 11317/12271] drivers/input/touchscreen/hideep.c:470 hideep_program_nvm() warn: inconsistent indenting
Date: Wed, 23 Jun 2021 17:11:25 +0800 [thread overview]
Message-ID: <202106231721.UtnFZELc-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2225 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 4238b1710eadd18dd16de0288a2bc5bb84614b4e
commit: cac7100d4c51c04979dacdfe6c9a5e400d3f0a27 [11317/12271] Input: hideep - fix the uninitialized use in hideep_nvm_unlock()
config: powerpc64-randconfig-m031-20210622 (attached as .config)
compiler: powerpc64le-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
smatch warnings:
drivers/input/touchscreen/hideep.c:470 hideep_program_nvm() warn: inconsistent indenting
vim +470 drivers/input/touchscreen/hideep.c
459
460 static int hideep_program_nvm(struct hideep_ts *ts,
461 const __be32 *ucode, size_t ucode_len)
462 {
463 struct pgm_packet *packet_r = (void *)ts->xfer_buf;
464 __be32 *current_ucode = packet_r->payload;
465 size_t xfer_len;
466 size_t xfer_count;
467 u32 addr = 0;
468 int error;
469
> 470 error = hideep_nvm_unlock(ts);
471 if (error)
472 return error;
473
474 while (ucode_len > 0) {
475 xfer_len = min_t(size_t, ucode_len, HIDEEP_NVM_PAGE_SIZE);
476 xfer_count = xfer_len / sizeof(*ucode);
477
478 error = hideep_pgm_r_mem(ts, 0x00000000 + addr,
479 current_ucode, xfer_count);
480 if (error) {
481 dev_err(&ts->client->dev,
482 "%s: failed to read page at offset %#08x: %d\n",
483 __func__, addr, error);
484 return error;
485 }
486
487 /* See if the page needs updating */
488 if (memcmp(ucode, current_ucode, xfer_len)) {
489 error = hideep_program_page(ts, addr,
490 ucode, xfer_count);
491 if (error) {
492 dev_err(&ts->client->dev,
493 "%s: iwrite failure @%#08x: %d\n",
494 __func__, addr, error);
495 return error;
496 }
497
498 usleep_range(1000, 1100);
499 }
500
501 ucode += xfer_count;
502 addr += xfer_len;
503 ucode_len -= xfer_len;
504 }
505
506 return 0;
507 }
508
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34054 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [linux-next:master 11317/12271] drivers/input/touchscreen/hideep.c:470 hideep_program_nvm() warn: inconsistent indenting
Date: Wed, 23 Jun 2021 17:11:25 +0800 [thread overview]
Message-ID: <202106231721.UtnFZELc-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2295 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 4238b1710eadd18dd16de0288a2bc5bb84614b4e
commit: cac7100d4c51c04979dacdfe6c9a5e400d3f0a27 [11317/12271] Input: hideep - fix the uninitialized use in hideep_nvm_unlock()
config: powerpc64-randconfig-m031-20210622 (attached as .config)
compiler: powerpc64le-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
smatch warnings:
drivers/input/touchscreen/hideep.c:470 hideep_program_nvm() warn: inconsistent indenting
vim +470 drivers/input/touchscreen/hideep.c
459
460 static int hideep_program_nvm(struct hideep_ts *ts,
461 const __be32 *ucode, size_t ucode_len)
462 {
463 struct pgm_packet *packet_r = (void *)ts->xfer_buf;
464 __be32 *current_ucode = packet_r->payload;
465 size_t xfer_len;
466 size_t xfer_count;
467 u32 addr = 0;
468 int error;
469
> 470 error = hideep_nvm_unlock(ts);
471 if (error)
472 return error;
473
474 while (ucode_len > 0) {
475 xfer_len = min_t(size_t, ucode_len, HIDEEP_NVM_PAGE_SIZE);
476 xfer_count = xfer_len / sizeof(*ucode);
477
478 error = hideep_pgm_r_mem(ts, 0x00000000 + addr,
479 current_ucode, xfer_count);
480 if (error) {
481 dev_err(&ts->client->dev,
482 "%s: failed to read page at offset %#08x: %d\n",
483 __func__, addr, error);
484 return error;
485 }
486
487 /* See if the page needs updating */
488 if (memcmp(ucode, current_ucode, xfer_len)) {
489 error = hideep_program_page(ts, addr,
490 ucode, xfer_count);
491 if (error) {
492 dev_err(&ts->client->dev,
493 "%s: iwrite failure @%#08x: %d\n",
494 __func__, addr, error);
495 return error;
496 }
497
498 usleep_range(1000, 1100);
499 }
500
501 ucode += xfer_count;
502 addr += xfer_len;
503 ucode_len -= xfer_len;
504 }
505
506 return 0;
507 }
508
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34054 bytes --]
next reply other threads:[~2021-06-23 9:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 9:11 kernel test robot [this message]
2021-06-23 9:11 ` [linux-next:master 11317/12271] drivers/input/touchscreen/hideep.c:470 hideep_program_nvm() warn: inconsistent indenting kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202106231721.UtnFZELc-lkp@intel.com \
--to=lkp@intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=yzhai003@ucr.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.