From: Drew Fustini <drew@beagleboard.org> To: Akira Tsukamoto <akira.tsukamoto@gmail.com> Cc: "Paul Walmsley" <paul.walmsley@sifive.com>, "Palmer Dabbelt" <palmer@dabbelt.com>, "Albert Ou" <aou@eecs.berkeley.edu>, "Atish Patra" <atish.patra@wdc.com>, "Anup Patel" <anup.patel@wdc.com>, "Emil Renner Berthing" <kernel@esmil.dk>, "Björn Töpel" <bjorn@kernel.org>, "Sagar Shrikant Kadam" <sagar.kadam@sifive.com>, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 0/1] Adding jh7100 SoC to defconfig Date: Wed, 23 Jun 2021 11:50:43 -0700 [thread overview] Message-ID: <20210623185043.GA493015@x1> (raw) In-Reply-To: <f22f6d7e-97ab-85db-5448-c2bcef0ea0e7@gmail.com> On Wed, Jun 23, 2021 at 09:45:52PM +0900, Akira Tsukamoto wrote: > > Would like to have comments for adding jh7100 SoC to defconfig. Thanks for preparing this defconfig. Let's refer to the SoC as StarFive JH7100 SoC [1] which is used in the BeagleV Starlight JH7100 board [2]. > To make the upstream friendly, try to add as minimum as possible in > arch/riscv/configs/defconfig required for beaglev-beta against the Please use "BeagleV Starlight JH7100" instead of beaglev-beta. > upstream defconfig. I might have added too much configs. > > Then the distro vendors could use: > make defconfig beablev-fedora.config > or > make defconfig beablev-debian.config > > while distro vendors keeping beablev-fedora.config and > beablev-debian.config in their own repositories to make one binary kernel > which boots for all riscv boards. Note about naming, BeagleV refers to any RISC-V board produced by BeagleBoard.org and likely in the future will include other SoC families. > > Probably, it is not good practice to add a different defconfig file under > arch/riscv/configs/ when each new riscv board comes out. We currently have: defconfig nommu_k210_defconfig nommu_k210_sdcard_defconfig nommu_virt_defconfig rv32_defconfig It seems like 'defconfig' supports the SiFive Unleashed board which makes sense as it was the only board for a longtime: $ git grep -i sifive defconfig:CONFIG_SOC_SIFIVE=y defconfig:CONFIG_SPI_SIFIVE=y defconfig:CONFIG_GPIO_SIFIVE=y I suppose the kconfig options needed for BeagleV Starlight JH7100 could be added to 'defconfig' as long as there were no incompatibilities. I assume the k210 versions were added because that is a rather odd SoC that has a non-supported MMU and thus runs in m-mode. Thanks, Drew [1] https://github.com/starfive-tech/beaglev_doc/ [2] https://github.com/beagleboard/beaglev-starlight
WARNING: multiple messages have this Message-ID (diff)
From: Drew Fustini <drew@beagleboard.org> To: Akira Tsukamoto <akira.tsukamoto@gmail.com> Cc: "Paul Walmsley" <paul.walmsley@sifive.com>, "Palmer Dabbelt" <palmer@dabbelt.com>, "Albert Ou" <aou@eecs.berkeley.edu>, "Atish Patra" <atish.patra@wdc.com>, "Anup Patel" <anup.patel@wdc.com>, "Emil Renner Berthing" <kernel@esmil.dk>, "Björn Töpel" <bjorn@kernel.org>, "Sagar Shrikant Kadam" <sagar.kadam@sifive.com>, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 0/1] Adding jh7100 SoC to defconfig Date: Wed, 23 Jun 2021 11:50:43 -0700 [thread overview] Message-ID: <20210623185043.GA493015@x1> (raw) In-Reply-To: <f22f6d7e-97ab-85db-5448-c2bcef0ea0e7@gmail.com> On Wed, Jun 23, 2021 at 09:45:52PM +0900, Akira Tsukamoto wrote: > > Would like to have comments for adding jh7100 SoC to defconfig. Thanks for preparing this defconfig. Let's refer to the SoC as StarFive JH7100 SoC [1] which is used in the BeagleV Starlight JH7100 board [2]. > To make the upstream friendly, try to add as minimum as possible in > arch/riscv/configs/defconfig required for beaglev-beta against the Please use "BeagleV Starlight JH7100" instead of beaglev-beta. > upstream defconfig. I might have added too much configs. > > Then the distro vendors could use: > make defconfig beablev-fedora.config > or > make defconfig beablev-debian.config > > while distro vendors keeping beablev-fedora.config and > beablev-debian.config in their own repositories to make one binary kernel > which boots for all riscv boards. Note about naming, BeagleV refers to any RISC-V board produced by BeagleBoard.org and likely in the future will include other SoC families. > > Probably, it is not good practice to add a different defconfig file under > arch/riscv/configs/ when each new riscv board comes out. We currently have: defconfig nommu_k210_defconfig nommu_k210_sdcard_defconfig nommu_virt_defconfig rv32_defconfig It seems like 'defconfig' supports the SiFive Unleashed board which makes sense as it was the only board for a longtime: $ git grep -i sifive defconfig:CONFIG_SOC_SIFIVE=y defconfig:CONFIG_SPI_SIFIVE=y defconfig:CONFIG_GPIO_SIFIVE=y I suppose the kconfig options needed for BeagleV Starlight JH7100 could be added to 'defconfig' as long as there were no incompatibilities. I assume the k210 versions were added because that is a rather odd SoC that has a non-supported MMU and thus runs in m-mode. Thanks, Drew [1] https://github.com/starfive-tech/beaglev_doc/ [2] https://github.com/beagleboard/beaglev-starlight _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-06-23 18:50 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-23 12:45 [RFC PATCH 0/1] Adding jh7100 SoC to defconfig Akira Tsukamoto 2021-06-23 12:45 ` Akira Tsukamoto 2021-06-23 12:46 ` [PATCH 1/1] config: Enable jh7100 SoC Akira Tsukamoto 2021-06-23 12:46 ` Akira Tsukamoto 2021-06-23 13:21 ` Jisheng Zhang 2021-06-23 13:21 ` Jisheng Zhang 2021-06-24 14:35 ` Akira Tsukamoto 2021-06-24 14:35 ` Akira Tsukamoto 2021-06-23 19:08 ` Drew Fustini 2021-06-23 19:08 ` Drew Fustini 2021-06-24 14:49 ` Akira Tsukamoto 2021-06-24 14:49 ` Akira Tsukamoto 2021-06-23 18:50 ` Drew Fustini [this message] 2021-06-23 18:50 ` [RFC PATCH 0/1] Adding jh7100 SoC to defconfig Drew Fustini 2021-06-24 14:42 ` Akira Tsukamoto 2021-06-24 14:42 ` Akira Tsukamoto
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210623185043.GA493015@x1 \ --to=drew@beagleboard.org \ --cc=akira.tsukamoto@gmail.com \ --cc=anup.patel@wdc.com \ --cc=aou@eecs.berkeley.edu \ --cc=atish.patra@wdc.com \ --cc=bjorn@kernel.org \ --cc=kernel@esmil.dk \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=sagar.kadam@sifive.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.