* [PATCH] xfs: Initialize error in xfs_attr_remove_iter
@ 2021-06-22 21:08 Allison Henderson
2021-06-23 10:18 ` Brian Foster
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Allison Henderson @ 2021-06-22 21:08 UTC (permalink / raw)
To: linux-xfs
A recent bug report generated a warning that a code path in
xfs_attr_remove_iter could potentially return error uninitialized in the
case of XFS_DAS_RM_SHRINK state. Fix this by initializing error.
Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
---
fs/xfs/libxfs/xfs_attr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c
index 611dc67..d9d7d51 100644
--- a/fs/xfs/libxfs/xfs_attr.c
+++ b/fs/xfs/libxfs/xfs_attr.c
@@ -1375,7 +1375,7 @@ xfs_attr_remove_iter(
{
struct xfs_da_args *args = dac->da_args;
struct xfs_da_state *state = dac->da_state;
- int retval, error;
+ int retval, error = 0;
struct xfs_inode *dp = args->dp;
trace_xfs_attr_node_removename(args);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] xfs: Initialize error in xfs_attr_remove_iter
2021-06-22 21:08 [PATCH] xfs: Initialize error in xfs_attr_remove_iter Allison Henderson
@ 2021-06-23 10:18 ` Brian Foster
2021-06-23 20:00 ` Bill O'Donnell
2021-06-25 18:20 ` Darrick J. Wong
2 siblings, 0 replies; 4+ messages in thread
From: Brian Foster @ 2021-06-23 10:18 UTC (permalink / raw)
To: Allison Henderson; +Cc: linux-xfs
On Tue, Jun 22, 2021 at 02:08:52PM -0700, Allison Henderson wrote:
> A recent bug report generated a warning that a code path in
> xfs_attr_remove_iter could potentially return error uninitialized in the
> case of XFS_DAS_RM_SHRINK state. Fix this by initializing error.
>
> Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/libxfs/xfs_attr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c
> index 611dc67..d9d7d51 100644
> --- a/fs/xfs/libxfs/xfs_attr.c
> +++ b/fs/xfs/libxfs/xfs_attr.c
> @@ -1375,7 +1375,7 @@ xfs_attr_remove_iter(
> {
> struct xfs_da_args *args = dac->da_args;
> struct xfs_da_state *state = dac->da_state;
> - int retval, error;
> + int retval, error = 0;
> struct xfs_inode *dp = args->dp;
>
> trace_xfs_attr_node_removename(args);
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] xfs: Initialize error in xfs_attr_remove_iter
2021-06-22 21:08 [PATCH] xfs: Initialize error in xfs_attr_remove_iter Allison Henderson
2021-06-23 10:18 ` Brian Foster
@ 2021-06-23 20:00 ` Bill O'Donnell
2021-06-25 18:20 ` Darrick J. Wong
2 siblings, 0 replies; 4+ messages in thread
From: Bill O'Donnell @ 2021-06-23 20:00 UTC (permalink / raw)
To: Allison Henderson; +Cc: linux-xfs
On Tue, Jun 22, 2021 at 02:08:52PM -0700, Allison Henderson wrote:
> A recent bug report generated a warning that a code path in
> xfs_attr_remove_iter could potentially return error uninitialized in the
> case of XFS_DAS_RM_SHRINK state. Fix this by initializing error.
>
> Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Bill O'Donnell <bodonnel@redhat.com>
> ---
> fs/xfs/libxfs/xfs_attr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c
> index 611dc67..d9d7d51 100644
> --- a/fs/xfs/libxfs/xfs_attr.c
> +++ b/fs/xfs/libxfs/xfs_attr.c
> @@ -1375,7 +1375,7 @@ xfs_attr_remove_iter(
> {
> struct xfs_da_args *args = dac->da_args;
> struct xfs_da_state *state = dac->da_state;
> - int retval, error;
> + int retval, error = 0;
> struct xfs_inode *dp = args->dp;
>
> trace_xfs_attr_node_removename(args);
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] xfs: Initialize error in xfs_attr_remove_iter
2021-06-22 21:08 [PATCH] xfs: Initialize error in xfs_attr_remove_iter Allison Henderson
2021-06-23 10:18 ` Brian Foster
2021-06-23 20:00 ` Bill O'Donnell
@ 2021-06-25 18:20 ` Darrick J. Wong
2 siblings, 0 replies; 4+ messages in thread
From: Darrick J. Wong @ 2021-06-25 18:20 UTC (permalink / raw)
To: Allison Henderson; +Cc: linux-xfs
On Tue, Jun 22, 2021 at 02:08:52PM -0700, Allison Henderson wrote:
> A recent bug report generated a warning that a code path in
> xfs_attr_remove_iter could potentially return error uninitialized in the
> case of XFS_DAS_RM_SHRINK state. Fix this by initializing error.
>
> Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Looks good,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/libxfs/xfs_attr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c
> index 611dc67..d9d7d51 100644
> --- a/fs/xfs/libxfs/xfs_attr.c
> +++ b/fs/xfs/libxfs/xfs_attr.c
> @@ -1375,7 +1375,7 @@ xfs_attr_remove_iter(
> {
> struct xfs_da_args *args = dac->da_args;
> struct xfs_da_state *state = dac->da_state;
> - int retval, error;
> + int retval, error = 0;
> struct xfs_inode *dp = args->dp;
>
> trace_xfs_attr_node_removename(args);
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-25 18:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-22 21:08 [PATCH] xfs: Initialize error in xfs_attr_remove_iter Allison Henderson
2021-06-23 10:18 ` Brian Foster
2021-06-23 20:00 ` Bill O'Donnell
2021-06-25 18:20 ` Darrick J. Wong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.