* [PATCH] ARM: pxa: ssp: remove unnecessary print function dev_err()
@ 2021-06-24 2:41 ` 13145886936
0 siblings, 0 replies; 6+ messages in thread
From: 13145886936 @ 2021-06-24 2:41 UTC (permalink / raw)
To: linux, linux-arm-kernel; +Cc: linux-kernel, gushengxian
From: gushengxian <gushengxian@yulong.com>
The print function dev_err() is redundant because
platform_get_irq() already prints an error.
Signed-off-by: gushengxian <gushengxian@yulong.com>
---
arch/arm/plat-pxa/ssp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c
index 563440315acd..96b8765e4f57 100644
--- a/arch/arm/plat-pxa/ssp.c
+++ b/arch/arm/plat-pxa/ssp.c
@@ -147,7 +147,6 @@ static int pxa_ssp_probe(struct platform_device *pdev)
ssp->irq = platform_get_irq(pdev, 0);
if (ssp->irq < 0) {
- dev_err(dev, "no IRQ resource defined\n");
return -ENODEV;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: pxa: ssp: remove unnecessary print function dev_err()
@ 2021-06-24 2:41 ` 13145886936
0 siblings, 0 replies; 6+ messages in thread
From: 13145886936 @ 2021-06-24 2:41 UTC (permalink / raw)
To: linux, linux-arm-kernel; +Cc: linux-kernel, gushengxian
From: gushengxian <gushengxian@yulong.com>
The print function dev_err() is redundant because
platform_get_irq() already prints an error.
Signed-off-by: gushengxian <gushengxian@yulong.com>
---
arch/arm/plat-pxa/ssp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c
index 563440315acd..96b8765e4f57 100644
--- a/arch/arm/plat-pxa/ssp.c
+++ b/arch/arm/plat-pxa/ssp.c
@@ -147,7 +147,6 @@ static int pxa_ssp_probe(struct platform_device *pdev)
ssp->irq = platform_get_irq(pdev, 0);
if (ssp->irq < 0) {
- dev_err(dev, "no IRQ resource defined\n");
return -ENODEV;
}
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: pxa: ssp: remove unnecessary print function dev_err()
2021-06-24 2:41 ` 13145886936
@ 2021-06-24 9:24 ` Russell King (Oracle)
-1 siblings, 0 replies; 6+ messages in thread
From: Russell King (Oracle) @ 2021-06-24 9:24 UTC (permalink / raw)
To: 13145886936; +Cc: linux-arm-kernel, linux-kernel, gushengxian
On Wed, Jun 23, 2021 at 07:41:39PM -0700, 13145886936@163.com wrote:
> From: gushengxian <gushengxian@yulong.com>
>
> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.
>
> Signed-off-by: gushengxian <gushengxian@yulong.com>
> ---
> arch/arm/plat-pxa/ssp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c
> index 563440315acd..96b8765e4f57 100644
> --- a/arch/arm/plat-pxa/ssp.c
> +++ b/arch/arm/plat-pxa/ssp.c
> @@ -147,7 +147,6 @@ static int pxa_ssp_probe(struct platform_device *pdev)
>
> ssp->irq = platform_get_irq(pdev, 0);
> if (ssp->irq < 0) {
> - dev_err(dev, "no IRQ resource defined\n");
> return -ENODEV;
> }
Please also remove the now unnecessary braces around the return block.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: pxa: ssp: remove unnecessary print function dev_err()
@ 2021-06-24 9:24 ` Russell King (Oracle)
0 siblings, 0 replies; 6+ messages in thread
From: Russell King (Oracle) @ 2021-06-24 9:24 UTC (permalink / raw)
To: 13145886936; +Cc: linux-arm-kernel, linux-kernel, gushengxian
On Wed, Jun 23, 2021 at 07:41:39PM -0700, 13145886936@163.com wrote:
> From: gushengxian <gushengxian@yulong.com>
>
> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.
>
> Signed-off-by: gushengxian <gushengxian@yulong.com>
> ---
> arch/arm/plat-pxa/ssp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c
> index 563440315acd..96b8765e4f57 100644
> --- a/arch/arm/plat-pxa/ssp.c
> +++ b/arch/arm/plat-pxa/ssp.c
> @@ -147,7 +147,6 @@ static int pxa_ssp_probe(struct platform_device *pdev)
>
> ssp->irq = platform_get_irq(pdev, 0);
> if (ssp->irq < 0) {
> - dev_err(dev, "no IRQ resource defined\n");
> return -ENODEV;
> }
Please also remove the now unnecessary braces around the return block.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: pxa: ssp: remove unnecessary print function dev_err()
@ 2021-06-24 9:51 ` 13145886936
0 siblings, 0 replies; 6+ messages in thread
From: 13145886936 @ 2021-06-24 9:51 UTC (permalink / raw)
To: linux; +Cc: linux-arm-kernel, linux-kernel, gushengxian
From: gushengxian <gushengxian@yulong.com>
The print function dev_err() is redundant because
platform_get_irq() already prints an error.
Signed-off-by: gushengxian <gushengxian@yulong.com>
---
arch/arm/plat-pxa/ssp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c
index 563440315acd..9e77b3392c1e 100644
--- a/arch/arm/plat-pxa/ssp.c
+++ b/arch/arm/plat-pxa/ssp.c
@@ -146,10 +146,8 @@ static int pxa_ssp_probe(struct platform_device *pdev)
}
ssp->irq = platform_get_irq(pdev, 0);
- if (ssp->irq < 0) {
- dev_err(dev, "no IRQ resource defined\n");
+ if (ssp->irq < 0)
return -ENODEV;
- }
if (dev->of_node) {
const struct of_device_id *id =
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: pxa: ssp: remove unnecessary print function dev_err()
@ 2021-06-24 9:51 ` 13145886936
0 siblings, 0 replies; 6+ messages in thread
From: 13145886936 @ 2021-06-24 9:51 UTC (permalink / raw)
To: linux; +Cc: linux-arm-kernel, linux-kernel, gushengxian
From: gushengxian <gushengxian@yulong.com>
The print function dev_err() is redundant because
platform_get_irq() already prints an error.
Signed-off-by: gushengxian <gushengxian@yulong.com>
---
arch/arm/plat-pxa/ssp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c
index 563440315acd..9e77b3392c1e 100644
--- a/arch/arm/plat-pxa/ssp.c
+++ b/arch/arm/plat-pxa/ssp.c
@@ -146,10 +146,8 @@ static int pxa_ssp_probe(struct platform_device *pdev)
}
ssp->irq = platform_get_irq(pdev, 0);
- if (ssp->irq < 0) {
- dev_err(dev, "no IRQ resource defined\n");
+ if (ssp->irq < 0)
return -ENODEV;
- }
if (dev->of_node) {
const struct of_device_id *id =
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-24 9:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-24 2:41 [PATCH] ARM: pxa: ssp: remove unnecessary print function dev_err() 13145886936
2021-06-24 2:41 ` 13145886936
2021-06-24 9:24 ` Russell King (Oracle)
2021-06-24 9:24 ` Russell King (Oracle)
2021-06-24 9:51 13145886936
2021-06-24 9:51 ` 13145886936
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.