* [PATCH][next] iwlwifi: Fix error return on failed kmalloc
@ 2021-06-24 19:18 Colin King
0 siblings, 0 replies; only message in thread
From: Colin King @ 2021-06-24 19:18 UTC (permalink / raw)
To: Luca Coelho, David S . Miller, Jakub Kicinski, linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently the failing kmalloc sets package to the -ENOMEM error
return value however the error is returned by variable data. Fix this
by setting data to the error code instead.
Addresses-Coverity: ("Unused value")
Fixes: 9dad325f9d57 ("iwlwifi: support loading the reduced power table from UEFI")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/intel/iwlwifi/fw/uefi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/fw/uefi.c b/drivers/net/wireless/intel/iwlwifi/fw/uefi.c
index a7c79d814aa4..c2c8078278f7 100644
--- a/drivers/net/wireless/intel/iwlwifi/fw/uefi.c
+++ b/drivers/net/wireless/intel/iwlwifi/fw/uefi.c
@@ -229,7 +229,7 @@ void *iwl_uefi_get_reduced_power(struct iwl_trans *trans, size_t *len)
package = kmalloc(package_size, GFP_KERNEL);
if (!package) {
- package = ERR_PTR(-ENOMEM);
+ data = ERR_PTR(-ENOMEM);
goto out;
}
--
2.31.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-24 19:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-24 19:18 [PATCH][next] iwlwifi: Fix error return on failed kmalloc Colin King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.