From: kernel test robot <lkp@intel.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Abhinav Kumar <abhinavk@codeaurora.org>
Cc: kbuild-all@lists.01.org, Jonathan Marek <jonathan@marek.ca>,
Stephen Boyd <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
David Airlie <airlied@linux.ie>,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH 11/17] drm/msm/dpu: drop src_split and multirect check from dpu_crtc_atomic_check
Date: Fri, 25 Jun 2021 11:41:56 +0800 [thread overview]
Message-ID: <202106251122.SyK0cfWF-lkp@intel.com> (raw)
In-Reply-To: <20210624145733.2561992-12-dmitry.baryshkov@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 5457 bytes --]
Hi Dmitry,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20210624]
[also build test WARNING on v5.13-rc7]
[cannot apply to linus/master v5.13-rc7 v5.13-rc6 v5.13-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Dmitry-Baryshkov/drm-msm-dpu-switch-dpu_plane-to-be-virtual/20210624-225947
base: 2a8927f0efb6fb34b9d11dab3bd3f018e866d36d
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/3842e184f54916b9d22989d840a70bfb0bfebf10
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Dmitry-Baryshkov/drm-msm-dpu-switch-dpu_plane-to-be-virtual/20210624-225947
git checkout 3842e184f54916b9d22989d840a70bfb0bfebf10
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c: In function 'dpu_crtc_atomic_check':
>> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c:898:23: warning: variable 'mixer_width' set but not used [-Wunused-but-set-variable]
898 | int cnt = 0, rc = 0, mixer_width = 0, i;
| ^~~~~~~~~~~
vim +/mixer_width +898 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
884
885 static int dpu_crtc_atomic_check(struct drm_crtc *crtc,
886 struct drm_atomic_state *state)
887 {
888 struct drm_crtc_state *crtc_state = drm_atomic_get_new_crtc_state(state,
889 crtc);
890 struct dpu_crtc *dpu_crtc = to_dpu_crtc(crtc);
891 struct dpu_crtc_state *cstate = to_dpu_crtc_state(crtc_state);
892 struct plane_state *pstates;
893
894 const struct drm_plane_state *pstate;
895 struct drm_plane *plane;
896 struct drm_display_mode *mode;
897
> 898 int cnt = 0, rc = 0, mixer_width = 0, i;
899
900 struct drm_rect crtc_rect = { 0 };
901
902 pstates = kzalloc(sizeof(*pstates) * DPU_STAGE_MAX * 4, GFP_KERNEL);
903
904 if (!crtc_state->enable || !crtc_state->active) {
905 DRM_DEBUG_ATOMIC("crtc%d -> enable %d, active %d, skip atomic_check\n",
906 crtc->base.id, crtc_state->enable,
907 crtc_state->active);
908 memset(&cstate->new_perf, 0, sizeof(cstate->new_perf));
909 goto end;
910 }
911
912 mode = &crtc_state->adjusted_mode;
913 DRM_DEBUG_ATOMIC("%s: check\n", dpu_crtc->name);
914
915 /* force a full mode set if active state changed */
916 if (crtc_state->active_changed)
917 crtc_state->mode_changed = true;
918
919 if (cstate->num_mixers) {
920 mixer_width = mode->hdisplay / cstate->num_mixers;
921
922 _dpu_crtc_setup_lm_bounds(crtc, crtc_state);
923 }
924
925 crtc_rect.x2 = mode->hdisplay;
926 crtc_rect.y2 = mode->vdisplay;
927
928 /* get plane state for all drm planes associated with crtc state */
929 drm_atomic_crtc_state_for_each_plane_state(plane, pstate, crtc_state) {
930 struct drm_rect dst, clip = crtc_rect;
931
932 if (IS_ERR_OR_NULL(pstate)) {
933 rc = PTR_ERR(pstate);
934 DPU_ERROR("%s: failed to get plane%d state, %d\n",
935 dpu_crtc->name, plane->base.id, rc);
936 goto end;
937 }
938 if (cnt >= DPU_STAGE_MAX * 4)
939 continue;
940
941 pstates[cnt].dpu_pstate = to_dpu_plane_state(pstate);
942 pstates[cnt].drm_pstate = pstate;
943 pstates[cnt].stage = pstate->normalized_zpos;
944
945 dpu_plane_clear_multirect(pstate);
946
947 cnt++;
948
949 dst = drm_plane_state_dest(pstate);
950 if (!drm_rect_intersect(&clip, &dst)) {
951 DPU_ERROR("invalid vertical/horizontal destination\n");
952 DPU_ERROR("display: " DRM_RECT_FMT " plane: "
953 DRM_RECT_FMT "\n", DRM_RECT_ARG(&crtc_rect),
954 DRM_RECT_ARG(&dst));
955 rc = -E2BIG;
956 goto end;
957 }
958 }
959
960 for (i = 0; i < cnt; i++) {
961 int z_pos = pstates[i].stage;
962
963 /* verify z_pos setting before using it */
964 if (z_pos >= DPU_STAGE_MAX - DPU_STAGE_0) {
965 DPU_ERROR("> %d plane stages assigned\n",
966 DPU_STAGE_MAX - DPU_STAGE_0);
967 rc = -EINVAL;
968 goto end;
969 }
970
971 pstates[i].dpu_pstate->stage = z_pos + DPU_STAGE_0;
972 DRM_DEBUG_ATOMIC("%s: zpos %d\n", dpu_crtc->name, z_pos);
973 }
974
975 atomic_inc(&_dpu_crtc_get_kms(crtc)->bandwidth_ref);
976
977 rc = dpu_core_perf_crtc_check(crtc, crtc_state);
978 if (rc) {
979 DPU_ERROR("crtc%d failed performance check %d\n",
980 crtc->base.id, rc);
981 goto end;
982 }
983
984 end:
985 kfree(pstates);
986 return rc;
987 }
988
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 54160 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 11/17] drm/msm/dpu: drop src_split and multirect check from dpu_crtc_atomic_check
Date: Fri, 25 Jun 2021 11:41:56 +0800 [thread overview]
Message-ID: <202106251122.SyK0cfWF-lkp@intel.com> (raw)
In-Reply-To: <20210624145733.2561992-12-dmitry.baryshkov@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 5606 bytes --]
Hi Dmitry,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20210624]
[also build test WARNING on v5.13-rc7]
[cannot apply to linus/master v5.13-rc7 v5.13-rc6 v5.13-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Dmitry-Baryshkov/drm-msm-dpu-switch-dpu_plane-to-be-virtual/20210624-225947
base: 2a8927f0efb6fb34b9d11dab3bd3f018e866d36d
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/3842e184f54916b9d22989d840a70bfb0bfebf10
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Dmitry-Baryshkov/drm-msm-dpu-switch-dpu_plane-to-be-virtual/20210624-225947
git checkout 3842e184f54916b9d22989d840a70bfb0bfebf10
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c: In function 'dpu_crtc_atomic_check':
>> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c:898:23: warning: variable 'mixer_width' set but not used [-Wunused-but-set-variable]
898 | int cnt = 0, rc = 0, mixer_width = 0, i;
| ^~~~~~~~~~~
vim +/mixer_width +898 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
884
885 static int dpu_crtc_atomic_check(struct drm_crtc *crtc,
886 struct drm_atomic_state *state)
887 {
888 struct drm_crtc_state *crtc_state = drm_atomic_get_new_crtc_state(state,
889 crtc);
890 struct dpu_crtc *dpu_crtc = to_dpu_crtc(crtc);
891 struct dpu_crtc_state *cstate = to_dpu_crtc_state(crtc_state);
892 struct plane_state *pstates;
893
894 const struct drm_plane_state *pstate;
895 struct drm_plane *plane;
896 struct drm_display_mode *mode;
897
> 898 int cnt = 0, rc = 0, mixer_width = 0, i;
899
900 struct drm_rect crtc_rect = { 0 };
901
902 pstates = kzalloc(sizeof(*pstates) * DPU_STAGE_MAX * 4, GFP_KERNEL);
903
904 if (!crtc_state->enable || !crtc_state->active) {
905 DRM_DEBUG_ATOMIC("crtc%d -> enable %d, active %d, skip atomic_check\n",
906 crtc->base.id, crtc_state->enable,
907 crtc_state->active);
908 memset(&cstate->new_perf, 0, sizeof(cstate->new_perf));
909 goto end;
910 }
911
912 mode = &crtc_state->adjusted_mode;
913 DRM_DEBUG_ATOMIC("%s: check\n", dpu_crtc->name);
914
915 /* force a full mode set if active state changed */
916 if (crtc_state->active_changed)
917 crtc_state->mode_changed = true;
918
919 if (cstate->num_mixers) {
920 mixer_width = mode->hdisplay / cstate->num_mixers;
921
922 _dpu_crtc_setup_lm_bounds(crtc, crtc_state);
923 }
924
925 crtc_rect.x2 = mode->hdisplay;
926 crtc_rect.y2 = mode->vdisplay;
927
928 /* get plane state for all drm planes associated with crtc state */
929 drm_atomic_crtc_state_for_each_plane_state(plane, pstate, crtc_state) {
930 struct drm_rect dst, clip = crtc_rect;
931
932 if (IS_ERR_OR_NULL(pstate)) {
933 rc = PTR_ERR(pstate);
934 DPU_ERROR("%s: failed to get plane%d state, %d\n",
935 dpu_crtc->name, plane->base.id, rc);
936 goto end;
937 }
938 if (cnt >= DPU_STAGE_MAX * 4)
939 continue;
940
941 pstates[cnt].dpu_pstate = to_dpu_plane_state(pstate);
942 pstates[cnt].drm_pstate = pstate;
943 pstates[cnt].stage = pstate->normalized_zpos;
944
945 dpu_plane_clear_multirect(pstate);
946
947 cnt++;
948
949 dst = drm_plane_state_dest(pstate);
950 if (!drm_rect_intersect(&clip, &dst)) {
951 DPU_ERROR("invalid vertical/horizontal destination\n");
952 DPU_ERROR("display: " DRM_RECT_FMT " plane: "
953 DRM_RECT_FMT "\n", DRM_RECT_ARG(&crtc_rect),
954 DRM_RECT_ARG(&dst));
955 rc = -E2BIG;
956 goto end;
957 }
958 }
959
960 for (i = 0; i < cnt; i++) {
961 int z_pos = pstates[i].stage;
962
963 /* verify z_pos setting before using it */
964 if (z_pos >= DPU_STAGE_MAX - DPU_STAGE_0) {
965 DPU_ERROR("> %d plane stages assigned\n",
966 DPU_STAGE_MAX - DPU_STAGE_0);
967 rc = -EINVAL;
968 goto end;
969 }
970
971 pstates[i].dpu_pstate->stage = z_pos + DPU_STAGE_0;
972 DRM_DEBUG_ATOMIC("%s: zpos %d\n", dpu_crtc->name, z_pos);
973 }
974
975 atomic_inc(&_dpu_crtc_get_kms(crtc)->bandwidth_ref);
976
977 rc = dpu_core_perf_crtc_check(crtc, crtc_state);
978 if (rc) {
979 DPU_ERROR("crtc%d failed performance check %d\n",
980 crtc->base.id, rc);
981 goto end;
982 }
983
984 end:
985 kfree(pstates);
986 return rc;
987 }
988
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 54160 bytes --]
next prev parent reply other threads:[~2021-06-25 3:42 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 14:57 [PATCH 00/17] drm/msm/dpu: switch dpu_plane to be virtual Dmitry Baryshkov
2021-06-24 14:57 ` Dmitry Baryshkov
2021-06-24 14:57 ` [PATCH 01/17] drm/msm/dpu: move LUT levels out of QOS config Dmitry Baryshkov
2021-06-24 14:57 ` Dmitry Baryshkov
2021-06-24 14:57 ` [PATCH 02/17] drm/msm/dpu: remove pipe_qos_cfg from struct dpu_plane Dmitry Baryshkov
2021-06-24 14:57 ` Dmitry Baryshkov
2021-06-24 14:57 ` [PATCH 03/17] drm/msm/dpu: drop pipe_name " Dmitry Baryshkov
2021-06-24 14:57 ` Dmitry Baryshkov
2021-06-24 14:57 ` [PATCH 04/17] drm/msm/dpu: remove stage_cfg from struct dpu_crtc Dmitry Baryshkov
2021-06-24 14:57 ` Dmitry Baryshkov
2021-06-24 14:57 ` [PATCH 05/17] drm/msm/dpu: rip out master planes support Dmitry Baryshkov
2021-06-24 14:57 ` Dmitry Baryshkov
2021-06-24 14:57 ` [PATCH 06/17] drm/msm/dpu: move dpu_hw_pipe_cfg out of struct dpu_plane Dmitry Baryshkov
2021-06-24 14:57 ` Dmitry Baryshkov
2021-06-24 14:57 ` [PATCH 07/17] drm/msm/dpu: don't cache pipe->cap->features in dpu_plane Dmitry Baryshkov
2021-06-24 14:57 ` Dmitry Baryshkov
2021-06-24 14:57 ` [PATCH 08/17] drm/msm/dpu: don't cache pipe->cap->sblk " Dmitry Baryshkov
2021-06-24 14:57 ` Dmitry Baryshkov
2021-06-24 14:57 ` [PATCH 09/17] drm/msm/dpu: rip out debugfs support from dpu_plane Dmitry Baryshkov
2021-06-24 14:57 ` Dmitry Baryshkov
2021-06-24 14:57 ` [PATCH 10/17] drm/msm/dpu: simplify colorspace conversion setup Dmitry Baryshkov
2021-06-24 14:57 ` Dmitry Baryshkov
2021-06-24 14:57 ` [PATCH 11/17] drm/msm/dpu: drop src_split and multirect check from dpu_crtc_atomic_check Dmitry Baryshkov
2021-06-24 14:57 ` Dmitry Baryshkov
2021-06-25 3:41 ` kernel test robot [this message]
2021-06-25 3:41 ` kernel test robot
2021-06-24 14:57 ` [PATCH 12/17] drm/msm/dpu: add list of supported formats to the DPU caps Dmitry Baryshkov
2021-06-24 14:57 ` Dmitry Baryshkov
2021-06-24 14:57 ` [PATCH 13/17] drm/msm/dpu: simplify DPU_SSPP features checks Dmitry Baryshkov
2021-06-24 14:57 ` Dmitry Baryshkov
2021-06-24 14:57 ` [PATCH 14/17] drm/msm/dpu: do not limit the zpos property Dmitry Baryshkov
2021-06-24 14:57 ` Dmitry Baryshkov
2021-06-24 14:57 ` [PATCH 15/17] drm/msm/dpu: add support for SSPP allocation to RM Dmitry Baryshkov
2021-06-24 14:57 ` Dmitry Baryshkov
2021-06-24 14:57 ` [PATCH 16/17] drm/msm/dpu: add support for virtualized planes Dmitry Baryshkov
2021-06-24 14:57 ` Dmitry Baryshkov
2021-06-24 14:57 ` [PATCH 17/17] drm/msm/dpu: switch into using virtual planes Dmitry Baryshkov
2021-06-24 14:57 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202106251122.SyK0cfWF-lkp@intel.com \
--to=lkp@intel.com \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.