All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Yadav <p.yadav@ti.com>
To: Jagan Teki <jagan@amarulasolutions.com>,
	Vignesh R <vigneshr@ti.com>, Ryder Lee <ryder.lee@mediatek.com>,
	Weijie Gao <weijie.gao@mediatek.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	GSS_MTK_Uboot_upstream <GSS_MTK_Uboot_upstream@mediatek.com>,
	<u-boot@lists.denx.de>
Cc: Pratyush Yadav <p.yadav@ti.com>
Subject: [PATCH v10 15/27] mtd: spi-nor-core: prepare BFPT parsing for JESD216 rev D
Date: Sat, 26 Jun 2021 00:47:17 +0530	[thread overview]
Message-ID: <20210625191729.31798-16-p.yadav@ti.com> (raw)
In-Reply-To: <20210625191729.31798-1-p.yadav@ti.com>

JESD216 rev D makes BFPT 20 DWORDs. Update the BFPT size define to
reflect that.

The check for rev A or later compared the BFPT header length with the
maximum BFPT length, BFPT_DWORD_MAX. Since BFPT_DWORD_MAX was 16, and so
was the BFPT length for both rev A and B, this check worked fine. But
now, since BFPT_DWORD_MAX is 20, it means this check will also stop BFPT
parsing for rev A or B, since their length is 16.

So, instead check for BFPT_DWORD_MAX_JESD216 to stop BFPT parsing for
the first JESD216 version, and check for BFPT_DWORD_MAX_JESD216B for the
next two versions.

Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
---
 drivers/mtd/spi/spi-nor-core.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/spi/spi-nor-core.c b/drivers/mtd/spi/spi-nor-core.c
index c2eae885e4..5a65597616 100644
--- a/drivers/mtd/spi/spi-nor-core.c
+++ b/drivers/mtd/spi/spi-nor-core.c
@@ -79,14 +79,15 @@ struct sfdp_header {
 /* Basic Flash Parameter Table */
 
 /*
- * JESD216 rev B defines a Basic Flash Parameter Table of 16 DWORDs.
+ * JESD216 rev D defines a Basic Flash Parameter Table of 20 DWORDs.
  * They are indexed from 1 but C arrays are indexed from 0.
  */
 #define BFPT_DWORD(i)		((i) - 1)
-#define BFPT_DWORD_MAX		16
+#define BFPT_DWORD_MAX		20
 
 /* The first version of JESB216 defined only 9 DWORDs. */
 #define BFPT_DWORD_MAX_JESD216			9
+#define BFPT_DWORD_MAX_JESD216B			16
 
 /* 1st DWORD. */
 #define BFPT_DWORD1_FAST_READ_1_1_2		BIT(16)
@@ -1999,7 +2000,7 @@ static int spi_nor_parse_bfpt(struct spi_nor *nor,
 	}
 
 	/* Stop here if not JESD216 rev A or later. */
-	if (bfpt_header->length < BFPT_DWORD_MAX)
+	if (bfpt_header->length == BFPT_DWORD_MAX_JESD216)
 		return spi_nor_post_bfpt_fixups(nor, bfpt_header, &bfpt,
 						params);
 
@@ -2034,6 +2035,11 @@ static int spi_nor_parse_bfpt(struct spi_nor *nor,
 		return -EINVAL;
 	}
 
+	/* Stop here if JESD216 rev B. */
+	if (bfpt_header->length == BFPT_DWORD_MAX_JESD216B)
+		return spi_nor_post_bfpt_fixups(nor, bfpt_header, &bfpt,
+						params);
+
 	return spi_nor_post_bfpt_fixups(nor, bfpt_header, &bfpt, params);
 }
 
-- 
2.30.0


  parent reply	other threads:[~2021-06-25 19:20 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25 19:17 [PATCH v10 00/27] mtd: spi-nor-core: add xSPI Octal DTR support Pratyush Yadav
2021-06-25 19:17 ` [PATCH v10 01/27] spi: spi-mem: allow specifying whether an op is DTR or not Pratyush Yadav
2021-06-25 19:17 ` [PATCH v10 02/27] spi: spi-mem: allow specifying a command's extension Pratyush Yadav
2021-06-25 19:17 ` [PATCH v10 03/27] spi: spi-mem: export spi_mem_default_supports_op() Pratyush Yadav
2021-06-25 19:17 ` [PATCH v10 04/27] spi: spi-mem: add spi_mem_dtr_supports_op() Pratyush Yadav
2021-06-26  9:14   ` Jagan Teki
2021-06-27  8:35     ` Pratyush Yadav
2021-06-28  6:39       ` Jagan Teki
2021-06-28  9:17         ` Pratyush Yadav
2021-06-28  9:23           ` Jagan Teki
2021-06-25 19:17 ` [PATCH v10 05/27] spi: cadence-qspi: Do not calibrate when device tree sets read delay Pratyush Yadav
2021-06-25 19:17 ` [PATCH v10 06/27] spi: cadence-qspi: Add a small delay before indirect writes Pratyush Yadav
2021-06-25 19:17 ` [PATCH v10 07/27] spi: cadence-qspi: Add support for octal DTR flashes Pratyush Yadav
2021-06-25 19:17 ` [PATCH v10 08/27] mtd: spi-nor-core: Fix address width on flash chips > 16MB Pratyush Yadav
2021-06-25 19:17 ` [PATCH v10 09/27] mtd: spi-nor-core: Add a ->setup() hook Pratyush Yadav
2021-06-25 19:17 ` [PATCH v10 10/27] mtd: spi-nor-core: Move SFDP related declarations to top Pratyush Yadav
2021-06-25 19:17 ` [PATCH v10 11/27] mtd: spi-nor-core: Introduce flash-specific fixup hooks Pratyush Yadav
2021-06-25 19:17 ` [PATCH v10 12/27] mtd: spi-nor-core: Rework hwcaps selection Pratyush Yadav
2021-07-28 10:13   ` Bin Meng
2021-07-28 10:44     ` Pratyush Yadav
2021-07-28 15:56       ` Bin Meng
2021-06-25 19:17 ` [PATCH v10 13/27] mtd: spi-nor-core: Do not set data direction when there is no data Pratyush Yadav
2021-06-25 19:17 ` [PATCH v10 14/27] mtd: spi-nor-core: Add support for DTR protocol Pratyush Yadav
2021-06-25 19:17 ` Pratyush Yadav [this message]
2021-06-25 19:17 ` [PATCH v10 16/27] mtd: spi-nor-core: Get command opcode extension type from BFPT Pratyush Yadav
2021-06-25 19:17 ` [PATCH v10 17/27] mtd: spi-nor-core: Parse xSPI Profile 1.0 table Pratyush Yadav
2021-06-25 19:17 ` [PATCH v10 18/27] mtd: spi-nor-core: Prepare Read SR and FSR for Octal DTR mode Pratyush Yadav
2021-06-25 19:17 ` [PATCH v10 19/27] mtd: spi-nor-core: Enable octal DTR mode when possible Pratyush Yadav
2021-06-25 19:17 ` [PATCH v10 20/27] mtd: spi-nor-core: Do not make invalid quad enable fatal Pratyush Yadav
2021-06-25 19:17 ` [PATCH v10 21/27] mtd: spi-nor-core: Detect Soft Reset sequence support from BFPT Pratyush Yadav
2021-06-25 19:17 ` [PATCH v10 22/27] mtd: spi-nor-core: Perform a Soft Reset on shutdown Pratyush Yadav
2021-06-25 19:17 ` [PATCH v10 23/27] mtd: spi-nor-core: Perform a Soft Reset on boot Pratyush Yadav
2021-06-25 19:17 ` [PATCH v10 24/27] mtd: spi-nor-core: allow truncated erases Pratyush Yadav
2021-06-25 19:17 ` [PATCH v10 25/27] mtd: spi-nor-core: Add non-uniform erase for Spansion/Cypress Pratyush Yadav
2021-06-25 19:17 ` [PATCH v10 26/27] mtd: spi-nor-core: Add support for Cypress Semper flash Pratyush Yadav
2021-06-25 19:17 ` [PATCH v10 27/27] mtd: spi-nor-core: Allow using Micron mt35xu512aba in Octal DTR mode Pratyush Yadav
2021-06-28 15:52 ` [PATCH v10 00/27] mtd: spi-nor-core: add xSPI Octal DTR support Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210625191729.31798-16-p.yadav@ti.com \
    --to=p.yadav@ti.com \
    --cc=GSS_MTK_Uboot_upstream@mediatek.com \
    --cc=chunfeng.yun@mediatek.com \
    --cc=jagan@amarulasolutions.com \
    --cc=ryder.lee@mediatek.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    --cc=weijie.gao@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.