From: Raviteja Narayanam <raviteja.narayanam@xilinx.com> To: <linux-i2c@vger.kernel.org>, <michal.simek@xilinx.com> Cc: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <git@xilinx.com>, <marex@denx.de>, <joe@perches.com>, Raviteja Narayanam <raviteja.narayanam@xilinx.com> Subject: [PATCH v2 01/10] i2c: xiic: Fix Tx Interrupt path for grouped messages Date: Sat, 26 Jun 2021 15:57:57 +0530 [thread overview] Message-ID: <20210626102806.15402-2-raviteja.narayanam@xilinx.com> (raw) In-Reply-To: <20210626102806.15402-1-raviteja.narayanam@xilinx.com> When a group of messages are sent from user space as a set, if the last message has less than Tx FIFO DEPTH number of bytes to transfer, Tx half empty interrupt is triggered continuously from the hardware. It is due to Bus not busy interrupt coming along with Tx half empty and tx empty. Hence, service the Tx interrupts before Bus not busy interrupt to update the i2c message status correctly. Signed-off-by: Raviteja Narayanam <raviteja.narayanam@xilinx.com> --- drivers/i2c/busses/i2c-xiic.c | 34 ++++++++++++++++++---------------- 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 2a8568b97c14..b0cfd9d15467 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -453,22 +453,6 @@ static irqreturn_t xiic_process(int irq, void *dev_id) } } } - if (pend & XIIC_INTR_BNB_MASK) { - /* IIC bus has transitioned to not busy */ - clr |= XIIC_INTR_BNB_MASK; - - /* The bus is not busy, disable BusNotBusy interrupt */ - xiic_irq_dis(i2c, XIIC_INTR_BNB_MASK); - - if (!i2c->tx_msg) - goto out; - - if ((i2c->nmsgs == 1) && !i2c->rx_msg && - xiic_tx_space(i2c) == 0) - xiic_wakeup(i2c, STATE_DONE); - else - xiic_wakeup(i2c, STATE_ERROR); - } if (pend & (XIIC_INTR_TX_EMPTY_MASK | XIIC_INTR_TX_HALF_MASK)) { /* Transmit register/FIFO is empty or ½ empty */ @@ -505,6 +489,24 @@ static irqreturn_t xiic_process(int irq, void *dev_id) */ xiic_irq_dis(i2c, XIIC_INTR_TX_HALF_MASK); } + + if (pend & XIIC_INTR_BNB_MASK) { + /* IIC bus has transitioned to not busy */ + clr |= XIIC_INTR_BNB_MASK; + + /* The bus is not busy, disable BusNotBusy interrupt */ + xiic_irq_dis(i2c, XIIC_INTR_BNB_MASK); + + if (!i2c->tx_msg) + goto out; + + if (i2c->nmsgs == 1 && !i2c->rx_msg && + xiic_tx_space(i2c) == 0) + xiic_wakeup(i2c, STATE_DONE); + else + xiic_wakeup(i2c, STATE_ERROR); + } + out: dev_dbg(i2c->adap.dev.parent, "%s clr: 0x%x\n", __func__, clr); -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Raviteja Narayanam <raviteja.narayanam@xilinx.com> To: <linux-i2c@vger.kernel.org>, <michal.simek@xilinx.com> Cc: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <git@xilinx.com>, <marex@denx.de>, <joe@perches.com>, Raviteja Narayanam <raviteja.narayanam@xilinx.com> Subject: [PATCH v2 01/10] i2c: xiic: Fix Tx Interrupt path for grouped messages Date: Sat, 26 Jun 2021 15:57:57 +0530 [thread overview] Message-ID: <20210626102806.15402-2-raviteja.narayanam@xilinx.com> (raw) In-Reply-To: <20210626102806.15402-1-raviteja.narayanam@xilinx.com> When a group of messages are sent from user space as a set, if the last message has less than Tx FIFO DEPTH number of bytes to transfer, Tx half empty interrupt is triggered continuously from the hardware. It is due to Bus not busy interrupt coming along with Tx half empty and tx empty. Hence, service the Tx interrupts before Bus not busy interrupt to update the i2c message status correctly. Signed-off-by: Raviteja Narayanam <raviteja.narayanam@xilinx.com> --- drivers/i2c/busses/i2c-xiic.c | 34 ++++++++++++++++++---------------- 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 2a8568b97c14..b0cfd9d15467 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -453,22 +453,6 @@ static irqreturn_t xiic_process(int irq, void *dev_id) } } } - if (pend & XIIC_INTR_BNB_MASK) { - /* IIC bus has transitioned to not busy */ - clr |= XIIC_INTR_BNB_MASK; - - /* The bus is not busy, disable BusNotBusy interrupt */ - xiic_irq_dis(i2c, XIIC_INTR_BNB_MASK); - - if (!i2c->tx_msg) - goto out; - - if ((i2c->nmsgs == 1) && !i2c->rx_msg && - xiic_tx_space(i2c) == 0) - xiic_wakeup(i2c, STATE_DONE); - else - xiic_wakeup(i2c, STATE_ERROR); - } if (pend & (XIIC_INTR_TX_EMPTY_MASK | XIIC_INTR_TX_HALF_MASK)) { /* Transmit register/FIFO is empty or ½ empty */ @@ -505,6 +489,24 @@ static irqreturn_t xiic_process(int irq, void *dev_id) */ xiic_irq_dis(i2c, XIIC_INTR_TX_HALF_MASK); } + + if (pend & XIIC_INTR_BNB_MASK) { + /* IIC bus has transitioned to not busy */ + clr |= XIIC_INTR_BNB_MASK; + + /* The bus is not busy, disable BusNotBusy interrupt */ + xiic_irq_dis(i2c, XIIC_INTR_BNB_MASK); + + if (!i2c->tx_msg) + goto out; + + if (i2c->nmsgs == 1 && !i2c->rx_msg && + xiic_tx_space(i2c) == 0) + xiic_wakeup(i2c, STATE_DONE); + else + xiic_wakeup(i2c, STATE_ERROR); + } + out: dev_dbg(i2c->adap.dev.parent, "%s clr: 0x%x\n", __func__, clr); -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-26 10:28 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-26 10:27 [PATCH v2 00/10] i2c: xiic: Add features, bug fixes Raviteja Narayanam 2021-06-26 10:27 ` Raviteja Narayanam 2021-06-26 10:27 ` Raviteja Narayanam [this message] 2021-06-26 10:27 ` [PATCH v2 01/10] i2c: xiic: Fix Tx Interrupt path for grouped messages Raviteja Narayanam 2021-06-26 10:27 ` [PATCH v2 02/10] i2c: xiic: Add standard mode support for > 255 byte read transfers Raviteja Narayanam 2021-06-26 10:27 ` Raviteja Narayanam 2022-06-29 11:02 ` Krzysztof Adamski 2022-06-29 11:02 ` Krzysztof Adamski 2022-06-29 11:39 ` Michal Simek 2022-06-29 11:39 ` Michal Simek 2022-06-29 12:07 ` Krzysztof Adamski 2022-06-29 12:07 ` Krzysztof Adamski 2021-06-26 10:27 ` [PATCH v2 03/10] i2c: xiic: Switch to Xiic standard mode for i2c-read Raviteja Narayanam 2021-06-26 10:27 ` Raviteja Narayanam 2022-06-29 12:47 ` Krzysztof Adamski 2022-06-29 12:47 ` Krzysztof Adamski 2022-06-29 14:05 ` Marek Vasut 2022-06-29 14:05 ` Marek Vasut 2022-06-29 14:09 ` Krzysztof Adamski 2022-06-29 14:09 ` Krzysztof Adamski 2022-06-29 14:34 ` Marek Vasut 2022-06-29 14:34 ` Marek Vasut 2022-06-30 8:23 ` Datta, Shubhrajyoti 2022-06-30 8:23 ` Datta, Shubhrajyoti 2022-07-01 7:01 ` Krzysztof Adamski 2022-07-01 7:01 ` Krzysztof Adamski 2022-07-04 5:45 ` Datta, Shubhrajyoti 2022-07-04 5:45 ` Datta, Shubhrajyoti 2021-06-26 10:28 ` [PATCH v2 04/10] i2c: xiic: Remove interrupt enable/disable in Rx path Raviteja Narayanam 2021-06-26 10:28 ` Raviteja Narayanam 2021-06-26 10:28 ` [PATCH v2 05/10] dt-bindings: i2c: xiic: Add 'xlnx,axi-iic-2.1' to compatible Raviteja Narayanam 2021-06-26 10:28 ` [PATCH v2 05/10] dt-bindings: i2c: xiic: Add 'xlnx, axi-iic-2.1' " Raviteja Narayanam 2021-06-26 10:28 ` [PATCH v2 06/10] i2c: xiic: Update compatible with new IP version Raviteja Narayanam 2021-06-26 10:28 ` Raviteja Narayanam 2021-06-26 10:28 ` [PATCH v2 07/10] i2c: xiic: Return value of xiic_reinit Raviteja Narayanam 2021-06-26 10:28 ` Raviteja Narayanam 2021-06-26 10:28 ` [PATCH v2 08/10] i2c: xiic: Fix the type check for xiic_wakeup Raviteja Narayanam 2021-06-26 10:28 ` Raviteja Narayanam 2021-06-26 10:28 ` [PATCH v2 09/10] i2c: xiic: Fix coding style issues Raviteja Narayanam 2021-06-26 10:28 ` Raviteja Narayanam 2021-06-26 10:28 ` [PATCH v2 10/10] i2c: xiic: Add smbus_block_read functionality Raviteja Narayanam 2021-06-26 10:28 ` Raviteja Narayanam 2021-06-28 7:23 ` [PATCH v2 00/10] i2c: xiic: Add features, bug fixes Michal Simek 2021-06-28 7:23 ` Michal Simek 2021-07-16 16:01 ` Marek Vasut 2021-07-16 16:01 ` Marek Vasut 2021-07-19 10:09 ` Raviteja Narayanam 2021-07-19 10:09 ` Raviteja Narayanam 2021-07-19 18:00 ` Marek Vasut 2021-07-19 18:00 ` Marek Vasut 2021-07-20 14:19 ` Raviteja Narayanam 2021-07-20 14:19 ` Raviteja Narayanam 2021-07-20 21:43 ` Marek Vasut 2021-07-20 21:43 ` Marek Vasut 2021-07-26 5:26 ` Raviteja Narayanam 2021-07-26 5:26 ` Raviteja Narayanam 2021-07-26 13:12 ` Marek Vasut 2021-07-26 13:12 ` Marek Vasut 2021-07-28 10:11 ` Raviteja Narayanam 2021-07-28 10:11 ` Raviteja Narayanam 2021-07-28 18:47 ` Marek Vasut 2021-07-28 18:47 ` Marek Vasut 2022-06-28 7:50 ` Guntupalli, Manikanta 2022-06-28 7:50 ` Guntupalli, Manikanta
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210626102806.15402-2-raviteja.narayanam@xilinx.com \ --to=raviteja.narayanam@xilinx.com \ --cc=git@xilinx.com \ --cc=joe@perches.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marex@denx.de \ --cc=michal.simek@xilinx.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.