All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] support/tests: fix squashfs test
@ 2021-06-27  6:53 Yann E. MORIN
  2021-06-27  8:06 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Yann E. MORIN @ 2021-06-27  6:53 UTC (permalink / raw)
  To: buildroot

Commit 3cf2782906d5 (support/testing/infra/emulator.py: update pre-built
kernels) bumped the default kernels used by the testing infra.

However, the newer armv7 kernel (at least) no longer has support for
lz4-compressed squashfs filesystems.

This nreaks the squashfs test:

    Filesystem uses "lz4" compression. This is not supported
    List of all partitions:
    1f00          131072 mtdblock0
     (driver?)
    1f01           32768 mtdblock1
     (driver?)
    b300            2048 mmcblk0
     driver: mmcblk
    No filesystem could mount root, tried:
     squashfs

    Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(179,0)

Updating the kernel again is a little cumbersome, while fixing the
actual test is relatively trivial, so this is what we do: we switch
over to lzo, which is supported by the new kernel:

    # zcat /proc/config.gz |grep SQUA
    CONFIG_SQUASHFS=y
    CONFIG_SQUASHFS_ZLIB=y
    # CONFIG_SQUASHFS_LZ4 is not set
    CONFIG_SQUASHFS_LZO=y
    # CONFIG_SQUASHFS_XZ is not set

Fixes: 3cf2782906d5cc05a3966c25518d2ce01f11afc8

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 support/testing/tests/fs/test_squashfs.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/support/testing/tests/fs/test_squashfs.py b/support/testing/tests/fs/test_squashfs.py
index 745f93ee55..a914f5aac7 100644
--- a/support/testing/tests/fs/test_squashfs.py
+++ b/support/testing/tests/fs/test_squashfs.py
@@ -7,8 +7,7 @@ class TestSquashfs(infra.basetest.BRTest):
     config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
         """
         BR2_TARGET_ROOTFS_SQUASHFS=y
-        # BR2_TARGET_ROOTFS_SQUASHFS4_GZIP is not set
-        BR2_TARGET_ROOTFS_SQUASHFS4_LZ4=y
+        BR2_TARGET_ROOTFS_SQUASHFS4_LZO=y
         # BR2_TARGET_ROOTFS_TAR is not set
         """
 
@@ -18,7 +17,7 @@ class TestSquashfs(infra.basetest.BRTest):
         out = out.splitlines()
         self.assertEqual(out[0],
                          "Found a valid SQUASHFS 4:0 superblock on images/rootfs.squashfs.")
-        self.assertEqual(out[3], "Compression lz4")
+        self.assertEqual(out[3], "Compression lzo")
 
         img = os.path.join(self.builddir, "images", "rootfs.squashfs")
         infra.img_round_power2(img)
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] support/tests: fix squashfs test
  2021-06-27  6:53 [Buildroot] [PATCH] support/tests: fix squashfs test Yann E. MORIN
@ 2021-06-27  8:06 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2021-06-27  8:06 UTC (permalink / raw)
  To: buildroot

On Sun, 27 Jun 2021 08:53:50 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> Commit 3cf2782906d5 (support/testing/infra/emulator.py: update pre-built
> kernels) bumped the default kernels used by the testing infra.
> 
> However, the newer armv7 kernel (at least) no longer has support for
> lz4-compressed squashfs filesystems.
> 
> This nreaks the squashfs test:
> 
>     Filesystem uses "lz4" compression. This is not supported
>     List of all partitions:
>     1f00          131072 mtdblock0
>      (driver?)
>     1f01           32768 mtdblock1
>      (driver?)
>     b300            2048 mmcblk0
>      driver: mmcblk
>     No filesystem could mount root, tried:
>      squashfs
> 
>     Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(179,0)
> 
> Updating the kernel again is a little cumbersome, while fixing the
> actual test is relatively trivial, so this is what we do: we switch
> over to lzo, which is supported by the new kernel:
> 
>     # zcat /proc/config.gz |grep SQUA
>     CONFIG_SQUASHFS=y
>     CONFIG_SQUASHFS_ZLIB=y
>     # CONFIG_SQUASHFS_LZ4 is not set
>     CONFIG_SQUASHFS_LZO=y
>     # CONFIG_SQUASHFS_XZ is not set
> 
> Fixes: 3cf2782906d5cc05a3966c25518d2ce01f11afc8
> 
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Thanks a lot for fixing this!

Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-27  8:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-27  6:53 [Buildroot] [PATCH] support/tests: fix squashfs test Yann E. MORIN
2021-06-27  8:06 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.