Re: [PATCH 3/7] disk: Tidy up #ifdefs in part_efi

From: Tom Rini <trini@konsulko.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Michal Simek <monstr@monstr.eu>
Cc: "Simon Glass" <sjg@chromium.org>,
	"U-Boot Mailing List" <u-boot@lists.denx.de>,
	"Pali Rohár" <pali@kernel.org>,
	"Ilias Apalodimas" <ilias.apalodimas@linaro.org>
Subject: Re: [PATCH 3/7] disk: Tidy up #ifdefs in part_efi
Date: Mon, 28 Jun 2021 09:50:21 -0400	[thread overview]
Message-ID: <20210628135021.GB9516@bill-the-cat> (raw)
In-Reply-To: <76887540-0be8-e1ae-64ea-f222e0f6c55c@gmx.de>

[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]

On Mon, Jun 28, 2021 at 01:20:05PM +0200, Heinrich Schuchardt wrote:
> On 6/28/21 3:48 AM, Simon Glass wrote:
> > This file does not correctly handle the various cases, sometimes
> > producing warnings about partition_basic_data_guid being defined but not
> > used. Fix it.
> > 
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > ---
> > 
> >   disk/part_efi.c | 11 ++++++-----
> >   1 file changed, 6 insertions(+), 5 deletions(-)
> > 
> > diff --git a/disk/part_efi.c b/disk/part_efi.c
> > index 0fb7ff0b6bb..fdca91a6974 100644
> > --- a/disk/part_efi.c
> > +++ b/disk/part_efi.c
> > @@ -29,12 +29,13 @@
> > 
> >   DECLARE_GLOBAL_DATA_PTR;
> > 
> > -/*
> > - * GUID for basic data partions.
> > - */
> > +#ifdef CONFIG_HAVE_BLOCK_DEVICE
> 
> This #ifdef should be removed. Make CONFIG_HAVE_BLOCK_DEVICE a
> prerequisite for CONFIG_PARTITIONS instead.

Ah, this is where things get funny.  No, you can't do that as you can
use partitions without block devices.  I think it was some xilinx setup
that has this?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]