Re: [PATCH 3/7] disk: Tidy up #ifdefs in part_efi

From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: Tom Rini <trini@konsulko.com>, Michal Simek <monstr@monstr.eu>
Cc: "Simon Glass" <sjg@chromium.org>,
	"U-Boot Mailing List" <u-boot@lists.denx.de>,
	"Pali Rohár" <pali@kernel.org>,
	"Ilias Apalodimas" <ilias.apalodimas@linaro.org>
Subject: Re: [PATCH 3/7] disk: Tidy up #ifdefs in part_efi
Date: Mon, 28 Jun 2021 18:18:22 +0200	[thread overview]
Message-ID: <d6d98f99-7338-1ccf-3c22-76a10b791f43@gmx.de> (raw)
In-Reply-To: <20210628135021.GB9516@bill-the-cat>

On 28.06.21 15:50, Tom Rini wrote:
> On Mon, Jun 28, 2021 at 01:20:05PM +0200, Heinrich Schuchardt wrote:
>> On 6/28/21 3:48 AM, Simon Glass wrote:
>>> This file does not correctly handle the various cases, sometimes
>>> producing warnings about partition_basic_data_guid being defined but not
>>> used. Fix it.
>>>
>>> Signed-off-by: Simon Glass <sjg@chromium.org>
>>> ---
>>>
>>>   disk/part_efi.c | 11 ++++++-----
>>>   1 file changed, 6 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/disk/part_efi.c b/disk/part_efi.c
>>> index 0fb7ff0b6bb..fdca91a6974 100644
>>> --- a/disk/part_efi.c
>>> +++ b/disk/part_efi.c
>>> @@ -29,12 +29,13 @@
>>>
>>>   DECLARE_GLOBAL_DATA_PTR;
>>>
>>> -/*
>>> - * GUID for basic data partions.
>>> - */
>>> +#ifdef CONFIG_HAVE_BLOCK_DEVICE
>>
>> This #ifdef should be removed. Make CONFIG_HAVE_BLOCK_DEVICE a
>> prerequisite for CONFIG_PARTITIONS instead.
>
> Ah, this is where things get funny.  No, you can't do that as you can
> use partitions without block devices.  I think it was some xilinx setup
> that has this?
>

How can you have a partition without a block device? There must be some
backing storage for the partition.

Anyway this #ifdef should be in Kconfig or in Makefile and not here.

Best regards

Heinrich