From: mwilck@suse.com To: Mike Snitzer <snitzer@redhat.com>, Alasdair G Kergon <agk@redhat.com>, Bart Van Assche <Bart.VanAssche@sandisk.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, linux-scsi@vger.kernel.org, dm-devel@redhat.com, Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de> Cc: Daniel Wagner <dwagner@suse.de>, linux-block@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>, Benjamin Marzinski <bmarzins@redhat.com>, nkoenig@redhat.com, emilne@redhat.com, Martin Wilck <mwilck@suse.com> Subject: [PATCH v5 0/3] scsi/dm: dm_blk_ioctl(): implement failover for SG_IO on dm-multipath Date: Mon, 28 Jun 2021 17:15:55 +0200 [thread overview] Message-ID: <20210628151558.2289-1-mwilck@suse.com> (raw) From: Martin Wilck <mwilck@suse.com> Hello Mike, hello Martin, here is v5 of my attempt to add retry logic to SG_IO on dm-multipath devices. Christoph's comment on v4 has been received, but as I'm still confused how to handle the SCSI result / blk_status_t conversion properly, and waiting for more guidance, I want to fix the nasty bug in v4 first. Regards Martin Changes v4->v5: - (2/3) Fixed bug in logical / bitwise and expression Reported-by: kernel test robot <lkp@intel.com> Changes v3->v4 (thanks to Mike Snitzer): - Added an additional helper function sg_io_to_blk_status() to scsi_ioctl.c, in order to avoid open-coding handling of the SCSI result code in device-mapper. - Added a new method dm_sg_io_ioctl_fn() in struct target_type, define only by the multipath target. This allows moving the bulk of the new code to dm-mpath.c, and avoids the wrong limitation of the code to request-based multipath. Changes v2->v3: - un-inlined scsi_result_to_blk_status again, and move the helper __scsi_result_to_blk_status to block/scsi_ioctl.c instead (Bart v. Assche) - open-coded the status/msg/host/driver-byte -> result conversion where the standard SCSI helpers aren't usable (Bart v. Assche) Changes v1->v2: - applied modifications from Mike Snitzer - moved SG_IO dependent code to a separate file, no scsi includes in dm.c any more - made the new code depend on a configuration option - separated out scsi changes, made scsi_result_to_blk_status() inline to avoid dependency of dm_mod from scsi_mod (Paolo Bonzini) Martin Wilck (3): scsi: scsi_ioctl: export __scsi_result_to_blk_status() scsi: scsi_ioctl: add sg_io_to_blk_status() dm mpath: add CONFIG_DM_MULTIPATH_SG_IO - failover for SG_IO Martin Wilck (3): scsi: scsi_ioctl: export __scsi_result_to_blk_status() scsi: scsi_ioctl: add sg_io_to_blk_status() dm mpath: add CONFIG_DM_MULTIPATH_SG_IO - failover for SG_IO block/scsi_ioctl.c | 72 ++++++++++++++++++++++- drivers/md/Kconfig | 11 ++++ drivers/md/dm-core.h | 5 ++ drivers/md/dm-mpath.c | 105 ++++++++++++++++++++++++++++++++++ drivers/md/dm.c | 26 ++++++++- drivers/scsi/scsi_lib.c | 24 +------- include/linux/blkdev.h | 4 ++ include/linux/device-mapper.h | 8 ++- 8 files changed, 226 insertions(+), 29 deletions(-) -- 2.32.0
WARNING: multiple messages have this Message-ID (diff)
From: mwilck@suse.com To: Mike Snitzer <snitzer@redhat.com>, Alasdair G Kergon <agk@redhat.com>, Bart Van Assche <Bart.VanAssche@sandisk.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, linux-scsi@vger.kernel.org, dm-devel@redhat.com, Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de> Cc: Daniel Wagner <dwagner@suse.de>, emilne@redhat.com, linux-block@vger.kernel.org, nkoenig@redhat.com, Paolo Bonzini <pbonzini@redhat.com>, Martin Wilck <mwilck@suse.com> Subject: [dm-devel] [PATCH v5 0/3] scsi/dm: dm_blk_ioctl(): implement failover for SG_IO on dm-multipath Date: Mon, 28 Jun 2021 17:15:55 +0200 [thread overview] Message-ID: <20210628151558.2289-1-mwilck@suse.com> (raw) From: Martin Wilck <mwilck@suse.com> Hello Mike, hello Martin, here is v5 of my attempt to add retry logic to SG_IO on dm-multipath devices. Christoph's comment on v4 has been received, but as I'm still confused how to handle the SCSI result / blk_status_t conversion properly, and waiting for more guidance, I want to fix the nasty bug in v4 first. Regards Martin Changes v4->v5: - (2/3) Fixed bug in logical / bitwise and expression Reported-by: kernel test robot <lkp@intel.com> Changes v3->v4 (thanks to Mike Snitzer): - Added an additional helper function sg_io_to_blk_status() to scsi_ioctl.c, in order to avoid open-coding handling of the SCSI result code in device-mapper. - Added a new method dm_sg_io_ioctl_fn() in struct target_type, define only by the multipath target. This allows moving the bulk of the new code to dm-mpath.c, and avoids the wrong limitation of the code to request-based multipath. Changes v2->v3: - un-inlined scsi_result_to_blk_status again, and move the helper __scsi_result_to_blk_status to block/scsi_ioctl.c instead (Bart v. Assche) - open-coded the status/msg/host/driver-byte -> result conversion where the standard SCSI helpers aren't usable (Bart v. Assche) Changes v1->v2: - applied modifications from Mike Snitzer - moved SG_IO dependent code to a separate file, no scsi includes in dm.c any more - made the new code depend on a configuration option - separated out scsi changes, made scsi_result_to_blk_status() inline to avoid dependency of dm_mod from scsi_mod (Paolo Bonzini) Martin Wilck (3): scsi: scsi_ioctl: export __scsi_result_to_blk_status() scsi: scsi_ioctl: add sg_io_to_blk_status() dm mpath: add CONFIG_DM_MULTIPATH_SG_IO - failover for SG_IO Martin Wilck (3): scsi: scsi_ioctl: export __scsi_result_to_blk_status() scsi: scsi_ioctl: add sg_io_to_blk_status() dm mpath: add CONFIG_DM_MULTIPATH_SG_IO - failover for SG_IO block/scsi_ioctl.c | 72 ++++++++++++++++++++++- drivers/md/Kconfig | 11 ++++ drivers/md/dm-core.h | 5 ++ drivers/md/dm-mpath.c | 105 ++++++++++++++++++++++++++++++++++ drivers/md/dm.c | 26 ++++++++- drivers/scsi/scsi_lib.c | 24 +------- include/linux/blkdev.h | 4 ++ include/linux/device-mapper.h | 8 ++- 8 files changed, 226 insertions(+), 29 deletions(-) -- 2.32.0 -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
next reply other threads:[~2021-06-28 15:20 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-28 15:15 mwilck [this message] 2021-06-28 15:15 ` [dm-devel] [PATCH v5 0/3] scsi/dm: dm_blk_ioctl(): implement failover for SG_IO on dm-multipath mwilck 2021-06-28 15:15 ` [PATCH v5 1/3] scsi: scsi_ioctl: export __scsi_result_to_blk_status() mwilck 2021-06-28 15:15 ` [dm-devel] " mwilck 2021-06-28 15:15 ` [PATCH v5 2/3] scsi: scsi_ioctl: add sg_io_to_blk_status() mwilck 2021-06-28 15:15 ` [dm-devel] " mwilck 2021-06-28 15:15 ` [PATCH v5 3/3] dm mpath: add CONFIG_DM_MULTIPATH_SG_IO - failover for SG_IO mwilck 2021-06-28 15:15 ` [dm-devel] " mwilck 2021-07-01 7:56 ` Christoph Hellwig 2021-07-01 7:56 ` [dm-devel] " Christoph Hellwig 2021-07-01 10:35 ` Martin Wilck 2021-07-01 10:35 ` [dm-devel] " Martin Wilck 2021-07-01 11:34 ` Christoph Hellwig 2021-07-01 11:34 ` [dm-devel] " Christoph Hellwig 2021-07-02 14:21 ` Martin Wilck 2021-07-02 14:21 ` Martin Wilck 2021-07-05 13:02 ` Paolo Bonzini 2021-07-05 13:02 ` Paolo Bonzini 2021-07-05 13:11 ` Hannes Reinecke 2021-07-05 13:11 ` Hannes Reinecke 2021-07-05 13:48 ` Martin Wilck 2021-07-05 13:48 ` Martin Wilck 2021-07-06 10:13 ` Paolo Bonzini 2021-07-06 10:13 ` Paolo Bonzini 2021-07-01 11:06 ` Paolo Bonzini 2021-07-01 11:06 ` [dm-devel] " Paolo Bonzini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210628151558.2289-1-mwilck@suse.com \ --to=mwilck@suse.com \ --cc=Bart.VanAssche@sandisk.com \ --cc=agk@redhat.com \ --cc=bmarzins@redhat.com \ --cc=dm-devel@redhat.com \ --cc=dwagner@suse.de \ --cc=emilne@redhat.com \ --cc=hare@suse.de \ --cc=hch@lst.de \ --cc=linux-block@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=nkoenig@redhat.com \ --cc=pbonzini@redhat.com \ --cc=snitzer@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.