* [PATCH] pinctrl: qcom: spmi-gpio: Add pmc8180 & pmc8180c
@ 2021-06-29 0:38 Bjorn Andersson
2021-07-14 20:56 ` Rob Herring
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Bjorn Andersson @ 2021-06-29 0:38 UTC (permalink / raw)
To: Linus Walleij, Rob Herring
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel
The SC8180x platform comes with PMC8180 and PMC8180c, add support for
the GPIO controller in these PMICs.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 4 ++++
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 ++
2 files changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
index 161216daf463..412613c80e9e 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
@@ -30,6 +30,8 @@ PMIC's from Qualcomm.
"qcom,pm8350-gpio"
"qcom,pm8350b-gpio"
"qcom,pm8350c-gpio"
+ "qcom,pmc8180-gpio"
+ "qcom,pmc8180c-gpio"
"qcom,pmk8350-gpio"
"qcom,pm7325-gpio"
"qcom,pmr735a-gpio"
@@ -120,6 +122,8 @@ to specify in a pin configuration subnode:
gpio1-gpio10 for pm8350
gpio1-gpio8 for pm8350b
gpio1-gpio9 for pm8350c
+ gpio1-gpio10 for pmc8180
+ gpio1-gpio12 for pmc8180c
gpio1-gpio4 for pmk8350
gpio1-gpio10 for pm7325
gpio1-gpio4 for pmr735a
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index a89d24a040af..9251fb5153e7 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1123,10 +1123,12 @@ static const struct of_device_id pmic_gpio_of_match[] = {
{ .compatible = "qcom,pm660l-gpio", .data = (void *) 12 },
/* pm8150 has 10 GPIOs with holes on 2, 5, 7 and 8 */
{ .compatible = "qcom,pm8150-gpio", .data = (void *) 10 },
+ { .compatible = "qcom,pmc8180-gpio", .data = (void *) 10 },
/* pm8150b has 12 GPIOs with holes on 3, r and 7 */
{ .compatible = "qcom,pm8150b-gpio", .data = (void *) 12 },
/* pm8150l has 12 GPIOs with holes on 7 */
{ .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 },
+ { .compatible = "qcom,pmc8180c-gpio", .data = (void *) 12 },
{ .compatible = "qcom,pm8350-gpio", .data = (void *) 10 },
{ .compatible = "qcom,pm8350b-gpio", .data = (void *) 8 },
{ .compatible = "qcom,pm8350c-gpio", .data = (void *) 9 },
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: qcom: spmi-gpio: Add pmc8180 & pmc8180c
2021-06-29 0:38 [PATCH] pinctrl: qcom: spmi-gpio: Add pmc8180 & pmc8180c Bjorn Andersson
@ 2021-07-14 20:56 ` Rob Herring
2021-07-21 23:02 ` Bjorn Andersson
2021-08-10 12:38 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2021-07-14 20:56 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Rob Herring, linux-kernel, Linus Walleij, devicetree, linux-gpio,
linux-arm-msm
On Mon, 28 Jun 2021 17:38:51 -0700, Bjorn Andersson wrote:
> The SC8180x platform comes with PMC8180 and PMC8180c, add support for
> the GPIO controller in these PMICs.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 4 ++++
> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 ++
> 2 files changed, 6 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: qcom: spmi-gpio: Add pmc8180 & pmc8180c
2021-06-29 0:38 [PATCH] pinctrl: qcom: spmi-gpio: Add pmc8180 & pmc8180c Bjorn Andersson
2021-07-14 20:56 ` Rob Herring
@ 2021-07-21 23:02 ` Bjorn Andersson
2021-08-10 12:38 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2021-07-21 23:02 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel
On Mon 28 Jun 19:38 CDT 2021, Bjorn Andersson wrote:
> The SC8180x platform comes with PMC8180 and PMC8180c, add support for
> the GPIO controller in these PMICs.
>
Linus, would you be willing to pick this up? Got some dts patches that
uses these compatibles.
Regards,
Bjorn
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 4 ++++
> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 ++
> 2 files changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> index 161216daf463..412613c80e9e 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> @@ -30,6 +30,8 @@ PMIC's from Qualcomm.
> "qcom,pm8350-gpio"
> "qcom,pm8350b-gpio"
> "qcom,pm8350c-gpio"
> + "qcom,pmc8180-gpio"
> + "qcom,pmc8180c-gpio"
> "qcom,pmk8350-gpio"
> "qcom,pm7325-gpio"
> "qcom,pmr735a-gpio"
> @@ -120,6 +122,8 @@ to specify in a pin configuration subnode:
> gpio1-gpio10 for pm8350
> gpio1-gpio8 for pm8350b
> gpio1-gpio9 for pm8350c
> + gpio1-gpio10 for pmc8180
> + gpio1-gpio12 for pmc8180c
> gpio1-gpio4 for pmk8350
> gpio1-gpio10 for pm7325
> gpio1-gpio4 for pmr735a
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index a89d24a040af..9251fb5153e7 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -1123,10 +1123,12 @@ static const struct of_device_id pmic_gpio_of_match[] = {
> { .compatible = "qcom,pm660l-gpio", .data = (void *) 12 },
> /* pm8150 has 10 GPIOs with holes on 2, 5, 7 and 8 */
> { .compatible = "qcom,pm8150-gpio", .data = (void *) 10 },
> + { .compatible = "qcom,pmc8180-gpio", .data = (void *) 10 },
> /* pm8150b has 12 GPIOs with holes on 3, r and 7 */
> { .compatible = "qcom,pm8150b-gpio", .data = (void *) 12 },
> /* pm8150l has 12 GPIOs with holes on 7 */
> { .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 },
> + { .compatible = "qcom,pmc8180c-gpio", .data = (void *) 12 },
> { .compatible = "qcom,pm8350-gpio", .data = (void *) 10 },
> { .compatible = "qcom,pm8350b-gpio", .data = (void *) 8 },
> { .compatible = "qcom,pm8350c-gpio", .data = (void *) 9 },
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: qcom: spmi-gpio: Add pmc8180 & pmc8180c
2021-06-29 0:38 [PATCH] pinctrl: qcom: spmi-gpio: Add pmc8180 & pmc8180c Bjorn Andersson
2021-07-14 20:56 ` Rob Herring
2021-07-21 23:02 ` Bjorn Andersson
@ 2021-08-10 12:38 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2021-08-10 12:38 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Rob Herring, MSM, open list:GPIO SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel
On Tue, Jun 29, 2021 at 2:40 AM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
> The SC8180x platform comes with PMC8180 and PMC8180c, add support for
> the GPIO controller in these PMICs.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Patch applied, sorry for missing this. I blame stress.
I had to hand-edit in the DT changes, not even fuzzing worked
so check the result.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-10 12:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-29 0:38 [PATCH] pinctrl: qcom: spmi-gpio: Add pmc8180 & pmc8180c Bjorn Andersson
2021-07-14 20:56 ` Rob Herring
2021-07-21 23:02 ` Bjorn Andersson
2021-08-10 12:38 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.