All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fstests: fix g/019 cleanup
@ 2021-06-29  0:55 Dave Chinner
  2021-06-29 21:08 ` Darrick J. Wong
  0 siblings, 1 reply; 2+ messages in thread
From: Dave Chinner @ 2021-06-29  0:55 UTC (permalink / raw)
  To: fstests

From: Dave Chinner <dchinner@redhat.com>

This never worked properly and the failure was exposed by the recent
rework of the fstest setup infrastructure.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
 tests/generic/019 | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tests/generic/019 b/tests/generic/019
index 640c96ae..bd234815 100755
--- a/tests/generic/019
+++ b/tests/generic/019
@@ -53,7 +53,6 @@ stop_fail_scratch_dev()
 # Override the default cleanup function.
 _cleanup()
 {
-    poweron_scratch_dev
     disallow_fail_make_request
     rm -f $tmp.*
 }
@@ -156,5 +155,4 @@ _scratch_mount
 allow_fail_make_request
 _workout
 status=$?
-disallow_fail_make_request
 exit
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] fstests: fix g/019 cleanup
  2021-06-29  0:55 [PATCH] fstests: fix g/019 cleanup Dave Chinner
@ 2021-06-29 21:08 ` Darrick J. Wong
  0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2021-06-29 21:08 UTC (permalink / raw)
  To: Dave Chinner; +Cc: fstests

On Tue, Jun 29, 2021 at 10:55:00AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> This never worked properly and the failure was exposed by the recent
> rework of the fstest setup infrastructure.
> 
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

Looks fine, and I have further cleanups for this test :P
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  tests/generic/019 | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tests/generic/019 b/tests/generic/019
> index 640c96ae..bd234815 100755
> --- a/tests/generic/019
> +++ b/tests/generic/019
> @@ -53,7 +53,6 @@ stop_fail_scratch_dev()
>  # Override the default cleanup function.
>  _cleanup()
>  {
> -    poweron_scratch_dev
>      disallow_fail_make_request
>      rm -f $tmp.*
>  }
> @@ -156,5 +155,4 @@ _scratch_mount
>  allow_fail_make_request
>  _workout
>  status=$?
> -disallow_fail_make_request
>  exit
> -- 
> 2.31.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-29 21:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-29  0:55 [PATCH] fstests: fix g/019 cleanup Dave Chinner
2021-06-29 21:08 ` Darrick J. Wong

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.