Re: [PATCH] MIPS: Fix PKMAP with 32-bit MIPS huge page support

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 19257 bytes --]

Hi Wei,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.13 next-20210629]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Wei-Li/MIPS-Fix-PKMAP-with-32-bit-MIPS-huge-page-support/20210629-170206
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git c54b245d011855ea91c5beff07f1db74143ce614
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/f6ed2b280b35440dbd6ae2fefa787902791a6422
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Wei-Li/MIPS-Fix-PKMAP-with-32-bit-MIPS-huge-page-support/20210629-170206
        git checkout f6ed2b280b35440dbd6ae2fefa787902791a6422
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross O=build_dir ARCH=mips prepare

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from arch/mips/include/asm/pgtable-32.h:22,
                    from arch/mips/include/asm/pgtable.h:14,
                    from include/linux/pgtable.h:6,
                    from include/linux/mm.h:33,
                    from arch/mips/kernel/asm-offsets.c:15:
>> arch/mips/include/asm/highmem.h:39:33: warning: extra tokens at end of #ifdef directive
      39 | #ifdef CONFIG_PHYS_ADDR_T_64BIT || CONFIG_MIPS_HUGE_TLB_SUPPORT
         |                                 ^~
   arch/mips/kernel/asm-offsets.c:26:6: warning: no previous prototype for 'output_ptreg_defines' [-Wmissing-prototypes]
      26 | void output_ptreg_defines(void)
         |      ^~~~~~~~~~~~~~~~~~~~
   arch/mips/kernel/asm-offsets.c:78:6: warning: no previous prototype for 'output_task_defines' [-Wmissing-prototypes]
      78 | void output_task_defines(void)
         |      ^~~~~~~~~~~~~~~~~~~
   arch/mips/kernel/asm-offsets.c:92:6: warning: no previous prototype for 'output_thread_info_defines' [-Wmissing-prototypes]
      92 | void output_thread_info_defines(void)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/mips/kernel/asm-offsets.c:108:6: warning: no previous prototype for 'output_thread_defines' [-Wmissing-prototypes]
     108 | void output_thread_defines(void)
         |      ^~~~~~~~~~~~~~~~~~~~~
   arch/mips/kernel/asm-offsets.c:136:6: warning: no previous prototype for 'output_thread_fpu_defines' [-Wmissing-prototypes]
     136 | void output_thread_fpu_defines(void)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~
   arch/mips/kernel/asm-offsets.c:179:6: warning: no previous prototype for 'output_mm_defines' [-Wmissing-prototypes]
     179 | void output_mm_defines(void)
         |      ^~~~~~~~~~~~~~~~~
   arch/mips/kernel/asm-offsets.c:218:6: warning: no previous prototype for 'output_sc_defines' [-Wmissing-prototypes]
     218 | void output_sc_defines(void)
         |      ^~~~~~~~~~~~~~~~~
   arch/mips/kernel/asm-offsets.c:253:6: warning: no previous prototype for 'output_signal_defined' [-Wmissing-prototypes]
     253 | void output_signal_defined(void)
         |      ^~~~~~~~~~~~~~~~~~~~~
   arch/mips/kernel/asm-offsets.c:320:6: warning: no previous prototype for 'output_pbe_defines' [-Wmissing-prototypes]
     320 | void output_pbe_defines(void)
         |      ^~~~~~~~~~~~~~~~~~
   arch/mips/kernel/asm-offsets.c:332:6: warning: no previous prototype for 'output_pm_defines' [-Wmissing-prototypes]
     332 | void output_pm_defines(void)
         |      ^~~~~~~~~~~~~~~~~
   arch/mips/kernel/asm-offsets.c:346:6: warning: no previous prototype for 'output_kvm_defines' [-Wmissing-prototypes]
     346 | void output_kvm_defines(void)
         |      ^~~~~~~~~~~~~~~~~~
   arch/mips/kernel/asm-offsets.c:390:6: warning: no previous prototype for 'output_cps_defines' [-Wmissing-prototypes]
     390 | void output_cps_defines(void)
         |      ^~~~~~~~~~~~~~~~~~
--
   In file included from arch/mips/include/asm/pgtable-32.h:22,
                    from arch/mips/include/asm/pgtable.h:14,
                    from include/linux/pgtable.h:6,
                    from include/linux/mm.h:33,
                    from include/linux/pid_namespace.h:7,
                    from include/linux/ptrace.h:10,
                    from arch/mips/include/asm/fpu.h:11,
                    from arch/mips/kernel/branch.c:16:
>> arch/mips/include/asm/highmem.h:39:33: warning: extra tokens at end of #ifdef directive
      39 | #ifdef CONFIG_PHYS_ADDR_T_64BIT || CONFIG_MIPS_HUGE_TLB_SUPPORT
         |                                 ^~
--
   In file included from arch/mips/include/asm/pgtable-32.h:22,
                    from arch/mips/include/asm/pgtable.h:14,
                    from include/linux/pgtable.h:6,
                    from include/linux/mm.h:33,
                    from arch/mips/kernel/signal.c:15:
>> arch/mips/include/asm/highmem.h:39:33: warning: extra tokens at end of #ifdef directive
      39 | #ifdef CONFIG_PHYS_ADDR_T_64BIT || CONFIG_MIPS_HUGE_TLB_SUPPORT
         |                                 ^~
   arch/mips/kernel/signal.c:439:5: warning: no previous prototype for 'setup_sigcontext' [-Wmissing-prototypes]
     439 | int setup_sigcontext(struct pt_regs *regs, struct sigcontext __user *sc)
         |     ^~~~~~~~~~~~~~~~
   arch/mips/kernel/signal.c:516:5: warning: no previous prototype for 'restore_sigcontext' [-Wmissing-prototypes]
     516 | int restore_sigcontext(struct pt_regs *regs, struct sigcontext __user *sc)
         |     ^~~~~~~~~~~~~~~~~~
   arch/mips/kernel/signal.c:630:17: warning: no previous prototype for 'sys_sigreturn' [-Wmissing-prototypes]
     630 | asmlinkage void sys_sigreturn(void)
         |                 ^~~~~~~~~~~~~
   arch/mips/kernel/signal.c:667:17: warning: no previous prototype for 'sys_rt_sigreturn' [-Wmissing-prototypes]
     667 | asmlinkage void sys_rt_sigreturn(void)
         |                 ^~~~~~~~~~~~~~~~
   arch/mips/kernel/signal.c:895:17: warning: no previous prototype for 'do_notify_resume' [-Wmissing-prototypes]
     895 | asmlinkage void do_notify_resume(struct pt_regs *regs, void *unused,
         |                 ^~~~~~~~~~~~~~~~
--
   In file included from arch/mips/include/asm/pgtable-32.h:22,
                    from arch/mips/include/asm/pgtable.h:14,
                    from include/linux/pgtable.h:6,
                    from include/linux/mm.h:33,
                    from include/linux/pid_namespace.h:7,
                    from include/linux/ptrace.h:10,
                    from arch/mips/kernel/syscall.c:15:
>> arch/mips/include/asm/highmem.h:39:33: warning: extra tokens at end of #ifdef directive
      39 | #ifdef CONFIG_PHYS_ADDR_T_64BIT || CONFIG_MIPS_HUGE_TLB_SUPPORT
         |                                 ^~
   arch/mips/kernel/syscall.c:51:16: warning: no previous prototype for 'sysm_pipe' [-Wmissing-prototypes]
      51 | asmlinkage int sysm_pipe(void)
         |                ^~~~~~~~~
   arch/mips/kernel/syscall.c:248:17: warning: no previous prototype for 'bad_stack' [-Wmissing-prototypes]
     248 | asmlinkage void bad_stack(void)
         |                 ^~~~~~~~~
--
   In file included from arch/mips/include/asm/pgtable-32.h:22,
                    from arch/mips/include/asm/pgtable.h:14,
                    from include/linux/pgtable.h:6,
                    from include/linux/mm.h:33,
                    from include/linux/pid_namespace.h:7,
                    from include/linux/ptrace.h:10,
                    from include/linux/elfcore.h:11,
                    from include/linux/crash_core.h:6,
                    from include/linux/kexec.h:18,
                    from arch/mips/kernel/traps.c:20:
>> arch/mips/include/asm/highmem.h:39:33: warning: extra tokens at end of #ifdef directive
      39 | #ifdef CONFIG_PHYS_ADDR_T_64BIT || CONFIG_MIPS_HUGE_TLB_SUPPORT
         |                                 ^~
   arch/mips/kernel/traps.c:364:6: warning: no previous prototype for 'show_registers' [-Wmissing-prototypes]
     364 | void show_registers(struct pt_regs *regs)
         |      ^~~~~~~~~~~~~~
   arch/mips/kernel/traps.c:441:17: warning: no previous prototype for 'do_be' [-Wmissing-prototypes]
     441 | asmlinkage void do_be(struct pt_regs *regs)
         |                 ^~~~~
   arch/mips/kernel/traps.c:746:17: warning: no previous prototype for 'do_ov' [-Wmissing-prototypes]
     746 | asmlinkage void do_ov(struct pt_regs *regs)
         |                 ^~~~~
   arch/mips/kernel/traps.c:870:17: warning: no previous prototype for 'do_fpe' [-Wmissing-prototypes]
     870 | asmlinkage void do_fpe(struct pt_regs *regs, unsigned long fcr31)
         |                 ^~~~~~
   arch/mips/kernel/traps.c:1023:17: warning: no previous prototype for 'do_bp' [-Wmissing-prototypes]
    1023 | asmlinkage void do_bp(struct pt_regs *regs)
         |                 ^~~~~
   arch/mips/kernel/traps.c:1110:17: warning: no previous prototype for 'do_tr' [-Wmissing-prototypes]
    1110 | asmlinkage void do_tr(struct pt_regs *regs)
         |                 ^~~~~
   arch/mips/kernel/traps.c:1147:17: warning: no previous prototype for 'do_ri' [-Wmissing-prototypes]
    1147 | asmlinkage void do_ri(struct pt_regs *regs)
         |                 ^~~~~
   arch/mips/kernel/traps.c:1398:17: warning: no previous prototype for 'do_cpu' [-Wmissing-prototypes]
    1398 | asmlinkage void do_cpu(struct pt_regs *regs)
         |                 ^~~~~~
   arch/mips/kernel/traps.c:1503:17: warning: no previous prototype for 'do_msa_fpe' [-Wmissing-prototypes]
    1503 | asmlinkage void do_msa_fpe(struct pt_regs *regs, unsigned int msacsr)
         |                 ^~~~~~~~~~
   arch/mips/kernel/traps.c:1523:17: warning: no previous prototype for 'do_msa' [-Wmissing-prototypes]
    1523 | asmlinkage void do_msa(struct pt_regs *regs)
         |                 ^~~~~~
   arch/mips/kernel/traps.c:1544:17: warning: no previous prototype for 'do_mdmx' [-Wmissing-prototypes]
    1544 | asmlinkage void do_mdmx(struct pt_regs *regs)
         |                 ^~~~~~~
   arch/mips/kernel/traps.c:1556:17: warning: no previous prototype for 'do_watch' [-Wmissing-prototypes]
    1556 | asmlinkage void do_watch(struct pt_regs *regs)
         |                 ^~~~~~~~
   arch/mips/kernel/traps.c:1583:17: warning: no previous prototype for 'do_mcheck' [-Wmissing-prototypes]
    1583 | asmlinkage void do_mcheck(struct pt_regs *regs)
         |                 ^~~~~~~~~
   arch/mips/kernel/traps.c: In function 'do_mcheck':
   arch/mips/kernel/traps.c:1586:17: warning: variable 'prev_state' set but not used [-Wunused-but-set-variable]
    1586 |  enum ctx_state prev_state;
         |                 ^~~~~~~~~~
   arch/mips/kernel/traps.c: At top level:
   arch/mips/kernel/traps.c:1608:17: warning: no previous prototype for 'do_mt' [-Wmissing-prototypes]
    1608 | asmlinkage void do_mt(struct pt_regs *regs)
         |                 ^~~~~
   arch/mips/kernel/traps.c:1644:17: warning: no previous prototype for 'do_dsp' [-Wmissing-prototypes]
    1644 | asmlinkage void do_dsp(struct pt_regs *regs)
         |                 ^~~~~~
   arch/mips/kernel/traps.c:1652:17: warning: no previous prototype for 'do_reserved' [-Wmissing-prototypes]
    1652 | asmlinkage void do_reserved(struct pt_regs *regs)
         |                 ^~~~~~~~~~~
   arch/mips/kernel/traps.c:1828:17: warning: no previous prototype for 'cache_parity_error' [-Wmissing-prototypes]
    1828 | asmlinkage void cache_parity_error(void)
         |                 ^~~~~~~~~~~~~~~~~~
   arch/mips/kernel/traps.c:1876:17: warning: no previous prototype for 'do_ftlb' [-Wmissing-prototypes]
    1876 | asmlinkage void do_ftlb(void)
         |                 ^~~~~~~
   arch/mips/kernel/traps.c:1905:17: warning: no previous prototype for 'do_gsexc' [-Wmissing-prototypes]
    1905 | asmlinkage void do_gsexc(struct pt_regs *regs, u32 diag1)
         |                 ^~~~~~~~
   arch/mips/kernel/traps.c:1940:6: warning: no previous prototype for 'ejtag_exception_handler' [-Wmissing-prototypes]
    1940 | void ejtag_exception_handler(struct pt_regs *regs)
         |      ^~~~~~~~~~~~~~~~~~~~~~~
   arch/mips/kernel/traps.c:1985:17: warning: no previous prototype for 'nmi_exception_handler' [-Wmissing-prototypes]
    1985 | void __noreturn nmi_exception_handler(struct pt_regs *regs)
         |                 ^~~~~~~~~~~~~~~~~~~~~
--
   In file included from arch/mips/include/asm/pgtable-32.h:22,
                    from arch/mips/include/asm/pgtable.h:14,
                    from include/linux/pgtable.h:6,
                    from include/linux/mm.h:33,
                    from arch/mips/kernel/unaligned.c:77:
>> arch/mips/include/asm/highmem.h:39:33: warning: extra tokens at end of #ifdef directive
      39 | #ifdef CONFIG_PHYS_ADDR_T_64BIT || CONFIG_MIPS_HUGE_TLB_SUPPORT
         |                                 ^~
   arch/mips/kernel/unaligned.c:1475:17: warning: no previous prototype for 'do_ade' [-Wmissing-prototypes]
    1475 | asmlinkage void do_ade(struct pt_regs *regs)
         |                 ^~~~~~
--
   In file included from arch/mips/include/asm/pgtable-32.h:22,
                    from arch/mips/include/asm/pgtable.h:14,
                    from include/linux/pgtable.h:6,
                    from include/linux/mm.h:33,
                    from include/linux/kallsyms.h:12,
                    from include/linux/ftrace.h:12,
                    from arch/mips/kernel/ftrace.c:14:
>> arch/mips/include/asm/highmem.h:39:33: warning: extra tokens at end of #ifdef directive
      39 | #ifdef CONFIG_PHYS_ADDR_T_64BIT || CONFIG_MIPS_HUGE_TLB_SUPPORT
         |                                 ^~
   arch/mips/kernel/ftrace.c:305:6: warning: no previous prototype for 'prepare_ftrace_return' [-Wmissing-prototypes]
     305 | void prepare_ftrace_return(unsigned long *parent_ra_addr, unsigned long self_ra,
         |      ^~~~~~~~~~~~~~~~~~~~~
--
   In file included from arch/mips/include/asm/pgtable-32.h:22,
                    from arch/mips/include/asm/pgtable.h:14,
                    from include/linux/pgtable.h:6,
                    from include/linux/mm.h:33,
                    from include/linux/kallsyms.h:12,
                    from include/linux/ftrace.h:12,
                    from arch/mips/kernel/smp.c:23:
>> arch/mips/include/asm/highmem.h:39:33: warning: extra tokens at end of #ifdef directive
      39 | #ifdef CONFIG_PHYS_ADDR_T_64BIT || CONFIG_MIPS_HUGE_TLB_SUPPORT
         |                                 ^~
   arch/mips/kernel/smp.c:334:17: warning: no previous prototype for 'start_secondary' [-Wmissing-prototypes]
     334 | asmlinkage void start_secondary(void)
         |                 ^~~~~~~~~~~~~~~
   arch/mips/kernel/smp.c:454:5: warning: no previous prototype for 'setup_profiling_timer' [-Wmissing-prototypes]
     454 | int setup_profiling_timer(unsigned int multiplier)
         |     ^~~~~~~~~~~~~~~~~~~~~
--
   In file included from arch/mips/include/asm/pgtable-32.h:22,
                    from arch/mips/include/asm/pgtable.h:14,
                    from include/linux/pgtable.h:6,
                    from include/linux/mm.h:33,
                    from include/linux/security.h:33,
                    from arch/mips/kernel/mips-mt.c:12:
>> arch/mips/include/asm/highmem.h:39:33: warning: extra tokens at end of #ifdef directive
      39 | #ifdef CONFIG_PHYS_ADDR_T_64BIT || CONFIG_MIPS_HUGE_TLB_SUPPORT
         |                                 ^~
   arch/mips/kernel/mips-mt.c:50:6: warning: no previous prototype for 'mips_mt_regdump' [-Wmissing-prototypes]
      50 | void mips_mt_regdump(unsigned long mvpctl)
         |      ^~~~~~~~~~~~~~~
   arch/mips/kernel/mips-mt.c:159:6: warning: no previous prototype for 'mips_mt_set_cpuoptions' [-Wmissing-prototypes]
     159 | void mips_mt_set_cpuoptions(void)
         |      ^~~~~~~~~~~~~~~~~~~~~~
--
   In file included from arch/mips/include/asm/pgtable-32.h:22,
                    from arch/mips/include/asm/pgtable.h:14,
                    from include/linux/pgtable.h:6,
                    from include/linux/mm.h:33,
                    from include/linux/cpuset.h:17,
                    from arch/mips/kernel/mips-mt-fpaff.c:7:
>> arch/mips/include/asm/highmem.h:39:33: warning: extra tokens at end of #ifdef directive
      39 | #ifdef CONFIG_PHYS_ADDR_T_64BIT || CONFIG_MIPS_HUGE_TLB_SUPPORT
         |                                 ^~
   arch/mips/kernel/mips-mt-fpaff.c:65:17: warning: no previous prototype for 'mipsmt_sys_sched_setaffinity' [-Wmissing-prototypes]
      65 | asmlinkage long mipsmt_sys_sched_setaffinity(pid_t pid, unsigned int len,
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/mips/kernel/mips-mt-fpaff.c:157:17: warning: no previous prototype for 'mipsmt_sys_sched_getaffinity' [-Wmissing-prototypes]
     157 | asmlinkage long mipsmt_sys_sched_getaffinity(pid_t pid, unsigned int len,
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
   In file included from arch/mips/include/asm/pgtable-32.h:22,
                    from arch/mips/include/asm/pgtable.h:14,
                    from include/linux/pgtable.h:6,
                    from include/linux/mm.h:33,
                    from include/linux/pid_namespace.h:7,
                    from include/linux/ptrace.h:10,
                    from include/linux/elfcore.h:11,
                    from include/linux/crash_core.h:6,
                    from include/linux/kexec.h:18,
                    from arch/mips/kernel/machine_kexec.c:7:
>> arch/mips/include/asm/highmem.h:39:33: warning: extra tokens at end of #ifdef directive
      39 | #ifdef CONFIG_PHYS_ADDR_T_64BIT || CONFIG_MIPS_HUGE_TLB_SUPPORT
         |                                 ^~
   arch/mips/kernel/machine_kexec.c:136:1: warning: no previous prototype for 'machine_shutdown' [-Wmissing-prototypes]
     136 | machine_shutdown(void)
         | ^~~~~~~~~~~~~~~~
   arch/mips/kernel/machine_kexec.c:152:1: warning: no previous prototype for 'machine_crash_shutdown' [-Wmissing-prototypes]
     152 | machine_crash_shutdown(struct pt_regs *regs)
         | ^~~~~~~~~~~~~~~~~~~~~~
..


vim +39 arch/mips/include/asm/highmem.h

    33	
    34	/*
    35	 * Right now we initialize only a single pte table. It can be extended
    36	 * easily, subsequent pte tables have to be allocated in one physical
    37	 * chunk of RAM.
    38	 */
  > 39	#ifdef CONFIG_PHYS_ADDR_T_64BIT || CONFIG_MIPS_HUGE_TLB_SUPPORT
    40	#define LAST_PKMAP 512
    41	#else
    42	#define LAST_PKMAP 1024
    43	#endif
    44	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 70751 bytes --]