* [PATCH] ACPI / video: Add quirk for the Dell Vostro 3350
@ 2021-06-30 15:23 Hans de Goede
2021-06-30 18:04 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2021-06-30 15:23 UTC (permalink / raw)
To: Rafael J . Wysocki, Len Brown, Zhang Rui; +Cc: Hans de Goede, linux-acpi
The Dell Vostro 3350 ACPI video-bus device reports spurious
ACPI_VIDEO_NOTIFY_CYCLE events resulting in spurious KEY_SWITCHVIDEOMODE
events being reported to userspace (and causing trouble there).
Add a quirk setting the report_key_events mask to
REPORT_BRIGHTNESS_KEY_EVENTS so that the ACPI_VIDEO_NOTIFY_CYCLE
events will be ignored, while still reporting brightness up/down
hotkey-presses to userspace normally.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1911763
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/acpi/acpi_video.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
index 0c884020f74b..08a51dd285c4 100644
--- a/drivers/acpi/acpi_video.c
+++ b/drivers/acpi/acpi_video.c
@@ -540,6 +540,15 @@ static const struct dmi_system_id video_dmi_table[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "Vostro V131"),
},
},
+ {
+ .callback = video_set_report_key_events,
+ .driver_data = (void *)((uintptr_t)REPORT_BRIGHTNESS_KEY_EVENTS),
+ .ident = "Dell Vostro 3350",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 3350"),
+ },
+ },
/*
* Some machines change the brightness themselves when a brightness
* hotkey gets pressed, despite us telling them not to. In this case
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ACPI / video: Add quirk for the Dell Vostro 3350
2021-06-30 15:23 [PATCH] ACPI / video: Add quirk for the Dell Vostro 3350 Hans de Goede
@ 2021-06-30 18:04 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2021-06-30 18:04 UTC (permalink / raw)
To: Hans de Goede
Cc: Rafael J . Wysocki, Len Brown, Zhang Rui, ACPI Devel Maling List
On Wed, Jun 30, 2021 at 5:23 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> The Dell Vostro 3350 ACPI video-bus device reports spurious
> ACPI_VIDEO_NOTIFY_CYCLE events resulting in spurious KEY_SWITCHVIDEOMODE
> events being reported to userspace (and causing trouble there).
>
> Add a quirk setting the report_key_events mask to
> REPORT_BRIGHTNESS_KEY_EVENTS so that the ACPI_VIDEO_NOTIFY_CYCLE
> events will be ignored, while still reporting brightness up/down
> hotkey-presses to userspace normally.
>
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1911763
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/acpi/acpi_video.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
> index 0c884020f74b..08a51dd285c4 100644
> --- a/drivers/acpi/acpi_video.c
> +++ b/drivers/acpi/acpi_video.c
> @@ -540,6 +540,15 @@ static const struct dmi_system_id video_dmi_table[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "Vostro V131"),
> },
> },
> + {
> + .callback = video_set_report_key_events,
> + .driver_data = (void *)((uintptr_t)REPORT_BRIGHTNESS_KEY_EVENTS),
> + .ident = "Dell Vostro 3350",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 3350"),
> + },
> + },
> /*
> * Some machines change the brightness themselves when a brightness
> * hotkey gets pressed, despite us telling them not to. In this case
> --
Applied as 5.14-rc1 material, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-30 18:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-30 15:23 [PATCH] ACPI / video: Add quirk for the Dell Vostro 3350 Hans de Goede
2021-06-30 18:04 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.