* [PATCH] PM: sleep: use ktime_us_delta in initcall_debug_report()
@ 2021-07-01 0:45 ` Mark-PK Tsai
0 siblings, 0 replies; 6+ messages in thread
From: Mark-PK Tsai @ 2021-07-01 0:45 UTC (permalink / raw)
To: gregkh
Cc: matthias.bgg, rjw, pavel, len.brown, linux-pm, linux-kernel,
linux-arm-kernel, linux-mediatek, mark-pk.tsai, yj.chiang
usecs is no more used after trace_device_pm_report_time replaced
by device_pm_callback_start/end in the below change.
commit e8bca479c3f2 ("PM / sleep: trace events for device PM callbacks")
Use ktime_us_delta to make the debug log more precise instead of
nsecs >> 10.
Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
---
drivers/base/power/main.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
index f893c3c5af07..d568772152c2 100644
--- a/drivers/base/power/main.c
+++ b/drivers/base/power/main.c
@@ -220,16 +220,13 @@ static void initcall_debug_report(struct device *dev, ktime_t calltime,
void *cb, int error)
{
ktime_t rettime;
- s64 nsecs;
if (!pm_print_times_enabled)
return;
rettime = ktime_get();
- nsecs = (s64) ktime_to_ns(ktime_sub(rettime, calltime));
-
dev_info(dev, "%pS returned %d after %Ld usecs\n", cb, error,
- (unsigned long long)nsecs >> 10);
+ (unsigned long long)ktime_us_delta(rettime, calltime));
}
/**
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] PM: sleep: use ktime_us_delta in initcall_debug_report()
@ 2021-07-01 0:45 ` Mark-PK Tsai
0 siblings, 0 replies; 6+ messages in thread
From: Mark-PK Tsai @ 2021-07-01 0:45 UTC (permalink / raw)
To: gregkh
Cc: matthias.bgg, rjw, pavel, len.brown, linux-pm, linux-kernel,
linux-arm-kernel, linux-mediatek, mark-pk.tsai, yj.chiang
usecs is no more used after trace_device_pm_report_time replaced
by device_pm_callback_start/end in the below change.
commit e8bca479c3f2 ("PM / sleep: trace events for device PM callbacks")
Use ktime_us_delta to make the debug log more precise instead of
nsecs >> 10.
Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
---
drivers/base/power/main.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
index f893c3c5af07..d568772152c2 100644
--- a/drivers/base/power/main.c
+++ b/drivers/base/power/main.c
@@ -220,16 +220,13 @@ static void initcall_debug_report(struct device *dev, ktime_t calltime,
void *cb, int error)
{
ktime_t rettime;
- s64 nsecs;
if (!pm_print_times_enabled)
return;
rettime = ktime_get();
- nsecs = (s64) ktime_to_ns(ktime_sub(rettime, calltime));
-
dev_info(dev, "%pS returned %d after %Ld usecs\n", cb, error,
- (unsigned long long)nsecs >> 10);
+ (unsigned long long)ktime_us_delta(rettime, calltime));
}
/**
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] PM: sleep: use ktime_us_delta in initcall_debug_report()
2021-07-01 0:45 ` Mark-PK Tsai
(?)
@ 2021-07-01 16:45 ` Rafael J. Wysocki
-1 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2021-07-01 16:45 UTC (permalink / raw)
To: Mark-PK Tsai
Cc: Greg Kroah-Hartman, Matthias Brugger, Rafael J. Wysocki,
Pavel Machek, Len Brown, Linux PM, Linux Kernel Mailing List,
Linux ARM, moderated list:ARM/Mediatek SoC...,
yj.chiang
On Thu, Jul 1, 2021 at 2:45 AM Mark-PK Tsai <mark-pk.tsai@mediatek.com> wrote:
>
> usecs is no more used after trace_device_pm_report_time replaced
> by device_pm_callback_start/end in the below change.
>
> commit e8bca479c3f2 ("PM / sleep: trace events for device PM callbacks")
>
> Use ktime_us_delta to make the debug log more precise instead of
> nsecs >> 10.
>
> Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> ---
> drivers/base/power/main.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
> index f893c3c5af07..d568772152c2 100644
> --- a/drivers/base/power/main.c
> +++ b/drivers/base/power/main.c
> @@ -220,16 +220,13 @@ static void initcall_debug_report(struct device *dev, ktime_t calltime,
> void *cb, int error)
> {
> ktime_t rettime;
> - s64 nsecs;
>
> if (!pm_print_times_enabled)
> return;
>
> rettime = ktime_get();
> - nsecs = (s64) ktime_to_ns(ktime_sub(rettime, calltime));
> -
> dev_info(dev, "%pS returned %d after %Ld usecs\n", cb, error,
> - (unsigned long long)nsecs >> 10);
> + (unsigned long long)ktime_us_delta(rettime, calltime));
> }
>
> /**
> --
Applied as 5.14-rc1 material with some edits in the subject and
changelog, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] PM: sleep: use ktime_us_delta in initcall_debug_report()
@ 2021-07-01 16:45 ` Rafael J. Wysocki
0 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2021-07-01 16:45 UTC (permalink / raw)
To: Mark-PK Tsai
Cc: Greg Kroah-Hartman, Matthias Brugger, Rafael J. Wysocki,
Pavel Machek, Len Brown, Linux PM, Linux Kernel Mailing List,
Linux ARM, moderated list:ARM/Mediatek SoC...,
yj.chiang
On Thu, Jul 1, 2021 at 2:45 AM Mark-PK Tsai <mark-pk.tsai@mediatek.com> wrote:
>
> usecs is no more used after trace_device_pm_report_time replaced
> by device_pm_callback_start/end in the below change.
>
> commit e8bca479c3f2 ("PM / sleep: trace events for device PM callbacks")
>
> Use ktime_us_delta to make the debug log more precise instead of
> nsecs >> 10.
>
> Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> ---
> drivers/base/power/main.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
> index f893c3c5af07..d568772152c2 100644
> --- a/drivers/base/power/main.c
> +++ b/drivers/base/power/main.c
> @@ -220,16 +220,13 @@ static void initcall_debug_report(struct device *dev, ktime_t calltime,
> void *cb, int error)
> {
> ktime_t rettime;
> - s64 nsecs;
>
> if (!pm_print_times_enabled)
> return;
>
> rettime = ktime_get();
> - nsecs = (s64) ktime_to_ns(ktime_sub(rettime, calltime));
> -
> dev_info(dev, "%pS returned %d after %Ld usecs\n", cb, error,
> - (unsigned long long)nsecs >> 10);
> + (unsigned long long)ktime_us_delta(rettime, calltime));
> }
>
> /**
> --
Applied as 5.14-rc1 material with some edits in the subject and
changelog, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] PM: sleep: use ktime_us_delta in initcall_debug_report()
@ 2021-07-01 16:45 ` Rafael J. Wysocki
0 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2021-07-01 16:45 UTC (permalink / raw)
To: Mark-PK Tsai
Cc: Greg Kroah-Hartman, Matthias Brugger, Rafael J. Wysocki,
Pavel Machek, Len Brown, Linux PM, Linux Kernel Mailing List,
Linux ARM, moderated list:ARM/Mediatek SoC...,
yj.chiang
On Thu, Jul 1, 2021 at 2:45 AM Mark-PK Tsai <mark-pk.tsai@mediatek.com> wrote:
>
> usecs is no more used after trace_device_pm_report_time replaced
> by device_pm_callback_start/end in the below change.
>
> commit e8bca479c3f2 ("PM / sleep: trace events for device PM callbacks")
>
> Use ktime_us_delta to make the debug log more precise instead of
> nsecs >> 10.
>
> Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> ---
> drivers/base/power/main.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
> index f893c3c5af07..d568772152c2 100644
> --- a/drivers/base/power/main.c
> +++ b/drivers/base/power/main.c
> @@ -220,16 +220,13 @@ static void initcall_debug_report(struct device *dev, ktime_t calltime,
> void *cb, int error)
> {
> ktime_t rettime;
> - s64 nsecs;
>
> if (!pm_print_times_enabled)
> return;
>
> rettime = ktime_get();
> - nsecs = (s64) ktime_to_ns(ktime_sub(rettime, calltime));
> -
> dev_info(dev, "%pS returned %d after %Ld usecs\n", cb, error,
> - (unsigned long long)nsecs >> 10);
> + (unsigned long long)ktime_us_delta(rettime, calltime));
> }
>
> /**
> --
Applied as 5.14-rc1 material with some edits in the subject and
changelog, thanks!
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 6+ messages in thread