* [PATCH v2 1/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 450 G8
@ 2021-07-01 9:14 ` Andy Chi
0 siblings, 0 replies; 8+ messages in thread
From: Andy Chi @ 2021-07-01 9:14 UTC (permalink / raw)
Cc: Chris Chiu, Jian-Hong Pan, Kailang Yang, moderated list:SOUND,
Jeremy Szu, open list, Huacai Chen, Takashi Iwai, Werner Sembach,
Hui Wang, andy.chi, Sami Loone
The HP ProBook 450 G8 using ALC236 codec which using 0x02 to
control mute LED and 0x01 to control micmute LED.
Therefore, add a quirk to make it works.
Signed-off-by: Andy Chi <andy.chi@canonical.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 308a58a83f33..6c423172a1f4 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8363,6 +8363,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
ALC285_FIXUP_HP_GPIO_AMP_INIT),
SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x87e7, "HP ProBook 450 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f2, "HP ProBook 640 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2 2/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 445 G8
2021-07-01 9:14 ` Andy Chi
@ 2021-07-01 9:14 ` Andy Chi
-1 siblings, 0 replies; 8+ messages in thread
From: Andy Chi @ 2021-07-01 9:14 UTC (permalink / raw)
Cc: andy.chi, Jaroslav Kysela, Takashi Iwai, Kailang Yang,
Jeremy Szu, Hui Wang, Jian-Hong Pan, Chris Chiu, Huacai Chen,
Sami Loone, Werner Sembach, moderated list:SOUND, open list
The HP ProBook 445 G8 using ALC236 codec.
COEF index 0x34 bit 5 is used to control the playback mute LED, but the
microphone mute LED is controlled using pin VREF instead of a COEF index.
Therefore, add a quirk to make it works.
Signed-off-by: Andy Chi <andy.chi@canonical.com>
---
sound/pci/hda/patch_realtek.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 6c423172a1f4..949c8e5ac54a 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8372,6 +8372,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8847, "HP EliteBook x360 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x884b, "HP EliteBook 840 Aero G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8862, "HP ProBook 445 G8 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+ SND_PCI_QUIRK(0x103c, 0x8863, "HP ProBook 445 G8 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x886d, "HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
SND_PCI_QUIRK(0x103c, 0x8870, "HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
SND_PCI_QUIRK(0x103c, 0x8873, "HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2 2/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 445 G8
@ 2021-07-01 9:14 ` Andy Chi
0 siblings, 0 replies; 8+ messages in thread
From: Andy Chi @ 2021-07-01 9:14 UTC (permalink / raw)
Cc: Chris Chiu, Jian-Hong Pan, Kailang Yang, moderated list:SOUND,
Jeremy Szu, open list, Huacai Chen, Takashi Iwai, Werner Sembach,
Hui Wang, andy.chi, Sami Loone
The HP ProBook 445 G8 using ALC236 codec.
COEF index 0x34 bit 5 is used to control the playback mute LED, but the
microphone mute LED is controlled using pin VREF instead of a COEF index.
Therefore, add a quirk to make it works.
Signed-off-by: Andy Chi <andy.chi@canonical.com>
---
sound/pci/hda/patch_realtek.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 6c423172a1f4..949c8e5ac54a 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8372,6 +8372,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8847, "HP EliteBook x360 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x884b, "HP EliteBook 840 Aero G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8862, "HP ProBook 445 G8 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+ SND_PCI_QUIRK(0x103c, 0x8863, "HP ProBook 445 G8 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x886d, "HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
SND_PCI_QUIRK(0x103c, 0x8870, "HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
SND_PCI_QUIRK(0x103c, 0x8873, "HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 3/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 630 G8
2021-07-01 9:14 ` Andy Chi
@ 2021-07-01 9:14 ` Andy Chi
-1 siblings, 0 replies; 8+ messages in thread
From: Andy Chi @ 2021-07-01 9:14 UTC (permalink / raw)
Cc: andy.chi, Jaroslav Kysela, Takashi Iwai, Kailang Yang,
Jeremy Szu, Hui Wang, Jian-Hong Pan, Chris Chiu, Huacai Chen,
Sami Loone, Werner Sembach, moderated list:SOUND, open list
The HP ProBook 630 G8 using ALC236 codec which using 0x02 to
control mute LED and 0x01 to control micmute LED.
Therefore, add a quirk to make it works.
Signed-off-by: Andy Chi <andy.chi@canonical.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 949c8e5ac54a..79e066b39f5e 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8364,6 +8364,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87e7, "HP ProBook 450 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x87f1, "HP ProBook 630 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f2, "HP ProBook 640 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2 3/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 630 G8
@ 2021-07-01 9:14 ` Andy Chi
0 siblings, 0 replies; 8+ messages in thread
From: Andy Chi @ 2021-07-01 9:14 UTC (permalink / raw)
Cc: Chris Chiu, Jian-Hong Pan, Kailang Yang, moderated list:SOUND,
Jeremy Szu, open list, Huacai Chen, Takashi Iwai, Werner Sembach,
Hui Wang, andy.chi, Sami Loone
The HP ProBook 630 G8 using ALC236 codec which using 0x02 to
control mute LED and 0x01 to control micmute LED.
Therefore, add a quirk to make it works.
Signed-off-by: Andy Chi <andy.chi@canonical.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 949c8e5ac54a..79e066b39f5e 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8364,6 +8364,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87e7, "HP ProBook 450 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x87f1, "HP ProBook 630 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f2, "HP ProBook 640 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 450 G8
2021-07-01 9:14 ` Andy Chi
@ 2021-07-01 17:09 ` Takashi Iwai
-1 siblings, 0 replies; 8+ messages in thread
From: Takashi Iwai @ 2021-07-01 17:09 UTC (permalink / raw)
To: Andy Chi
Cc: Jaroslav Kysela, Takashi Iwai, Kailang Yang, Jeremy Szu,
Hui Wang, Jian-Hong Pan, Chris Chiu, Huacai Chen, Sami Loone,
Werner Sembach, moderated list:SOUND, open list
On Thu, 01 Jul 2021 11:14:13 +0200,
Andy Chi wrote:
>
> The HP ProBook 450 G8 using ALC236 codec which using 0x02 to
> control mute LED and 0x01 to control micmute LED.
> Therefore, add a quirk to make it works.
>
> Signed-off-by: Andy Chi <andy.chi@canonical.com>
Applied all three patches now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 450 G8
@ 2021-07-01 17:09 ` Takashi Iwai
0 siblings, 0 replies; 8+ messages in thread
From: Takashi Iwai @ 2021-07-01 17:09 UTC (permalink / raw)
To: Andy Chi
Cc: Chris Chiu, moderated list:SOUND, Kailang Yang, Jeremy Szu,
open list, Huacai Chen, Jian-Hong Pan, Werner Sembach,
Takashi Iwai, Hui Wang, Sami Loone
On Thu, 01 Jul 2021 11:14:13 +0200,
Andy Chi wrote:
>
> The HP ProBook 450 G8 using ALC236 codec which using 0x02 to
> control mute LED and 0x01 to control micmute LED.
> Therefore, add a quirk to make it works.
>
> Signed-off-by: Andy Chi <andy.chi@canonical.com>
Applied all three patches now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 8+ messages in thread