All of lore.kernel.org
 help / color / mirror / Atom feed
* [jgunthorpe:vfio_reflck_cleanup 5/12] drivers/vfio/fsl-mc/vfio_fsl_mc.c:537:3: error: label 'out_kfree' used but not defined
@ 2021-07-01  8:15 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-07-01  8:15 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 3094 bytes --]

tree:   https://github.com/jgunthorpe/linux vfio_reflck_cleanup
head:   f4e0a740bed3d566fe5cbe71f10a4a32b5c0b2e6
commit: 778d5b4bf319d1a34941030614e21165556b4b58 [5/12] vfio/fsl: Move to the device set infrastructure
config: i386-randconfig-c004-20210630 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/jgunthorpe/linux/commit/778d5b4bf319d1a34941030614e21165556b4b58
        git remote add jgunthorpe https://github.com/jgunthorpe/linux
        git fetch --no-tags jgunthorpe vfio_reflck_cleanup
        git checkout 778d5b4bf319d1a34941030614e21165556b4b58
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/vfio/fsl-mc/vfio_fsl_mc.c: In function 'vfio_fsl_mc_probe':
>> drivers/vfio/fsl-mc/vfio_fsl_mc.c:537:3: error: label 'out_kfree' used but not defined
     537 |   goto out_kfree;
         |   ^~~~


vim +/out_kfree +537 drivers/vfio/fsl-mc/vfio_fsl_mc.c

   505	
   506	static int vfio_fsl_mc_probe(struct fsl_mc_device *mc_dev)
   507	{
   508		struct iommu_group *group;
   509		struct vfio_fsl_mc_device *vdev;
   510		struct device *dev = &mc_dev->dev;
   511		int ret;
   512	
   513		group = vfio_iommu_group_get(dev);
   514		if (!group) {
   515			dev_err(dev, "VFIO_FSL_MC: No IOMMU group\n");
   516			return -EINVAL;
   517		}
   518	
   519		vdev = kzalloc(sizeof(*vdev), GFP_KERNEL);
   520		if (!vdev) {
   521			ret = -ENOMEM;
   522			goto out_group_put;
   523		}
   524	
   525		vfio_init_group_dev(&vdev->vdev, dev, &vfio_fsl_mc_ops);
   526		vdev->mc_dev = mc_dev;
   527		mutex_init(&vdev->igate);
   528	
   529		ret = vfio_assign_device_set(&vdev->vdev, is_fsl_mc_bus_dprc(mc_dev) ?
   530								  &mc_dev->dev :
   531								  mc_dev->dev.parent);
   532		if (ret)
   533			goto out_uninit;
   534	
   535		ret = vfio_fsl_mc_init_device(vdev);
   536		if (ret)
 > 537			goto out_kfree;
   538	
   539		ret = vfio_register_group_dev(&vdev->vdev);
   540		if (ret) {
   541			dev_err(dev, "VFIO_FSL_MC: Failed to add to vfio group\n");
   542			goto out_device;
   543		}
   544	
   545		/* FIXME: this should be moved above, see my ealier patch that did that */
   546		ret = vfio_fsl_mc_scan_container(mc_dev);
   547		if (ret)
   548			goto out_group_dev;
   549		dev_set_drvdata(dev, vdev);
   550		return 0;
   551	
   552	out_group_dev:
   553		vfio_unregister_group_dev(&vdev->vdev);
   554	out_device:
   555		vfio_fsl_uninit_device(vdev);
   556	out_uninit:
   557		vfio_uninit_group_dev(&vdev->vdev);
   558		kfree(vdev);
   559	out_group_put:
   560		vfio_iommu_group_put(group, dev);
   561		return ret;
   562	}
   563	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 45749 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-07-01  8:15 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-01  8:15 [jgunthorpe:vfio_reflck_cleanup 5/12] drivers/vfio/fsl-mc/vfio_fsl_mc.c:537:3: error: label 'out_kfree' used but not defined kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.