From: "Krzysztof Wilczyński" <kw@linux.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Scott Murray <scott@spiteful.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: cpcihp: Move declaration of cpci_debug to the header file
Date: Thu, 1 Jul 2021 20:41:27 +0200 [thread overview]
Message-ID: <20210701184127.GA297254@rocinante> (raw)
In-Reply-To: <20210701175639.GA73684@bjorn-Precision-5520>
Hi Bjorn,
[...]
> > --- a/drivers/pci/hotplug/cpci_hotplug_core.c
> > +++ b/drivers/pci/hotplug/cpci_hotplug_core.c
> > @@ -44,7 +44,6 @@ static DECLARE_RWSEM(list_rwsem);
> > static LIST_HEAD(slot_list);
> > static int slots;
> > static atomic_t extracting;
> > -int cpci_debug;
>
> We can add a declaration, but we still need a *definition* somewhere,
> right?
This is my bad! Sincere apologies. I will send a v2 that drops this
hunk. This should have never been removed.
Krzysztof
prev parent reply other threads:[~2021-07-01 18:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 2:45 [PATCH] PCI: cpcihp: Move declaration of cpci_debug to the header file Krzysztof Wilczyński
2021-07-01 17:56 ` Bjorn Helgaas
2021-07-01 18:41 ` Krzysztof Wilczyński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210701184127.GA297254@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=scott@spiteful.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.