All of lore.kernel.org
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Jie Deng <jie.deng@intel.com>
Cc: Wolfram Sang <wsa@kernel.org>,
	linux-i2c@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, mst@redhat.com, arnd@arndb.de,
	jasowang@redhat.com, andriy.shevchenko@linux.intel.com,
	yu1.wang@intel.com, shuo.a.liu@intel.com, conghui.chen@intel.com,
	stefanha@redhat.com
Subject: Re: [PATCH v11] i2c: virtio: add a virtio i2c frontend driver
Date: Fri, 2 Jul 2021 12:51:27 +0530	[thread overview]
Message-ID: <20210702072127.yzofc75cuuqtvzbn@vireshk-i7> (raw)
In-Reply-To: <bdea419c-b450-f6b1-fff3-7df077b2abfc@intel.com>

On 02-07-21, 15:15, Jie Deng wrote:
> Then what is the need to design this interface as "return the number of
> messages successfully
> processed, or a negative value on error". Just return success or fail is
> enough.

Right, that isn't clear to me as well. And so I asked Wolfram this yesterday.

I think it is left for the clients handle this, i.e. what they want to do with
it if something fails in between.

> Here, we didn't break the contract with the interface "master_xfer", so if
> there is a problem then
> the contract may be the problem.

So in your case here, either you should return 0 or nr (the number of transfers
requested) and anything else can only be sent if the host reports partial
failures.

Also, since this driver is pretty much independent of everything else, and won't
break anything in the kernel, there is still a good chance of getting it merged
for 5.14-rc1/2.. So it would be better if you resend the next version as soon as
possible :)

-- 
viresh

WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Jie Deng <jie.deng@intel.com>
Cc: yu1.wang@intel.com, arnd@arndb.de, mst@redhat.com,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Wolfram Sang <wsa@kernel.org>,
	linux-i2c@vger.kernel.org, stefanha@redhat.com,
	shuo.a.liu@intel.com, andriy.shevchenko@linux.intel.com,
	conghui.chen@intel.com
Subject: Re: [PATCH v11] i2c: virtio: add a virtio i2c frontend driver
Date: Fri, 2 Jul 2021 12:51:27 +0530	[thread overview]
Message-ID: <20210702072127.yzofc75cuuqtvzbn@vireshk-i7> (raw)
In-Reply-To: <bdea419c-b450-f6b1-fff3-7df077b2abfc@intel.com>

On 02-07-21, 15:15, Jie Deng wrote:
> Then what is the need to design this interface as "return the number of
> messages successfully
> processed, or a negative value on error". Just return success or fail is
> enough.

Right, that isn't clear to me as well. And so I asked Wolfram this yesterday.

I think it is left for the clients handle this, i.e. what they want to do with
it if something fails in between.

> Here, we didn't break the contract with the interface "master_xfer", so if
> there is a problem then
> the contract may be the problem.

So in your case here, either you should return 0 or nr (the number of transfers
requested) and anything else can only be sent if the host reports partial
failures.

Also, since this driver is pretty much independent of everything else, and won't
break anything in the kernel, there is still a good chance of getting it merged
for 5.14-rc1/2.. So it would be better if you resend the next version as soon as
possible :)

-- 
viresh
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  reply	other threads:[~2021-07-02  7:21 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-01  3:24 [PATCH v11] i2c: virtio: add a virtio i2c frontend driver Jie Deng
2021-07-01  3:24 ` Jie Deng
2021-07-01  4:04 ` Viresh Kumar
2021-07-01  4:04   ` Viresh Kumar
2021-07-01  6:10   ` Jie Deng
2021-07-01  6:10     ` Jie Deng
2021-07-01  6:18     ` Viresh Kumar
2021-07-01  6:18       ` Viresh Kumar
2021-07-02  3:36       ` Jie Deng
2021-07-02  3:36         ` Jie Deng
2021-07-02  4:56         ` Viresh Kumar
2021-07-02  4:56           ` Viresh Kumar
2021-07-01 19:24   ` Wolfram Sang
2021-07-02  4:55     ` Viresh Kumar
2021-07-02  4:55       ` Viresh Kumar
2021-07-02  6:22       ` Wolfram Sang
2021-07-02  6:52       ` Jie Deng
2021-07-02  6:52         ` Jie Deng
2021-07-02  6:56         ` Viresh Kumar
2021-07-02  6:56           ` Viresh Kumar
2021-07-02  7:11           ` Wolfram Sang
2021-07-02  7:15           ` Jie Deng
2021-07-02  7:15             ` Jie Deng
2021-07-02  7:21             ` Viresh Kumar [this message]
2021-07-02  7:21               ` Viresh Kumar
2021-07-02  7:36               ` Wolfram Sang
2021-07-01  8:50 ` kernel test robot
2021-07-01  8:50   ` kernel test robot
2021-07-01  8:50   ` kernel test robot
2021-07-01 10:00 ` kernel test robot
2021-07-01 10:00   ` kernel test robot
2021-07-01 10:00   ` kernel test robot
2021-07-02  3:12   ` Jie Deng
2021-07-02  3:12     ` Jie Deng
2021-07-02  3:12     ` Jie Deng
2021-07-02  6:38     ` [kbuild-all] " Rong Chen
2021-07-02  6:38       ` Rong Chen
2021-07-01 10:45 ` Andy Shevchenko
2021-07-01 10:45   ` Andy Shevchenko
2021-07-02  1:05   ` Jie Deng
2021-07-02  1:05     ` Jie Deng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210702072127.yzofc75cuuqtvzbn@vireshk-i7 \
    --to=viresh.kumar@linaro.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=conghui.chen@intel.com \
    --cc=jasowang@redhat.com \
    --cc=jie.deng@intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=shuo.a.liu@intel.com \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=wsa@kernel.org \
    --cc=yu1.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.