From: "Michael S. Tsirkin" <mst@redhat.com>
To: kernel test robot <lkp@intel.com>
Cc: Zhu Lingshan <lingshan.zhu@intel.com>,
jasowang@redhat.com, clang-built-linux@googlegroups.com,
kbuild-all@lists.01.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 2/3] vDPA/ifcvf: implement management netlink framework for ifcvf
Date: Sat, 3 Jul 2021 05:04:07 -0400 [thread overview]
Message-ID: <20210703050320-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <202107010221.pN7dwv6A-lkp@intel.com>
On Thu, Jul 01, 2021 at 03:04:09AM +0800, kernel test robot wrote:
> Hi Zhu,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on linus/master]
> [also build test WARNING on v5.13 next-20210630]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Zhu-Lingshan/vDPA-ifcvf-implement-management-netlink-framework/20210630-162940
> base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 007b350a58754a93ca9fe50c498cc27780171153
> config: x86_64-randconfig-a015-20210630 (attached as .config)
> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 8d21d5472501460933e78aead04cf59579025ba4)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install x86_64 cross compiling tool for clang build
> # apt-get install binutils-x86-64-linux-gnu
> # https://github.com/0day-ci/linux/commit/7ea782fbd896e1a5b3c01b29f4929773748a525f
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Zhu-Lingshan/vDPA-ifcvf-implement-management-netlink-framework/20210630-162940
> git checkout 7ea782fbd896e1a5b3c01b29f4929773748a525f
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/vdpa/ifcvf/ifcvf_main.c:612:14: warning: variable 'adapter' is uninitialized when used here [-Wuninitialized]
> put_device(&adapter->vdpa.dev);
> ^~~~~~~
> drivers/vdpa/ifcvf/ifcvf_main.c:546:31: note: initialize the variable 'adapter' to silence this warning
> struct ifcvf_adapter *adapter;
> ^
> = NULL
> 1 warning generated.
>
Actually the problem is real and this is almost surely the wrong fix.
We need an extra label to skip using put_device when adapter was not
yet initialized.
> vim +/adapter +612 drivers/vdpa/ifcvf/ifcvf_main.c
>
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 541
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 542 static int ifcvf_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 543 {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 544 struct ifcvf_vdpa_mgmt_dev *ifcvf_mgmt_dev;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 545 struct device *dev = &pdev->dev;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 546 struct ifcvf_adapter *adapter;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 547 u32 dev_type;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 548 int ret;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 549
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 550 ifcvf_mgmt_dev = kzalloc(sizeof(struct ifcvf_vdpa_mgmt_dev), GFP_KERNEL);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 551 if (!ifcvf_mgmt_dev) {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 552 IFCVF_ERR(pdev, "Failed to alloc memory for the vDPA management device\n");
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 553 return -ENOMEM;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 554 }
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 555
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 556 dev_type = get_dev_type(pdev);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 557 switch (dev_type) {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 558 case VIRTIO_ID_NET:
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 559 ifcvf_mgmt_dev->mdev.id_table = id_table_net;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 560 break;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 561 case VIRTIO_ID_BLOCK:
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 562 ifcvf_mgmt_dev->mdev.id_table = id_table_blk;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 563 break;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 564 default:
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 565 IFCVF_ERR(pdev, "VIRTIO ID %u not supported\n", dev_type);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 566 ret = -EOPNOTSUPP;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 567 goto err;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 568 }
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 569
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 570 ifcvf_mgmt_dev->mdev.ops = &ifcvf_vdpa_mgmt_dev_ops;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 571 ifcvf_mgmt_dev->mdev.device = dev;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 572 ifcvf_mgmt_dev->pdev = pdev;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 573
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 574 ret = pcim_enable_device(pdev);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 575 if (ret) {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 576 IFCVF_ERR(pdev, "Failed to enable device\n");
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 577 goto err;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 578 }
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 579
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 580 ret = pcim_iomap_regions(pdev, BIT(0) | BIT(2) | BIT(4),
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 581 IFCVF_DRIVER_NAME);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 582 if (ret) {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 583 IFCVF_ERR(pdev, "Failed to request MMIO region\n");
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 584 goto err;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 585 }
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 586
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 587 ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 588 if (ret) {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 589 IFCVF_ERR(pdev, "No usable DMA configuration\n");
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 590 goto err;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 591 }
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 592
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 593 ret = devm_add_action_or_reset(dev, ifcvf_free_irq_vectors, pdev);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 594 if (ret) {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 595 IFCVF_ERR(pdev,
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 596 "Failed for adding devres for freeing irq vectors\n");
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 597 goto err;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 598 }
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 599
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 600 pci_set_master(pdev);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 601
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 602 ret = vdpa_mgmtdev_register(&ifcvf_mgmt_dev->mdev);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 603 if (ret) {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 604 IFCVF_ERR(pdev,
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 605 "Failed to initialize the management interfaces\n");
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 606 goto err;
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 607 }
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 608
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 609 return 0;
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 610
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 611 err:
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 @612 put_device(&adapter->vdpa.dev);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 613 kfree(ifcvf_mgmt_dev);
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 614 return ret;
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 615 }
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 616
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: kernel test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org, kvm@vger.kernel.org,
netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
clang-built-linux@googlegroups.com,
Zhu Lingshan <lingshan.zhu@intel.com>
Subject: Re: [PATCH 2/3] vDPA/ifcvf: implement management netlink framework for ifcvf
Date: Sat, 3 Jul 2021 05:04:07 -0400 [thread overview]
Message-ID: <20210703050320-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <202107010221.pN7dwv6A-lkp@intel.com>
On Thu, Jul 01, 2021 at 03:04:09AM +0800, kernel test robot wrote:
> Hi Zhu,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on linus/master]
> [also build test WARNING on v5.13 next-20210630]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Zhu-Lingshan/vDPA-ifcvf-implement-management-netlink-framework/20210630-162940
> base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 007b350a58754a93ca9fe50c498cc27780171153
> config: x86_64-randconfig-a015-20210630 (attached as .config)
> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 8d21d5472501460933e78aead04cf59579025ba4)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install x86_64 cross compiling tool for clang build
> # apt-get install binutils-x86-64-linux-gnu
> # https://github.com/0day-ci/linux/commit/7ea782fbd896e1a5b3c01b29f4929773748a525f
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Zhu-Lingshan/vDPA-ifcvf-implement-management-netlink-framework/20210630-162940
> git checkout 7ea782fbd896e1a5b3c01b29f4929773748a525f
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/vdpa/ifcvf/ifcvf_main.c:612:14: warning: variable 'adapter' is uninitialized when used here [-Wuninitialized]
> put_device(&adapter->vdpa.dev);
> ^~~~~~~
> drivers/vdpa/ifcvf/ifcvf_main.c:546:31: note: initialize the variable 'adapter' to silence this warning
> struct ifcvf_adapter *adapter;
> ^
> = NULL
> 1 warning generated.
>
Actually the problem is real and this is almost surely the wrong fix.
We need an extra label to skip using put_device when adapter was not
yet initialized.
> vim +/adapter +612 drivers/vdpa/ifcvf/ifcvf_main.c
>
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 541
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 542 static int ifcvf_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 543 {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 544 struct ifcvf_vdpa_mgmt_dev *ifcvf_mgmt_dev;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 545 struct device *dev = &pdev->dev;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 546 struct ifcvf_adapter *adapter;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 547 u32 dev_type;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 548 int ret;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 549
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 550 ifcvf_mgmt_dev = kzalloc(sizeof(struct ifcvf_vdpa_mgmt_dev), GFP_KERNEL);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 551 if (!ifcvf_mgmt_dev) {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 552 IFCVF_ERR(pdev, "Failed to alloc memory for the vDPA management device\n");
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 553 return -ENOMEM;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 554 }
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 555
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 556 dev_type = get_dev_type(pdev);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 557 switch (dev_type) {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 558 case VIRTIO_ID_NET:
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 559 ifcvf_mgmt_dev->mdev.id_table = id_table_net;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 560 break;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 561 case VIRTIO_ID_BLOCK:
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 562 ifcvf_mgmt_dev->mdev.id_table = id_table_blk;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 563 break;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 564 default:
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 565 IFCVF_ERR(pdev, "VIRTIO ID %u not supported\n", dev_type);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 566 ret = -EOPNOTSUPP;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 567 goto err;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 568 }
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 569
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 570 ifcvf_mgmt_dev->mdev.ops = &ifcvf_vdpa_mgmt_dev_ops;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 571 ifcvf_mgmt_dev->mdev.device = dev;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 572 ifcvf_mgmt_dev->pdev = pdev;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 573
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 574 ret = pcim_enable_device(pdev);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 575 if (ret) {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 576 IFCVF_ERR(pdev, "Failed to enable device\n");
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 577 goto err;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 578 }
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 579
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 580 ret = pcim_iomap_regions(pdev, BIT(0) | BIT(2) | BIT(4),
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 581 IFCVF_DRIVER_NAME);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 582 if (ret) {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 583 IFCVF_ERR(pdev, "Failed to request MMIO region\n");
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 584 goto err;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 585 }
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 586
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 587 ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 588 if (ret) {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 589 IFCVF_ERR(pdev, "No usable DMA configuration\n");
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 590 goto err;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 591 }
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 592
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 593 ret = devm_add_action_or_reset(dev, ifcvf_free_irq_vectors, pdev);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 594 if (ret) {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 595 IFCVF_ERR(pdev,
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 596 "Failed for adding devres for freeing irq vectors\n");
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 597 goto err;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 598 }
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 599
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 600 pci_set_master(pdev);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 601
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 602 ret = vdpa_mgmtdev_register(&ifcvf_mgmt_dev->mdev);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 603 if (ret) {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 604 IFCVF_ERR(pdev,
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 605 "Failed to initialize the management interfaces\n");
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 606 goto err;
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 607 }
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 608
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 609 return 0;
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 610
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 611 err:
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 @612 put_device(&adapter->vdpa.dev);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 613 kfree(ifcvf_mgmt_dev);
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 614 return ret;
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 615 }
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 616
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: Michael S. Tsirkin <mst@redhat.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 2/3] vDPA/ifcvf: implement management netlink framework for ifcvf
Date: Sat, 03 Jul 2021 05:04:07 -0400 [thread overview]
Message-ID: <20210703050320-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <202107010221.pN7dwv6A-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 11005 bytes --]
On Thu, Jul 01, 2021 at 03:04:09AM +0800, kernel test robot wrote:
> Hi Zhu,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on linus/master]
> [also build test WARNING on v5.13 next-20210630]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Zhu-Lingshan/vDPA-ifcvf-implement-management-netlink-framework/20210630-162940
> base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 007b350a58754a93ca9fe50c498cc27780171153
> config: x86_64-randconfig-a015-20210630 (attached as .config)
> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 8d21d5472501460933e78aead04cf59579025ba4)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install x86_64 cross compiling tool for clang build
> # apt-get install binutils-x86-64-linux-gnu
> # https://github.com/0day-ci/linux/commit/7ea782fbd896e1a5b3c01b29f4929773748a525f
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Zhu-Lingshan/vDPA-ifcvf-implement-management-netlink-framework/20210630-162940
> git checkout 7ea782fbd896e1a5b3c01b29f4929773748a525f
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/vdpa/ifcvf/ifcvf_main.c:612:14: warning: variable 'adapter' is uninitialized when used here [-Wuninitialized]
> put_device(&adapter->vdpa.dev);
> ^~~~~~~
> drivers/vdpa/ifcvf/ifcvf_main.c:546:31: note: initialize the variable 'adapter' to silence this warning
> struct ifcvf_adapter *adapter;
> ^
> = NULL
> 1 warning generated.
>
Actually the problem is real and this is almost surely the wrong fix.
We need an extra label to skip using put_device when adapter was not
yet initialized.
> vim +/adapter +612 drivers/vdpa/ifcvf/ifcvf_main.c
>
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 541
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 542 static int ifcvf_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 543 {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 544 struct ifcvf_vdpa_mgmt_dev *ifcvf_mgmt_dev;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 545 struct device *dev = &pdev->dev;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 546 struct ifcvf_adapter *adapter;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 547 u32 dev_type;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 548 int ret;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 549
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 550 ifcvf_mgmt_dev = kzalloc(sizeof(struct ifcvf_vdpa_mgmt_dev), GFP_KERNEL);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 551 if (!ifcvf_mgmt_dev) {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 552 IFCVF_ERR(pdev, "Failed to alloc memory for the vDPA management device\n");
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 553 return -ENOMEM;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 554 }
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 555
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 556 dev_type = get_dev_type(pdev);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 557 switch (dev_type) {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 558 case VIRTIO_ID_NET:
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 559 ifcvf_mgmt_dev->mdev.id_table = id_table_net;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 560 break;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 561 case VIRTIO_ID_BLOCK:
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 562 ifcvf_mgmt_dev->mdev.id_table = id_table_blk;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 563 break;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 564 default:
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 565 IFCVF_ERR(pdev, "VIRTIO ID %u not supported\n", dev_type);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 566 ret = -EOPNOTSUPP;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 567 goto err;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 568 }
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 569
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 570 ifcvf_mgmt_dev->mdev.ops = &ifcvf_vdpa_mgmt_dev_ops;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 571 ifcvf_mgmt_dev->mdev.device = dev;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 572 ifcvf_mgmt_dev->pdev = pdev;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 573
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 574 ret = pcim_enable_device(pdev);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 575 if (ret) {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 576 IFCVF_ERR(pdev, "Failed to enable device\n");
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 577 goto err;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 578 }
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 579
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 580 ret = pcim_iomap_regions(pdev, BIT(0) | BIT(2) | BIT(4),
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 581 IFCVF_DRIVER_NAME);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 582 if (ret) {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 583 IFCVF_ERR(pdev, "Failed to request MMIO region\n");
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 584 goto err;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 585 }
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 586
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 587 ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 588 if (ret) {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 589 IFCVF_ERR(pdev, "No usable DMA configuration\n");
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 590 goto err;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 591 }
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 592
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 593 ret = devm_add_action_or_reset(dev, ifcvf_free_irq_vectors, pdev);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 594 if (ret) {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 595 IFCVF_ERR(pdev,
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 596 "Failed for adding devres for freeing irq vectors\n");
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 597 goto err;
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 598 }
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 599
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 600 pci_set_master(pdev);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 601
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 602 ret = vdpa_mgmtdev_register(&ifcvf_mgmt_dev->mdev);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 603 if (ret) {
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 604 IFCVF_ERR(pdev,
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 605 "Failed to initialize the management interfaces\n");
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 606 goto err;
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 607 }
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 608
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 609 return 0;
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 610
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 611 err:
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 @612 put_device(&adapter->vdpa.dev);
> 7ea782fbd896e1 drivers/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2021-06-30 613 kfree(ifcvf_mgmt_dev);
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 614 return ret;
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 615 }
> 5a2414bc454e89 drivers/virtio/vdpa/ifcvf/ifcvf_main.c Zhu Lingshan 2020-03-26 616
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2021-07-03 9:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 8:21 [PATCH 0/3] vDPA/ifcvf: implement management netlink framework Zhu Lingshan
2021-06-30 8:21 ` [PATCH 1/3] vDPA/ifcvf: introduce get_dev_type() which returns virtio dev id Zhu Lingshan
2021-06-30 8:21 ` [PATCH 2/3] vDPA/ifcvf: implement management netlink framework for ifcvf Zhu Lingshan
2021-06-30 19:04 ` kernel test robot
2021-06-30 19:04 ` kernel test robot
2021-06-30 19:04 ` kernel test robot
2021-07-03 9:02 ` Michael S. Tsirkin
2021-07-03 9:02 ` Michael S. Tsirkin
2021-07-03 9:02 ` Michael S. Tsirkin
2021-07-03 9:04 ` Michael S. Tsirkin [this message]
2021-07-03 9:04 ` Michael S. Tsirkin
2021-07-03 9:04 ` Michael S. Tsirkin
2021-07-05 5:04 ` Jason Wang
2021-07-05 5:04 ` Jason Wang
2021-07-05 6:34 ` Michael S. Tsirkin
2021-07-05 6:34 ` Michael S. Tsirkin
2021-07-05 6:38 ` Zhu, Lingshan
2021-06-30 8:21 ` [PATCH 3/3] vDPA/ifcvf: set_status() should get a adapter from the mgmt dev Zhu Lingshan
2021-07-05 5:09 ` Jason Wang
2021-07-05 5:09 ` Jason Wang
2021-07-05 9:46 ` Zhu, Lingshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210703050320-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=clang-built-linux@googlegroups.com \
--cc=jasowang@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=kvm@vger.kernel.org \
--cc=lingshan.zhu@intel.com \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.