* [PATCH 2/2] dt-bindings: iio: temperature: add MAXIM max31865 support
@ 2021-07-03 9:59 Navin Sankar Velliangiri
2021-07-03 14:56 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Navin Sankar Velliangiri @ 2021-07-03 9:59 UTC (permalink / raw)
Cc: jic23, lars, pmeerw, linux-iio, navin
Add DT bindings for MAXIM max31865 RTD sensor.
Signed-off-by: Navin Sankar Velliangiri <navin@linumiz.com>
---
.../iio/temperature/maxim,max31865.yaml | 52 +++++++++++++++++++
1 file changed, 52 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/temperature/maxim,max31865.yaml
diff --git a/Documentation/devicetree/bindings/iio/temperature/maxim,max31865.yaml b/Documentation/devicetree/bindings/iio/temperature/maxim,max31865.yaml
new file mode 100644
index 000000000000..9efadea514e1
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/temperature/maxim,max31865.yaml
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/temperature/maxim,max31865.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim MAX31865 RTD-to-Digital Converter.
+
+maintainers:
+ - Navin Sankar Velliangiri <navin@linumiz.com>
+
+description: |
+ https://datasheets.maximintegrated.com/en/ds/MAX31865.pdf
+
+properties:
+ compatible:
+ const: maxim,max31865
+
+ reg:
+ maxItems: 1
+
+ maxim,no-of-wires:
+ description:
+ Setting this property enables 3-wire config. Else
+ 2-wire or 4-wire.
+ type: boolean
+
+ spi-max-frequency: true
+ spi-cpha: true
+
+required:
+ - compatible
+ - reg
+ - spi-cpha
+
+additionalProperties: false
+
+examples:
+ - |
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ temp_sensor@0 {
+ compatible = "maxim,max31865";
+ reg = <0>;
+ spi-max-frequency = <400000>;
+ spi-cpha;
+ maxim,no-of-wires;
+ };
+ };
+...
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] dt-bindings: iio: temperature: add MAXIM max31865 support
2021-07-03 9:59 [PATCH 2/2] dt-bindings: iio: temperature: add MAXIM max31865 support Navin Sankar Velliangiri
@ 2021-07-03 14:56 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2021-07-03 14:56 UTC (permalink / raw)
To: Navin Sankar Velliangiri; +Cc: lars, pmeerw, linux-iio
On Sat, 3 Jul 2021 15:29:54 +0530
Navin Sankar Velliangiri <navin@linumiz.com> wrote:
> Add DT bindings for MAXIM max31865 RTD sensor.
>
> Signed-off-by: Navin Sankar Velliangiri <navin@linumiz.com>
Hi Navin,
Welcome to IIO!
A few comments inline.
Thanks,
Jonathan
> ---
> .../iio/temperature/maxim,max31865.yaml | 52 +++++++++++++++++++
> 1 file changed, 52 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/temperature/maxim,max31865.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/temperature/maxim,max31865.yaml b/Documentation/devicetree/bindings/iio/temperature/maxim,max31865.yaml
> new file mode 100644
> index 000000000000..9efadea514e1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/temperature/maxim,max31865.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/temperature/maxim,max31865.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim MAX31865 RTD-to-Digital Converter.
Good to spell out RTD: Restance temperature detector
> +
> +maintainers:
> + - Navin Sankar Velliangiri <navin@linumiz.com>
> +
> +description: |
> + https://datasheets.maximintegrated.com/en/ds/MAX31865.pdf
> +
> +properties:
> + compatible:
> + const: maxim,max31865
> +
> + reg:
> + maxItems: 1
> +
> + maxim,no-of-wires:
> + description:
> + Setting this property enables 3-wire config. Else
> + 2-wire or 4-wire.
> + type: boolean
Either make this take a the value 2, 3 or 4 (my preference)
or potentially rename it as maxim,3-wire.
Whilst we can expect people to look at the binding docs if they need details, we
still want someone glancing at a dts file to know what the binding means and
that isn't true for this parameter as current defined.
> +
> + spi-max-frequency: true
> + spi-cpha: true
> +
> +required:
> + - compatible
> + - reg
> + - spi-cpha
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + temp_sensor@0 {
> + compatible = "maxim,max31865";
> + reg = <0>;
> + spi-max-frequency = <400000>;
> + spi-cpha;
> + maxim,no-of-wires;
> + };
Some tabs in here, which means that a dt-schema check would have failed I think.
Please make sure you fix those up and run the tests as described in
Documentation/devicetree/bindings/writing-schema.rst
before sending v2.
> + };
> +...
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-03 14:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-03 9:59 [PATCH 2/2] dt-bindings: iio: temperature: add MAXIM max31865 support Navin Sankar Velliangiri
2021-07-03 14:56 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.