[PATCH] libubootenv: Disable for ppc/ppc64 qemu machines

[PATCH] libubootenv: Disable for ppc/ppc64 qemu machines

[Khem Raj]

This recipe depends on u-boot and u-boot is not available for
qemuppc/qemuppc64 and there is no defconfig available either

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb b/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
index 306296922c..88a8397c3c 100644
--- a/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
+++ b/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
@@ -25,6 +25,9 @@ RPROVIDES_${PN}-bin += "u-boot-fw-utils"
 
 PACKAGE_ARCH = "${MACHINE_ARCH}"
 
+COMPATIBLE_HOST_qemuppc64 = "null"
+COMPATIBLE_HOST_qemuppc = "null"
+
 RRECOMMENDS_${PN}-bin_append_class-target = " u-boot-default-env"
 
 BBCLASSEXTEND = "native"
-- 
2.32.0

Re: [PATCH] libubootenv: Disable for ppc/ppc64 qemu machines

[Khem Raj]

ping

On Sun, Jul 4, 2021 at 2:07 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> This recipe depends on u-boot and u-boot is not available for
> qemuppc/qemuppc64 and there is no defconfig available either
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb b/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
> index 306296922c..88a8397c3c 100644
> --- a/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
> +++ b/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
> @@ -25,6 +25,9 @@ RPROVIDES_${PN}-bin += "u-boot-fw-utils"
>
>  PACKAGE_ARCH = "${MACHINE_ARCH}"
>
> +COMPATIBLE_HOST_qemuppc64 = "null"
> +COMPATIBLE_HOST_qemuppc = "null"
> +
>  RRECOMMENDS_${PN}-bin_append_class-target = " u-boot-default-env"
>
>  BBCLASSEXTEND = "native"
> --
> 2.32.0
>

Re: [PATCH] libubootenv: Disable for ppc/ppc64 qemu machines

[Khem Raj]

ping^2

Is there any issue with this patch ? If so please let me know

I am seeing following on qemuppc64

ERROR: Nothing RPROVIDES 'u-boot-default-env' (but
/mnt/b/yoe/master/sources/openembedded-core/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
RDEPENDS on or otherwise requires it)
u-boot-starfive RPROVIDES u-boot-default-env but was skipped:
incompatible with machine qemuppc64 (not in COMPATIBLE_MACHINE)
u-boot-hardkernel RPROVIDES u-boot-default-env but was skipped:
incompatible with machine qemuppc64 (not in COMPATIBLE_MACHINE)
u-boot-poplar RPROVIDES u-boot-default-env but was skipped: Either
UBOOT_MACHINE or UBOOT_CONFIG must be set in the qemuppc64 machine
configuration.
u-boot-imx-mfgtool RPROVIDES u-boot-default-env but was skipped:
incompatible with machine qemuppc64 (not in COMPATIBLE_MACHINE)
u-boot-toradex RPROVIDES u-boot-default-env but was skipped:
incompatible with machine qemuppc64 (not in COMPATIBLE_MACHINE)
u-boot-ti-mainline RPROVIDES u-boot-default-env but was skipped:
incompatible with machine qemuppc64 (not in COMPATIBLE_MACHINE)
u-boot-juno RPROVIDES u-boot-default-env but was skipped: Either
UBOOT_MACHINE or UBOOT_CONFIG must be set in the qemuppc64 machine
configuration.
u-boot-qoriq RPROVIDES u-boot-default-env but was skipped:
incompatible with machine qemuppc64 (not in COMPATIBLE_MACHINE)
u-boot-ti-staging RPROVIDES u-boot-default-env but was skipped:
incompatible with machine qemuppc64 (not in COMPATIBLE_MACHINE)
u-boot-timesys RPROVIDES u-boot-default-env but was skipped:
incompatible with machine qemuppc64 (not in COMPATIBLE_MACHINE)
u-boot-congatec RPROVIDES u-boot-default-env but was skipped:
incompatible with machine qemuppc64 (not in COMPATIBLE_MACHINE)
u-boot-qoriq RPROVIDES u-boot-default-env but was skipped:
incompatible with machine qemuppc64 (not in COMPATIBLE_MACHINE)
u-boot-imx RPROVIDES u-boot-default-env but was skipped: incompatible
with machine qemuppc64 (not in COMPATIBLE_MACHINE)
u-boot RPROVIDES u-boot-default-env but was skipped: Either
UBOOT_MACHINE or UBOOT_CONFIG must be set in the qemuppc64 machine
configuration.
u-boot-fslc RPROVIDES u-boot-default-env but was skipped: incompatible
with machine qemuppc64 (not in COMPATIBLE_MACHINE)
u-boot-gateworks-imx RPROVIDES u-boot-default-env but was skipped:
incompatible with machine qemuppc64 (not in COMPATIBLE_MACHINE)
u-boot-boundary RPROVIDES u-boot-default-env but was skipped:
incompatible with machine qemuppc64 (not in COMPATIBLE_MACHINE)
u-boot-orangepi-i96 RPROVIDES u-boot-default-env but was skipped:
Either UBOOT_MACHINE or UBOOT_CONFIG must be set in the qemuppc64
machine configuration.
u-boot-fslc-mfgtool RPROVIDES u-boot-default-env but was skipped:
incompatible with machine qemuppc64 (not in COMPATIBLE_MACHINE)
u-boot-kontron RPROVIDES u-boot-default-env but was skipped:
incompatible with machine qemuppc64 (not in COMPATIBLE_MACHINE)
u-boot-remarkable2 RPROVIDES u-boot-default-env but was skipped:
incompatible with machine qemuppc64 (not in COMPATIBLE_MACHINE)
u-boot-variscite RPROVIDES u-boot-default-env but was skipped:
incompatible with machine qemuppc64 (not in COMPATIBLE_MACHINE)
u-boot-ti-staging RPROVIDES u-boot-default-env but was skipped:
incompatible with machine qemuppc64 (not in COMPATIBLE_MACHINE)
NOTE: Runtime target 'u-boot-default-env' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['u-boot-default-env']
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata',
'libubootenv', 'u-boot-default-env']


On Wed, Jul 7, 2021 at 10:15 AM Khem Raj <raj.khem@gmail.com> wrote:
>
> ping
>
> On Sun, Jul 4, 2021 at 2:07 PM Khem Raj <raj.khem@gmail.com> wrote:
> >
> > This recipe depends on u-boot and u-boot is not available for
> > qemuppc/qemuppc64 and there is no defconfig available either
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb b/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
> > index 306296922c..88a8397c3c 100644
> > --- a/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
> > +++ b/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
> > @@ -25,6 +25,9 @@ RPROVIDES_${PN}-bin += "u-boot-fw-utils"
> >
> >  PACKAGE_ARCH = "${MACHINE_ARCH}"
> >
> > +COMPATIBLE_HOST_qemuppc64 = "null"
> > +COMPATIBLE_HOST_qemuppc = "null"
> > +
> >  RRECOMMENDS_${PN}-bin_append_class-target = " u-boot-default-env"
> >
> >  BBCLASSEXTEND = "native"
> > --
> > 2.32.0
> >

Re: [OE-core] [PATCH] libubootenv: Disable for ppc/ppc64 qemu machines

[Tom Rini]

On Thu, Jul 22, 2021 at 12:34:47PM -0700, Khem Raj wrote:

> ping^2
> 
> Is there any issue with this patch ? If so please let me know

Note that qemu-ppce500_defconfig would be a good target to use for ppc
for U-Boot, but not ppc64 and wouldn't cover the mac99 machine type OE
uses anyhow.

-- 
Tom

Re: [OE-core] [PATCH] libubootenv: Disable for ppc/ppc64 qemu machines

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 598 bytes --]

On Thu, Jul 22, 2021 at 12:49 PM Tom Rini <trini@konsulko.com> wrote:

> On Thu, Jul 22, 2021 at 12:34:47PM -0700, Khem Raj wrote:
>
> > ping^2
> >
> > Is there any issue with this patch ? If so please let me know
>
> Note that qemu-ppce500_defconfig would be a good target to use for ppc


It would be far from what we emulate though as qemuppc machine


> for U-Boot, but not ppc64 and wouldn't cover the mac99 machine type OE
> uses anyhow.


Same here

We don’t use uboot
On these machines so I don’t see any harm in disabling it here do you ?

>
>
> --
> Tom
>

[-- Attachment #2: Type: text/html, Size: 1322 bytes --]

Re: [OE-core] [PATCH] libubootenv: Disable for ppc/ppc64 qemu machines

[Tom Rini]

On Thu, Jul 22, 2021 at 05:02:16PM -0700, Khem Raj wrote:
> On Thu, Jul 22, 2021 at 12:49 PM Tom Rini <trini@konsulko.com> wrote:
> 
> > On Thu, Jul 22, 2021 at 12:34:47PM -0700, Khem Raj wrote:
> >
> > > ping^2
> > >
> > > Is there any issue with this patch ? If so please let me know
> >
> > Note that qemu-ppce500_defconfig would be a good target to use for ppc
> 
> It would be far from what we emulate though as qemuppc machine
> 
> 
> > for U-Boot, but not ppc64 and wouldn't cover the mac99 machine type OE
> > uses anyhow.
> 
> 
> Same here
> 
> We don’t use uboot
> On these machines so I don’t see any harm in disabling it here do you ?

I guess I only high-level wonder why the target in OE is an old powermac
and not the e500 class machines.  I mean it could be related to how the
qemu target in U-Boot wasn't that useful for a while, a long while back.
So no, I don't object to this specific change, but I do wonder why OE
targets what it targets rather than (what I understand anyhow to be) the
common use case of qemu for ppc32 systems.  I could just be mistaken
there, however.

-- 
Tom

Re: [OE-core] [PATCH] libubootenv: Disable for ppc/ppc64 qemu machines

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1411 bytes --]

On Thu, Jul 22, 2021 at 5:05 PM Tom Rini <trini@konsulko.com> wrote:

> On Thu, Jul 22, 2021 at 05:02:16PM -0700, Khem Raj wrote:
> > On Thu, Jul 22, 2021 at 12:49 PM Tom Rini <trini@konsulko.com> wrote:
> >
> > > On Thu, Jul 22, 2021 at 12:34:47PM -0700, Khem Raj wrote:
> > >
> > > > ping^2
> > > >
> > > > Is there any issue with this patch ? If so please let me know
> > >
> > > Note that qemu-ppce500_defconfig would be a good target to use for ppc
> >
> > It would be far from what we emulate though as qemuppc machine
> >
> >
> > > for U-Boot, but not ppc64 and wouldn't cover the mac99 machine type OE
> > > uses anyhow.
> >
> >
> > Same here
> >
> > We don’t use uboot
> > On these machines so I don’t see any harm in disabling it here do you ?
>
> I guess I only high-level wonder why the target in OE is an old powermac
> and not the e500 class machines.  I mean it could be related to how the
> qemu target in U-Boot wasn't that useful for a while, a long while back.
> So no, I don't object to this specific change, but I do wonder why OE
> targets what it targets rather than (what I understand anyhow to be) the
> common use case of qemu for ppc32 systems.  I could just be mistaken
> there, however.


BookE implementation in Qemu was never as robust to emulate full system in
past that’s where we use traditional ppc target here


>
> --
> Tom
>

[-- Attachment #2: Type: text/html, Size: 2114 bytes --]

Re: [OE-core] [PATCH] libubootenv: Disable for ppc/ppc64 qemu machines

[Richard Purdie]

On Thu, 2021-07-22 at 12:34 -0700, Khem Raj wrote:
> ping^2
> 
> Is there any issue with this patch ? If so please let me know

There was an ongoing discussion about whether a patch triggering some of these 
issues should be reverted or not. I was hoping we'd figure that issue out...

Cheers,

Richard

Re: [OE-core] [PATCH] libubootenv: Disable for ppc/ppc64 qemu machines

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

On Thu, Jul 22, 2021 at 1:14 PM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Thu, 2021-07-22 at 12:34 -0700, Khem Raj wrote:
> > ping^2
> >
> > Is there any issue with this patch ? If so please let me know
>
> There was an ongoing discussion about whether a patch triggering some of
> these
> issues should be reverted or not. I was hoping we'd figure that issue
> out...


Sadly the revert does not help here this patch is still needed

>
>
> Cheers,
>
> Richard
>
>

[-- Attachment #2: Type: text/html, Size: 990 bytes --]