From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
Yang Shi <shy828301@gmail.com>, Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] mm: try_to_unmap() is now void
Date: Sun, 4 Jul 2021 16:01:15 -0700 [thread overview]
Message-ID: <20210704230115.27694-1-rdunlap@infradead.org> (raw)
Fix the "CONFIG_MMU is not set" case of converting
try_to_unmap() from bool to void.
In file included from ../mm/vmscan.c:33:
../mm/vmscan.c: In function 'shrink_page_list':
../include/linux/rmap.h:294:34: warning: statement with no effect [-Wunused-value]
294 | #define try_to_unmap(page, refs) false
| ^~~~~
../mm/vmscan.c:1508:4: note: in expansion of macro 'try_to_unmap'
1508 | try_to_unmap(page, flags);
| ^~~~~~~~~~~~
Fixes: 1fb08ac63bee ("mm: rmap: make try_to_unmap() void function")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Yang Shi <shy828301@gmail.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
include/linux/rmap.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20210701.orig/include/linux/rmap.h
+++ linux-next-20210701/include/linux/rmap.h
@@ -291,7 +291,7 @@ static inline int page_referenced(struct
return 0;
}
-#define try_to_unmap(page, refs) false
+#define try_to_unmap(page, refs) do {} while (0)
static inline int page_mkclean(struct page *page)
{
next reply other threads:[~2021-07-04 23:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-04 23:01 Randy Dunlap [this message]
2021-07-07 16:16 [PATCH] mm: try_to_unmap() is now void Randy Dunlap
2021-07-07 17:05 ` Matthew Wilcox
2021-07-07 17:25 ` Yang Shi
2021-07-07 17:25 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210704230115.27694-1-rdunlap@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shy828301@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.