All of
 help / color / mirror / Atom feed
From: Randy Dunlap <>
Cc: Randy Dunlap <>,
	Yang Shi <>, Hugh Dickins <>,
	Andrew Morton <>,, Greg Ungerer <>,,
Subject: [PATCH] mm: try_to_unmap() is now void
Date: Wed,  7 Jul 2021 09:16:14 -0700	[thread overview]
Message-ID: <> (raw)

Fix the "CONFIG_MMU is not set" case of converting
try_to_unmap() from bool to void.
(as seen on m68k/coldfire)

In file included from ../mm/vmscan.c:33:
../mm/vmscan.c: In function 'shrink_page_list':
../include/linux/rmap.h:294:34: warning: statement with no effect [-Wunused-value]
  294 | #define try_to_unmap(page, refs) false
      |                                  ^~~~~
../mm/vmscan.c:1508:4: note: in expansion of macro 'try_to_unmap'
 1508 |    try_to_unmap(page, flags);
      |    ^~~~~~~~~~~~

Fixes: 1fb08ac63bee ("mm: rmap: make try_to_unmap() void function")
Signed-off-by: Randy Dunlap <>
Cc: Yang Shi <>
Cc: Hugh Dickins <>
Cc: Andrew Morton <>
Cc: Greg Ungerer <>
v2: add linux-mm m.l.
    add M68K/Coldfire Cc's
    change to static inline function.

 include/linux/rmap.h |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-next-20210701.orig/include/linux/rmap.h
+++ linux-next-20210701/include/linux/rmap.h
@@ -291,7 +291,8 @@ static inline int page_referenced(struct
 	return 0;
-#define try_to_unmap(page, refs) false
+static inline void try_to_unmap(struct page *page, enum ttu_flags flags)
 static inline int page_mkclean(struct page *page)

             reply	other threads:[~2021-07-07 16:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-07 16:16 Randy Dunlap [this message]
2021-07-07 17:05 ` [PATCH] mm: try_to_unmap() is now void Matthew Wilcox
2021-07-07 17:25 ` Yang Shi
2021-07-07 17:25   ` Yang Shi
  -- strict thread matches above, loose matches on Subject: below --
2021-07-04 23:01 Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.