From: Cristian Marussi <cristian.marussi@arm.com> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, cristian.marussi@arm.com, igor.skalkin@opensynergy.com, peter.hilber@opensynergy.com, alex.bennee@linaro.org, jean-philippe@linaro.org, mikhail.golubev@opensynergy.com, anton.yakovlev@opensynergy.com, Vasyl.Vavrychuk@opensynergy.com, Andriy.Tryshnivskyy@opensynergy.com Subject: [PATCH v5 13/15] firmware: arm_scmi: Add optional link_supplier() transport op Date: Mon, 5 Jul 2021 15:49:12 +0100 [thread overview] Message-ID: <20210705144914.35094-14-cristian.marussi@arm.com> (raw) In-Reply-To: <20210705144914.35094-1-cristian.marussi@arm.com> From: Peter Hilber <peter.hilber@opensynergy.com> Some transports are also effectively registered with other kernel subsystem in order to be properly probed and initialized; as a consequence such kind of transports, and their related devices, might still not have been probed and initialized at the time the main SCMI core driver is probed. Add an optional .link_supplier() transport operation which can be used by the core SCMI stack to dynamically check if the transport is ready and dynamically link its device to the platform instance device. Signed-off-by: Peter Hilber <peter.hilber@opensynergy.com> [ Cristian: reworded commit message ] Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> --- drivers/firmware/arm_scmi/common.h | 2 ++ drivers/firmware/arm_scmi/driver.c | 6 ++++++ 2 files changed, 8 insertions(+) diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h index 7cd7aa8c9b3d..1cd8e7141495 100644 --- a/drivers/firmware/arm_scmi/common.h +++ b/drivers/firmware/arm_scmi/common.h @@ -331,6 +331,7 @@ struct scmi_chan_info { /** * struct scmi_transport_ops - Structure representing a SCMI transport ops * + * @link_supplier: Optional callback to add link to a supplier device * @chan_available: Callback to check if channel is available or not * @chan_setup: Callback to allocate and setup a channel * @chan_free: Callback to free a channel @@ -345,6 +346,7 @@ struct scmi_chan_info { * @poll_done: Callback to poll transfer status */ struct scmi_transport_ops { + int (*link_supplier)(struct device *dev); bool (*chan_available)(struct device *dev, int idx); int (*chan_setup)(struct scmi_chan_info *cinfo, struct device *dev, bool tx); diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 774a5c399ef3..f0325ef089fc 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -1963,6 +1963,12 @@ static int scmi_probe(struct platform_device *pdev) handle->devm_protocol_get = scmi_devm_protocol_get; handle->devm_protocol_put = scmi_devm_protocol_put; + if (desc->ops->link_supplier) { + ret = desc->ops->link_supplier(dev); + if (ret) + return ret; + } + ret = scmi_txrx_setup(info, dev, SCMI_PROTOCOL_BASE); if (ret) return ret; -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Cristian Marussi <cristian.marussi@arm.com> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, cristian.marussi@arm.com, igor.skalkin@opensynergy.com, peter.hilber@opensynergy.com, alex.bennee@linaro.org, jean-philippe@linaro.org, mikhail.golubev@opensynergy.com, anton.yakovlev@opensynergy.com, Vasyl.Vavrychuk@opensynergy.com, Andriy.Tryshnivskyy@opensynergy.com Subject: [PATCH v5 13/15] firmware: arm_scmi: Add optional link_supplier() transport op Date: Mon, 5 Jul 2021 15:49:12 +0100 [thread overview] Message-ID: <20210705144914.35094-14-cristian.marussi@arm.com> (raw) In-Reply-To: <20210705144914.35094-1-cristian.marussi@arm.com> From: Peter Hilber <peter.hilber@opensynergy.com> Some transports are also effectively registered with other kernel subsystem in order to be properly probed and initialized; as a consequence such kind of transports, and their related devices, might still not have been probed and initialized at the time the main SCMI core driver is probed. Add an optional .link_supplier() transport operation which can be used by the core SCMI stack to dynamically check if the transport is ready and dynamically link its device to the platform instance device. Signed-off-by: Peter Hilber <peter.hilber@opensynergy.com> [ Cristian: reworded commit message ] Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> --- drivers/firmware/arm_scmi/common.h | 2 ++ drivers/firmware/arm_scmi/driver.c | 6 ++++++ 2 files changed, 8 insertions(+) diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h index 7cd7aa8c9b3d..1cd8e7141495 100644 --- a/drivers/firmware/arm_scmi/common.h +++ b/drivers/firmware/arm_scmi/common.h @@ -331,6 +331,7 @@ struct scmi_chan_info { /** * struct scmi_transport_ops - Structure representing a SCMI transport ops * + * @link_supplier: Optional callback to add link to a supplier device * @chan_available: Callback to check if channel is available or not * @chan_setup: Callback to allocate and setup a channel * @chan_free: Callback to free a channel @@ -345,6 +346,7 @@ struct scmi_chan_info { * @poll_done: Callback to poll transfer status */ struct scmi_transport_ops { + int (*link_supplier)(struct device *dev); bool (*chan_available)(struct device *dev, int idx); int (*chan_setup)(struct scmi_chan_info *cinfo, struct device *dev, bool tx); diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 774a5c399ef3..f0325ef089fc 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -1963,6 +1963,12 @@ static int scmi_probe(struct platform_device *pdev) handle->devm_protocol_get = scmi_devm_protocol_get; handle->devm_protocol_put = scmi_devm_protocol_put; + if (desc->ops->link_supplier) { + ret = desc->ops->link_supplier(dev); + if (ret) + return ret; + } + ret = scmi_txrx_setup(info, dev, SCMI_PROTOCOL_BASE); if (ret) return ret; -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-05 14:51 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-05 14:48 [PATCH v5 00/15] Introduce SCMI transport based on VirtIO Cristian Marussi 2021-07-05 14:48 ` Cristian Marussi 2021-07-05 14:49 ` [PATCH v5 01/15] firmware: arm_scmi: Avoid padding in sensor message structure Cristian Marussi 2021-07-05 14:49 ` Cristian Marussi 2021-07-05 14:49 ` [PATCH v5 02/15] firmware: arm_scmi: Fix max pending messages boundary check Cristian Marussi 2021-07-05 14:49 ` Cristian Marussi 2021-07-05 14:49 ` [PATCH v5 03/15] firmware: arm_scmi: Add support for type handling in common functions Cristian Marussi 2021-07-05 14:49 ` Cristian Marussi 2021-07-05 14:49 ` [PATCH v5 04/15] firmware: arm_scmi: Remove scmi_dump_header_dbg() helper Cristian Marussi 2021-07-05 14:49 ` Cristian Marussi 2021-07-05 14:49 ` [PATCH v5 05/15] firmware: arm_scmi: Add transport optional init/exit support Cristian Marussi 2021-07-05 14:49 ` Cristian Marussi 2021-07-05 14:49 ` [PATCH v5 06/15] firmware: arm_scmi: Introduce monotonically increasing tokens Cristian Marussi 2021-07-05 14:49 ` Cristian Marussi 2021-07-05 14:49 ` [PATCH v5 07/15] firmware: arm_scmi: Handle concurrent and out-of-order messages Cristian Marussi 2021-07-05 14:49 ` Cristian Marussi 2021-07-05 14:49 ` [PATCH v5 08/15] firmware: arm_scmi: Introduce optional support for delegated xfers Cristian Marussi 2021-07-05 14:49 ` Cristian Marussi 2021-07-06 14:18 ` Cristian Marussi 2021-07-06 14:18 ` Cristian Marussi 2021-07-05 14:49 ` [PATCH v5 09/15] firmware: arm_scmi: Make SCMI transports configurable Cristian Marussi 2021-07-05 14:49 ` Cristian Marussi 2021-07-05 14:49 ` [PATCH v5 10/15] firmware: arm_scmi: Make shmem support optional for transports Cristian Marussi 2021-07-05 14:49 ` Cristian Marussi 2021-07-05 14:49 ` [PATCH v5 11/15] firmware: arm_scmi: Add method to override max message number Cristian Marussi 2021-07-05 14:49 ` Cristian Marussi 2021-07-05 14:49 ` [PATCH v5 12/15] firmware: arm_scmi: Add message passing abstractions for transports Cristian Marussi 2021-07-05 14:49 ` Cristian Marussi 2021-07-05 14:49 ` Cristian Marussi [this message] 2021-07-05 14:49 ` [PATCH v5 13/15] firmware: arm_scmi: Add optional link_supplier() transport op Cristian Marussi 2021-07-05 14:49 ` [PATCH v5 14/15] dt-bindings: arm: Add virtio transport for SCMI Cristian Marussi 2021-07-05 14:49 ` Cristian Marussi 2021-07-05 14:49 ` [PATCH v5 15/15] firmware: arm_scmi: Add virtio transport Cristian Marussi 2021-07-05 14:49 ` Cristian Marussi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210705144914.35094-14-cristian.marussi@arm.com \ --to=cristian.marussi@arm.com \ --cc=Andriy.Tryshnivskyy@opensynergy.com \ --cc=Jonathan.Cameron@Huawei.com \ --cc=Vasyl.Vavrychuk@opensynergy.com \ --cc=alex.bennee@linaro.org \ --cc=anton.yakovlev@opensynergy.com \ --cc=etienne.carriere@linaro.org \ --cc=f.fainelli@gmail.com \ --cc=igor.skalkin@opensynergy.com \ --cc=james.quinlan@broadcom.com \ --cc=jean-philippe@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mikhail.golubev@opensynergy.com \ --cc=peter.hilber@opensynergy.com \ --cc=souvik.chakravarty@arm.com \ --cc=sudeep.holla@arm.com \ --cc=vincent.guittot@linaro.org \ --cc=virtio-dev@lists.oasis-open.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.