From: Mark Brown <broonie@kernel.org>
To: "Péter Ujfalusi" <peter.ujfalusi@gmail.com>
Cc: tony@atomide.com, alsa-devel@alsa-project.org,
lgirdwood@gmail.com, linux-omap@vger.kernel.org,
hns@goldelico.com
Subject: Re: [PATCH 1/5] ASoC: ti: davinci-mcasp: Fix DIT mode support
Date: Mon, 5 Jul 2021 16:50:32 +0100 [thread overview]
Message-ID: <20210705155032.GB4574@sirena.org.uk> (raw)
In-Reply-To: <4b530480-bcd6-08cc-b8d6-7e57d0a823ce@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 321 bytes --]
On Mon, Jul 05, 2021 at 05:58:04PM +0300, Péter Ujfalusi wrote:
> On 04/07/2021 18:04, Peter Ujfalusi wrote:
> > + u8 slots = mcasp->op_mode == DAVINCI_MCASP_DIT_MODE ? 384 : mcasp->tdm_slots;
> This is wrong.
> 384 will not fit to u8...
> I wonder why I don't saw this...
Or the compiler for that matter...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: "Péter Ujfalusi" <peter.ujfalusi@gmail.com>
Cc: tony@atomide.com, hns@goldelico.com, alsa-devel@alsa-project.org,
linux-omap@vger.kernel.org, lgirdwood@gmail.com
Subject: Re: [PATCH 1/5] ASoC: ti: davinci-mcasp: Fix DIT mode support
Date: Mon, 5 Jul 2021 16:50:32 +0100 [thread overview]
Message-ID: <20210705155032.GB4574@sirena.org.uk> (raw)
In-Reply-To: <4b530480-bcd6-08cc-b8d6-7e57d0a823ce@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 321 bytes --]
On Mon, Jul 05, 2021 at 05:58:04PM +0300, Péter Ujfalusi wrote:
> On 04/07/2021 18:04, Peter Ujfalusi wrote:
> > + u8 slots = mcasp->op_mode == DAVINCI_MCASP_DIT_MODE ? 384 : mcasp->tdm_slots;
> This is wrong.
> 384 will not fit to u8...
> I wonder why I don't saw this...
Or the compiler for that matter...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-07-05 15:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-04 15:04 [PATCH 0/5] ASoC: ti: davinci-mcasp: Fix the DIT mode and OMAP4 support Peter Ujfalusi
2021-07-04 15:04 ` Peter Ujfalusi
2021-07-04 15:04 ` [PATCH 1/5] ASoC: ti: davinci-mcasp: Fix DIT mode support Peter Ujfalusi
2021-07-04 15:04 ` Peter Ujfalusi
2021-07-05 14:38 ` kernel test robot
2021-07-05 14:58 ` Péter Ujfalusi
2021-07-05 14:58 ` Péter Ujfalusi
2021-07-05 15:50 ` Mark Brown [this message]
2021-07-05 15:50 ` Mark Brown
2021-07-04 15:04 ` [PATCH 2/5] ASoC: dt-bindings: davinci-mcasp: Add compatible string for OMAP4 Peter Ujfalusi
2021-07-04 15:04 ` Peter Ujfalusi
2021-07-04 15:04 ` [PATCH 3/5] ASoC: ti: davinci-mcasp: Add support for the OMAP4 version of McASP Peter Ujfalusi
2021-07-04 15:04 ` Peter Ujfalusi
2021-07-04 15:04 ` [PATCH 4/5] ARM: dts: omap4-l4-abe: Correct sidle modes for McASP Peter Ujfalusi
2021-07-04 15:04 ` Peter Ujfalusi
2021-07-04 15:04 ` [PATCH 5/5] ARM: dts: omap4-l4-abe: Add McASP configuration Peter Ujfalusi
2021-07-04 15:04 ` Peter Ujfalusi
2021-07-05 13:32 ` [PATCH 0/5] ASoC: ti: davinci-mcasp: Fix the DIT mode and OMAP4 support H. Nikolaus Schaller
2021-07-05 13:32 ` H. Nikolaus Schaller
2021-07-05 14:10 ` Péter Ujfalusi
2021-07-05 14:10 ` Péter Ujfalusi
2021-07-05 15:33 ` H. Nikolaus Schaller
2021-07-05 15:33 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210705155032.GB4574@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=hns@goldelico.com \
--cc=lgirdwood@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.