* [PATCH 1/2] arm: snapdragon: Use correct GICC register on APQ8016
@ 2021-06-20 2:34 Sheep Sun
2021-06-20 2:34 ` [PATCH 2/2] arm: snapdragon: Fix typo in clk_bcr_update() Sheep Sun
2021-07-06 22:50 ` [PATCH 1/2] arm: snapdragon: Use correct GICC register on APQ8016 Tom Rini
0 siblings, 2 replies; 4+ messages in thread
From: Sheep Sun @ 2021-06-20 2:34 UTC (permalink / raw)
To: u-boot; +Cc: Sheep Sun, Mateusz Kulikowski, Ramon Fried, Tom Rini
The GICC register used by u-boot is 0x0a20c000, which is actually a GICC
for WCNSS, the WLAN processor. U-boot runs on the Application Processor,
therefore it should use APCS GICC instead. Hence, correct it with APCS GICC
register address.
Signed-off-by: Sheep Sun <sunxiaoyang2003@gmail.com>
---
arch/arm/mach-snapdragon/include/mach/sysmap-apq8016.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-snapdragon/include/mach/sysmap-apq8016.h b/arch/arm/mach-snapdragon/include/mach/sysmap-apq8016.h
index 520e2e6bd7..d9a3b1af98 100644
--- a/arch/arm/mach-snapdragon/include/mach/sysmap-apq8016.h
+++ b/arch/arm/mach-snapdragon/include/mach/sysmap-apq8016.h
@@ -8,7 +8,7 @@
#define _MACH_SYSMAP_APQ8016_H
#define GICD_BASE (0x0b000000)
-#define GICC_BASE (0x0a20c000)
+#define GICC_BASE (0x0b002000)
/* Clocks: (from CLK_CTL_BASE) */
#define GPLL0_STATUS (0x2101C)
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] arm: snapdragon: Fix typo in clk_bcr_update()
2021-06-20 2:34 [PATCH 1/2] arm: snapdragon: Use correct GICC register on APQ8016 Sheep Sun
@ 2021-06-20 2:34 ` Sheep Sun
2021-07-06 22:50 ` Tom Rini
2021-07-06 22:50 ` [PATCH 1/2] arm: snapdragon: Use correct GICC register on APQ8016 Tom Rini
1 sibling, 1 reply; 4+ messages in thread
From: Sheep Sun @ 2021-06-20 2:34 UTC (permalink / raw)
To: u-boot; +Cc: Sheep Sun, Mateusz Kulikowski, Ramon Fried, Tom Rini
Fix typo in clock-snapdragon.c
Signed-off-by: Sheep Sun <sunxiaoyang2003@gmail.com>
---
arch/arm/mach-snapdragon/clock-snapdragon.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-snapdragon/clock-snapdragon.c b/arch/arm/mach-snapdragon/clock-snapdragon.c
index fbe0b5212f..2b76371718 100644
--- a/arch/arm/mach-snapdragon/clock-snapdragon.c
+++ b/arch/arm/mach-snapdragon/clock-snapdragon.c
@@ -56,15 +56,15 @@ void clk_enable_vote_clk(phys_addr_t base, const struct vote_clk *vclk)
} while ((val != BRANCH_ON_VAL) && (val != BRANCH_NOC_FSM_ON_VAL));
}
-#define APPS_CMD_RGCR_UPDATE BIT(0)
+#define APPS_CMD_RCGR_UPDATE BIT(0)
-/* Update clock command via CMD_RGCR */
-void clk_bcr_update(phys_addr_t apps_cmd_rgcr)
+/* Update clock command via CMD_RCGR */
+void clk_bcr_update(phys_addr_t apps_cmd_rcgr)
{
- setbits_le32(apps_cmd_rgcr, APPS_CMD_RGCR_UPDATE);
+ setbits_le32(apps_cmd_rcgr, APPS_CMD_RCGR_UPDATE);
/* Wait for frequency to be updated. */
- while (readl(apps_cmd_rgcr) & APPS_CMD_RGCR_UPDATE)
+ while (readl(apps_cmd_rcgr) & APPS_CMD_RCGR_UPDATE)
;
}
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] arm: snapdragon: Use correct GICC register on APQ8016
2021-06-20 2:34 [PATCH 1/2] arm: snapdragon: Use correct GICC register on APQ8016 Sheep Sun
2021-06-20 2:34 ` [PATCH 2/2] arm: snapdragon: Fix typo in clk_bcr_update() Sheep Sun
@ 2021-07-06 22:50 ` Tom Rini
1 sibling, 0 replies; 4+ messages in thread
From: Tom Rini @ 2021-07-06 22:50 UTC (permalink / raw)
To: Sheep Sun; +Cc: u-boot, Mateusz Kulikowski, Ramon Fried
[-- Attachment #1: Type: text/plain, Size: 423 bytes --]
On Sun, Jun 20, 2021 at 10:34:34AM +0800, Sheep Sun wrote:
> The GICC register used by u-boot is 0x0a20c000, which is actually a GICC
> for WCNSS, the WLAN processor. U-boot runs on the Application Processor,
> therefore it should use APCS GICC instead. Hence, correct it with APCS GICC
> register address.
>
> Signed-off-by: Sheep Sun <sunxiaoyang2003@gmail.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] arm: snapdragon: Fix typo in clk_bcr_update()
2021-06-20 2:34 ` [PATCH 2/2] arm: snapdragon: Fix typo in clk_bcr_update() Sheep Sun
@ 2021-07-06 22:50 ` Tom Rini
0 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2021-07-06 22:50 UTC (permalink / raw)
To: Sheep Sun; +Cc: u-boot, Mateusz Kulikowski, Ramon Fried
[-- Attachment #1: Type: text/plain, Size: 205 bytes --]
On Sun, Jun 20, 2021 at 10:34:35AM +0800, Sheep Sun wrote:
> Fix typo in clock-snapdragon.c
>
> Signed-off-by: Sheep Sun <sunxiaoyang2003@gmail.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-06 22:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-20 2:34 [PATCH 1/2] arm: snapdragon: Use correct GICC register on APQ8016 Sheep Sun
2021-06-20 2:34 ` [PATCH 2/2] arm: snapdragon: Fix typo in clk_bcr_update() Sheep Sun
2021-07-06 22:50 ` Tom Rini
2021-07-06 22:50 ` [PATCH 1/2] arm: snapdragon: Use correct GICC register on APQ8016 Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.