From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org,
Callum Sinclair <callum.sinclair@alliedtelesis.co.nz>,
dsahern@kernel.org, nikolay@nvidia.com
Cc: lkp@intel.com, kbuild-all@lists.01.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linus.luessing@c0d3.blue,
Callum Sinclair <callum.sinclair@alliedtelesis.co.nz>
Subject: [kbuild] Re: [PATCH] net: Allow any address multicast join for IP sockets
Date: Wed, 7 Jul 2021 10:26:35 +0300 [thread overview]
Message-ID: <202107070208.yXD584kP-lkp@intel.com> (raw)
In-Reply-To: <20210706011548.2201-2-callum.sinclair@alliedtelesis.co.nz>
Hi Callum,
url: https://github.com/0day-ci/linux/commits/Callum-Sinclair/net-Allow-any-address-multicast-join-for-IP-sockets/20210706-091734
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 79160a603bdb51916226caf4a6616cc4e1c58a58
compiler: m68k-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> net/ipv4/igmp.c:1432:9: warning: Uninitialized variable: im [uninitvar]
return im;
^
vim +1432 net/ipv4/igmp.c
b05967ad8bde7d Callum Sinclair 2021-07-06 1416 static struct ip_mc_list *ip_mc_hash_lookup(struct ip_mc_list __rcu **mc_hash,
b05967ad8bde7d Callum Sinclair 2021-07-06 1417 __be32 mc_addr)
b05967ad8bde7d Callum Sinclair 2021-07-06 1418 {
b05967ad8bde7d Callum Sinclair 2021-07-06 1419 struct ip_mc_list *im;
b05967ad8bde7d Callum Sinclair 2021-07-06 1420 u32 hash;
b05967ad8bde7d Callum Sinclair 2021-07-06 1421
b05967ad8bde7d Callum Sinclair 2021-07-06 1422 if (mc_hash) {
b05967ad8bde7d Callum Sinclair 2021-07-06 1423 hash = hash_32((__force u32)mc_addr, MC_HASH_SZ_LOG);
b05967ad8bde7d Callum Sinclair 2021-07-06 1424 for (im = rcu_dereference(mc_hash[hash]);
b05967ad8bde7d Callum Sinclair 2021-07-06 1425 im != NULL;
b05967ad8bde7d Callum Sinclair 2021-07-06 1426 im = rcu_dereference(im->next_hash)) {
b05967ad8bde7d Callum Sinclair 2021-07-06 1427 if (im->multiaddr == mc_addr)
b05967ad8bde7d Callum Sinclair 2021-07-06 1428 break;
b05967ad8bde7d Callum Sinclair 2021-07-06 1429 }
b05967ad8bde7d Callum Sinclair 2021-07-06 1430 }
"im" not intialized on else path.
b05967ad8bde7d Callum Sinclair 2021-07-06 1431
b05967ad8bde7d Callum Sinclair 2021-07-06 @1432 return im;
b05967ad8bde7d Callum Sinclair 2021-07-06 1433 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH] net: Allow any address multicast join for IP sockets
Date: Wed, 07 Jul 2021 03:01:49 +0800 [thread overview]
Message-ID: <202107070208.yXD584kP-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 3005 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210706011548.2201-2-callum.sinclair@alliedtelesis.co.nz>
References: <20210706011548.2201-2-callum.sinclair@alliedtelesis.co.nz>
TO: Callum Sinclair <callum.sinclair@alliedtelesis.co.nz>
TO: dsahern(a)kernel.org
TO: nikolay(a)nvidia.com
CC: netdev(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
CC: linus.luessing(a)c0d3.blue
CC: Callum Sinclair <callum.sinclair@alliedtelesis.co.nz>
Hi Callum,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.13 next-20210706]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Callum-Sinclair/net-Allow-any-address-multicast-join-for-IP-sockets/20210706-091734
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 79160a603bdb51916226caf4a6616cc4e1c58a58
:::::: branch date: 18 hours ago
:::::: commit date: 18 hours ago
compiler: m68k-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> net/ipv4/igmp.c:1432:9: warning: Uninitialized variable: im [uninitvar]
return im;
^
vim +1432 net/ipv4/igmp.c
e9897071350bd9 Eric Dumazet 2013-06-07 1415
b05967ad8bde7d Callum Sinclair 2021-07-06 1416 static struct ip_mc_list *ip_mc_hash_lookup(struct ip_mc_list __rcu **mc_hash,
b05967ad8bde7d Callum Sinclair 2021-07-06 1417 __be32 mc_addr)
b05967ad8bde7d Callum Sinclair 2021-07-06 1418 {
b05967ad8bde7d Callum Sinclair 2021-07-06 1419 struct ip_mc_list *im;
b05967ad8bde7d Callum Sinclair 2021-07-06 1420 u32 hash;
b05967ad8bde7d Callum Sinclair 2021-07-06 1421
b05967ad8bde7d Callum Sinclair 2021-07-06 1422 if (mc_hash) {
b05967ad8bde7d Callum Sinclair 2021-07-06 1423 hash = hash_32((__force u32)mc_addr, MC_HASH_SZ_LOG);
b05967ad8bde7d Callum Sinclair 2021-07-06 1424 for (im = rcu_dereference(mc_hash[hash]);
b05967ad8bde7d Callum Sinclair 2021-07-06 1425 im != NULL;
b05967ad8bde7d Callum Sinclair 2021-07-06 1426 im = rcu_dereference(im->next_hash)) {
b05967ad8bde7d Callum Sinclair 2021-07-06 1427 if (im->multiaddr == mc_addr)
b05967ad8bde7d Callum Sinclair 2021-07-06 1428 break;
b05967ad8bde7d Callum Sinclair 2021-07-06 1429 }
b05967ad8bde7d Callum Sinclair 2021-07-06 1430 }
b05967ad8bde7d Callum Sinclair 2021-07-06 1431
b05967ad8bde7d Callum Sinclair 2021-07-06 @1432 return im;
b05967ad8bde7d Callum Sinclair 2021-07-06 1433 }
b05967ad8bde7d Callum Sinclair 2021-07-06 1434
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: [kbuild] Re: [PATCH] net: Allow any address multicast join for IP sockets
Date: Wed, 07 Jul 2021 10:26:35 +0300 [thread overview]
Message-ID: <202107070208.yXD584kP-lkp@intel.com> (raw)
In-Reply-To: <20210706011548.2201-2-callum.sinclair@alliedtelesis.co.nz>
[-- Attachment #1: Type: text/plain, Size: 2243 bytes --]
Hi Callum,
url: https://github.com/0day-ci/linux/commits/Callum-Sinclair/net-Allow-any-address-multicast-join-for-IP-sockets/20210706-091734
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 79160a603bdb51916226caf4a6616cc4e1c58a58
compiler: m68k-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> net/ipv4/igmp.c:1432:9: warning: Uninitialized variable: im [uninitvar]
return im;
^
vim +1432 net/ipv4/igmp.c
b05967ad8bde7d Callum Sinclair 2021-07-06 1416 static struct ip_mc_list *ip_mc_hash_lookup(struct ip_mc_list __rcu **mc_hash,
b05967ad8bde7d Callum Sinclair 2021-07-06 1417 __be32 mc_addr)
b05967ad8bde7d Callum Sinclair 2021-07-06 1418 {
b05967ad8bde7d Callum Sinclair 2021-07-06 1419 struct ip_mc_list *im;
b05967ad8bde7d Callum Sinclair 2021-07-06 1420 u32 hash;
b05967ad8bde7d Callum Sinclair 2021-07-06 1421
b05967ad8bde7d Callum Sinclair 2021-07-06 1422 if (mc_hash) {
b05967ad8bde7d Callum Sinclair 2021-07-06 1423 hash = hash_32((__force u32)mc_addr, MC_HASH_SZ_LOG);
b05967ad8bde7d Callum Sinclair 2021-07-06 1424 for (im = rcu_dereference(mc_hash[hash]);
b05967ad8bde7d Callum Sinclair 2021-07-06 1425 im != NULL;
b05967ad8bde7d Callum Sinclair 2021-07-06 1426 im = rcu_dereference(im->next_hash)) {
b05967ad8bde7d Callum Sinclair 2021-07-06 1427 if (im->multiaddr == mc_addr)
b05967ad8bde7d Callum Sinclair 2021-07-06 1428 break;
b05967ad8bde7d Callum Sinclair 2021-07-06 1429 }
b05967ad8bde7d Callum Sinclair 2021-07-06 1430 }
"im" not intialized on else path.
b05967ad8bde7d Callum Sinclair 2021-07-06 1431
b05967ad8bde7d Callum Sinclair 2021-07-06 @1432 return im;
b05967ad8bde7d Callum Sinclair 2021-07-06 1433 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
next parent reply other threads:[~2021-07-07 7:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 19:01 kernel test robot [this message]
2021-07-07 7:26 ` [kbuild] Re: [PATCH] net: Allow any address multicast join for IP sockets Dan Carpenter
2021-07-07 7:26 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2021-07-06 1:15 Callum Sinclair
2021-07-06 1:15 ` Callum Sinclair
2021-07-06 5:18 ` kernel test robot
2021-07-06 5:18 ` kernel test robot
2021-07-06 13:28 ` Andrew Lunn
2021-07-07 2:00 ` Callum Sinclair
2021-07-07 14:56 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202107070208.yXD584kP-lkp@intel.com \
--to=dan.carpenter@oracle.com \
--cc=callum.sinclair@alliedtelesis.co.nz \
--cc=dsahern@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linus.luessing@c0d3.blue \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.