* [PATCH bpf-next] bpf: runqslower: fixed make install issue
@ 2021-07-07 6:03 Jianlin Lv
2021-07-08 3:16 ` Alexei Starovoitov
0 siblings, 1 reply; 2+ messages in thread
From: Jianlin Lv @ 2021-07-07 6:03 UTC (permalink / raw)
To: bpf
Cc: ast, daniel, andrii, kafai, songliubraving, yhs, john.fastabend,
kpsingh, linux-kernel, netdev, Jianlin.Lv, iecedge
runqslower did not define install target, resulting in an installation
tool/bpf error:
$ make -C tools/bpf/ install
make[1]: Entering directory './tools/bpf/runqslower'
make[1]: *** No rule to make target 'install'. Stop.
Add install target for runqslower.
Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com>
---
tools/bpf/runqslower/Makefile | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/tools/bpf/runqslower/Makefile b/tools/bpf/runqslower/Makefile
index 3818ec511fd2..7dd0ae982459 100644
--- a/tools/bpf/runqslower/Makefile
+++ b/tools/bpf/runqslower/Makefile
@@ -1,6 +1,8 @@
# SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause)
include ../../scripts/Makefile.include
+prefix ?= /usr/local
+
OUTPUT ?= $(abspath .output)/
BPFTOOL_OUTPUT := $(OUTPUT)bpftool/
@@ -31,9 +33,11 @@ MAKEFLAGS += --no-print-directory
submake_extras := feature_display=0
endif
+INSTALL ?= install
+
.DELETE_ON_ERROR:
-.PHONY: all clean runqslower
+.PHONY: all clean runqslower install
all: runqslower
runqslower: $(OUTPUT)/runqslower
@@ -46,6 +50,11 @@ clean:
$(Q)$(RM) $(OUTPUT)runqslower
$(Q)$(RM) -r .output
+install: $(OUTPUT)/runqslower
+ $(call QUIET_INSTALL, runqslower)
+ $(Q)$(INSTALL) -m 0755 -d $(DESTDIR)$(prefix)/sbin
+ $(Q)$(INSTALL) $(OUTPUT)runqslower $(DESTDIR)$(prefix)/sbin/runqslower
+
$(OUTPUT)/runqslower: $(OUTPUT)/runqslower.o $(BPFOBJ)
$(QUIET_LINK)$(CC) $(CFLAGS) $^ -lelf -lz -o $@
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf-next] bpf: runqslower: fixed make install issue
2021-07-07 6:03 [PATCH bpf-next] bpf: runqslower: fixed make install issue Jianlin Lv
@ 2021-07-08 3:16 ` Alexei Starovoitov
0 siblings, 0 replies; 2+ messages in thread
From: Alexei Starovoitov @ 2021-07-08 3:16 UTC (permalink / raw)
To: Jianlin Lv
Cc: bpf, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
KP Singh, LKML, Network Development, iecedge
On Tue, Jul 6, 2021 at 11:03 PM Jianlin Lv <Jianlin.Lv@arm.com> wrote:
>
> runqslower did not define install target, resulting in an installation
> tool/bpf error:
> $ make -C tools/bpf/ install
>
> make[1]: Entering directory './tools/bpf/runqslower'
> make[1]: *** No rule to make target 'install'. Stop.
>
> Add install target for runqslower.
>
> Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com>
Andrii applied a patch that removed install target.
I don't mind whichever way.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-08 3:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-07 6:03 [PATCH bpf-next] bpf: runqslower: fixed make install issue Jianlin Lv
2021-07-08 3:16 ` Alexei Starovoitov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.