From: Xin Ji <xji@analogixsemi.com> To: Robert Foss <robert.foss@linaro.org> Cc: "Rob Herring" <robh+dt@kernel.org>, "David Airlie" <airlied@linux.ie>, "Nicolas Boichat" <drinkcat@google.com>, "Hsin-Yi Wang" <hsinyi@chromium.org>, "Daniel Vetter" <daniel@ffwll.ch>, "Sam Ravnborg" <sam@ravnborg.org>, "Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>, "Maxime Ripard" <mripard@kernel.org>, "Mark Brown" <broonie@kernel.org>, "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, "Bernie Liang" <bliang@analogixsemi.com>, "Sheng Pan" <span@analogixsemi.com>, "Zhen Li" <zhenli@analogixsemi.com>, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 1/4] dt-bindings:drm/bridge:anx7625:add vendor define flags Date: Wed, 7 Jul 2021 15:30:51 +0800 [thread overview] Message-ID: <20210707073051.GA936385@anxtwsw-Precision-3640-Tower> (raw) In-Reply-To: <CAG3jFys6D=-L-Aez4aWuE4nM7qJCtn4wPws3TKxbkRzcAoFR0A@mail.gmail.com> On Thu, Jun 24, 2021 at 01:57:22PM +0200, Robert Foss wrote: > Hey Xin, > > I would like to merge this series now, but this patch needs a review > first. Maybe Laurent/Rob Herring are good candidates. > > > Rob. Hi Rob, I get Laurent/Rob comments before, and explained why we needs these DT properties, so far, I didn't get any response. Hi Rob Herring and Laurent, for the DT property lane0/1-swing, Google engineer has strong demond for them, they don't want to move DP swing adjusting to kernel, thus may cause change the driver code in each project, so config them in DT is a best option. Thanks, Xin > > On Tue, 22 Jun 2021 at 14:31, Xin Ji <xji@analogixsemi.com> wrote: > > > > Add 'bus-type' and 'data-lanes' define for port0. Define DP tx lane0, > > lane1 swing register array define, and audio enable flag. > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > --- > > .../display/bridge/analogix,anx7625.yaml | 57 ++++++++++++++++++- > > 1 file changed, 56 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > index ab48ab2f4240..9e604d19a3d5 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > @@ -43,6 +43,26 @@ properties: > > vdd33-supply: > > description: Regulator that provides the supply 3.3V power. > > > > + analogix,lane0-swing: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + minItems: 1 > > + maxItems: 20 > > + description: > > + an array of swing register setting for DP tx lane0 PHY, please don't > > + add this property, or contact vendor. > > + > > + analogix,lane1-swing: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + minItems: 1 > > + maxItems: 20 > > + description: > > + an array of swing register setting for DP tx lane1 PHY, please don't > > + add this property, or contact vendor. > > + > > + analogix,audio-enable: > > + type: boolean > > + description: let the driver enable audio HDMI codec function or not. > > + > > ports: > > $ref: /schemas/graph.yaml#/properties/ports > > > > @@ -50,13 +70,43 @@ properties: > > port@0: > > $ref: /schemas/graph.yaml#/properties/port > > description: > > - Video port for MIPI DSI input. > > + MIPI DSI/DPI input. > > + > > + properties: > > + endpoint: > > + $ref: /schemas/media/video-interfaces.yaml# > > + type: object > > + additionalProperties: false > > + > > + properties: > > + remote-endpoint: true > > + bus-type: true > > + data-lanes: true > > + > > + required: > > + - remote-endpoint > > + > > + required: > > + - endpoint > > + > > > > port@1: > > $ref: /schemas/graph.yaml#/properties/port > > description: > > Video port for panel or connector. > > > > + properties: > > + endpoint: > > + $ref: /schemas/media/video-interfaces.yaml# > > + type: object > > + additionalProperties: false > > + > > + properties: > > + remote-endpoint: true > > + > > + required: > > + - remote-endpoint > > + > > required: > > - port@0 > > - port@1 > > @@ -87,6 +137,9 @@ examples: > > vdd10-supply = <&pp1000_mipibrdg>; > > vdd18-supply = <&pp1800_mipibrdg>; > > vdd33-supply = <&pp3300_mipibrdg>; > > + analogix,audio-enable; > > + analogix,lane0-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>; > > + analogix,lane1-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>; > > > > ports { > > #address-cells = <1>; > > @@ -96,6 +149,8 @@ examples: > > reg = <0>; > > anx7625_in: endpoint { > > remote-endpoint = <&mipi_dsi>; > > + bus-type = <5>; > > + data-lanes = <0 1 2 3>; > > }; > > }; > > > > -- > > 2.25.1 > >
WARNING: multiple messages have this Message-ID (diff)
From: Xin Ji <xji@analogixsemi.com> To: Robert Foss <robert.foss@linaro.org> Cc: "Nicolas Boichat" <drinkcat@google.com>, "Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>, devicetree@vger.kernel.org, "David Airlie" <airlied@linux.ie>, "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>, "Mark Brown" <broonie@kernel.org>, "Zhen Li" <zhenli@analogixsemi.com>, linux-kernel@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>, dri-devel@lists.freedesktop.org, "Hsin-Yi Wang" <hsinyi@chromium.org>, "Sam Ravnborg" <sam@ravnborg.org>, "Bernie Liang" <bliang@analogixsemi.com>, "Sheng Pan" <span@analogixsemi.com> Subject: Re: [PATCH v9 1/4] dt-bindings:drm/bridge:anx7625:add vendor define flags Date: Wed, 7 Jul 2021 15:30:51 +0800 [thread overview] Message-ID: <20210707073051.GA936385@anxtwsw-Precision-3640-Tower> (raw) In-Reply-To: <CAG3jFys6D=-L-Aez4aWuE4nM7qJCtn4wPws3TKxbkRzcAoFR0A@mail.gmail.com> On Thu, Jun 24, 2021 at 01:57:22PM +0200, Robert Foss wrote: > Hey Xin, > > I would like to merge this series now, but this patch needs a review > first. Maybe Laurent/Rob Herring are good candidates. > > > Rob. Hi Rob, I get Laurent/Rob comments before, and explained why we needs these DT properties, so far, I didn't get any response. Hi Rob Herring and Laurent, for the DT property lane0/1-swing, Google engineer has strong demond for them, they don't want to move DP swing adjusting to kernel, thus may cause change the driver code in each project, so config them in DT is a best option. Thanks, Xin > > On Tue, 22 Jun 2021 at 14:31, Xin Ji <xji@analogixsemi.com> wrote: > > > > Add 'bus-type' and 'data-lanes' define for port0. Define DP tx lane0, > > lane1 swing register array define, and audio enable flag. > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > --- > > .../display/bridge/analogix,anx7625.yaml | 57 ++++++++++++++++++- > > 1 file changed, 56 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > index ab48ab2f4240..9e604d19a3d5 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > @@ -43,6 +43,26 @@ properties: > > vdd33-supply: > > description: Regulator that provides the supply 3.3V power. > > > > + analogix,lane0-swing: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + minItems: 1 > > + maxItems: 20 > > + description: > > + an array of swing register setting for DP tx lane0 PHY, please don't > > + add this property, or contact vendor. > > + > > + analogix,lane1-swing: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + minItems: 1 > > + maxItems: 20 > > + description: > > + an array of swing register setting for DP tx lane1 PHY, please don't > > + add this property, or contact vendor. > > + > > + analogix,audio-enable: > > + type: boolean > > + description: let the driver enable audio HDMI codec function or not. > > + > > ports: > > $ref: /schemas/graph.yaml#/properties/ports > > > > @@ -50,13 +70,43 @@ properties: > > port@0: > > $ref: /schemas/graph.yaml#/properties/port > > description: > > - Video port for MIPI DSI input. > > + MIPI DSI/DPI input. > > + > > + properties: > > + endpoint: > > + $ref: /schemas/media/video-interfaces.yaml# > > + type: object > > + additionalProperties: false > > + > > + properties: > > + remote-endpoint: true > > + bus-type: true > > + data-lanes: true > > + > > + required: > > + - remote-endpoint > > + > > + required: > > + - endpoint > > + > > > > port@1: > > $ref: /schemas/graph.yaml#/properties/port > > description: > > Video port for panel or connector. > > > > + properties: > > + endpoint: > > + $ref: /schemas/media/video-interfaces.yaml# > > + type: object > > + additionalProperties: false > > + > > + properties: > > + remote-endpoint: true > > + > > + required: > > + - remote-endpoint > > + > > required: > > - port@0 > > - port@1 > > @@ -87,6 +137,9 @@ examples: > > vdd10-supply = <&pp1000_mipibrdg>; > > vdd18-supply = <&pp1800_mipibrdg>; > > vdd33-supply = <&pp3300_mipibrdg>; > > + analogix,audio-enable; > > + analogix,lane0-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>; > > + analogix,lane1-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>; > > > > ports { > > #address-cells = <1>; > > @@ -96,6 +149,8 @@ examples: > > reg = <0>; > > anx7625_in: endpoint { > > remote-endpoint = <&mipi_dsi>; > > + bus-type = <5>; > > + data-lanes = <0 1 2 3>; > > }; > > }; > > > > -- > > 2.25.1 > >
next prev parent reply other threads:[~2021-07-07 7:31 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-22 12:30 [PATCH v9 0/4] Add MIPI rx DPI support Xin Ji 2021-06-22 12:30 ` Xin Ji 2021-06-22 12:30 ` Xin Ji 2021-06-22 12:31 ` [PATCH v9 1/4] dt-bindings:drm/bridge:anx7625:add vendor define flags Xin Ji 2021-06-22 12:31 ` Xin Ji [not found] ` <CAG3jFys6D=-L-Aez4aWuE4nM7qJCtn4wPws3TKxbkRzcAoFR0A@mail.gmail.com> 2021-07-07 7:30 ` Xin Ji [this message] 2021-07-07 7:30 ` Xin Ji 2021-07-13 22:10 ` Rob Herring 2021-07-13 22:10 ` Rob Herring 2021-07-16 5:32 ` Xin Ji 2021-07-16 5:32 ` Xin Ji 2021-07-16 6:13 ` Nicolas Boichat 2021-07-16 6:13 ` Nicolas Boichat 2021-07-14 8:32 ` Laurent Pinchart 2021-07-14 8:32 ` Laurent Pinchart 2021-07-16 5:35 ` Xin Ji 2021-07-16 5:35 ` Xin Ji 2021-06-22 12:31 ` [PATCH v9 2/4] drm/bridge: anx7625: fix not correct return value Xin Ji 2021-06-22 12:31 ` Xin Ji 2021-06-22 12:31 ` Xin Ji 2021-06-22 12:32 ` [PATCH v9 3/4] drm/bridge: anx7625: add MIPI DPI input feature Xin Ji 2021-06-22 12:32 ` Xin Ji 2021-06-22 12:32 ` Xin Ji 2021-06-22 12:33 ` [PATCH v9 4/4] drm/bridge: anx7625: add HDMI audio function Xin Ji 2021-06-22 12:33 ` Xin Ji 2021-06-22 12:33 ` Xin Ji
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210707073051.GA936385@anxtwsw-Precision-3640-Tower \ --to=xji@analogixsemi.com \ --cc=airlied@linux.ie \ --cc=bliang@analogixsemi.com \ --cc=broonie@kernel.org \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=drinkcat@google.com \ --cc=hsinyi@chromium.org \ --cc=laurent.pinchart+renesas@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mripard@kernel.org \ --cc=ricardo.canuelo@collabora.com \ --cc=robert.foss@linaro.org \ --cc=robh+dt@kernel.org \ --cc=sam@ravnborg.org \ --cc=span@analogixsemi.com \ --cc=zhenli@analogixsemi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.