From: kernel test robot <lkp@intel.com> To: Christian Borntraeger <borntraeger@de.ibm.com>, peterz@infradead.org Cc: kbuild-all@lists.01.org, borntraeger@de.ibm.com, bristot@redhat.com, bsegall@google.com, dietmar.eggemann@arm.com, joshdon@google.com, juri.lelli@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 1/1] sched/fair: improve yield_to vs fairness Date: Thu, 8 Jul 2021 02:07:59 +0800 [thread overview] Message-ID: <202107080102.8lX8XECK-lkp@intel.com> (raw) In-Reply-To: <20210707123402.13999-2-borntraeger@de.ibm.com> [-- Attachment #1: Type: text/plain, Size: 5601 bytes --] Hi Christian, I love your patch! Perhaps something to improve: [auto build test WARNING on tip/sched/core] [also build test WARNING on v5.13 next-20210707] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Christian-Borntraeger/sched-fair-improve-yield_to-vs-fairness/20210707-213440 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 031e3bd8986fffe31e1ddbf5264cccfe30c9abd7 config: i386-randconfig-s002-20210707 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-341-g8af24329-dirty # https://github.com/0day-ci/linux/commit/75196412f9c36f51144f4c333b2b02d57bb0ebde git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Christian-Borntraeger/sched-fair-improve-yield_to-vs-fairness/20210707-213440 git checkout 75196412f9c36f51144f4c333b2b02d57bb0ebde # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> sparse warnings: (new ones prefixed by >>) kernel/sched/fair.c:830:34: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct sched_entity *se @@ got struct sched_entity [noderef] __rcu * @@ kernel/sched/fair.c:830:34: sparse: expected struct sched_entity *se kernel/sched/fair.c:830:34: sparse: got struct sched_entity [noderef] __rcu * kernel/sched/fair.c:5458:38: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct task_struct *curr @@ got struct task_struct [noderef] __rcu *curr @@ kernel/sched/fair.c:5458:38: sparse: expected struct task_struct *curr kernel/sched/fair.c:5458:38: sparse: got struct task_struct [noderef] __rcu *curr kernel/sched/fair.c:7048:38: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct task_struct *curr @@ got struct task_struct [noderef] __rcu *curr @@ kernel/sched/fair.c:7048:38: sparse: expected struct task_struct *curr kernel/sched/fair.c:7048:38: sparse: got struct task_struct [noderef] __rcu *curr kernel/sched/fair.c:7332:38: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct task_struct *curr @@ got struct task_struct [noderef] __rcu *curr @@ kernel/sched/fair.c:7332:38: sparse: expected struct task_struct *curr kernel/sched/fair.c:7332:38: sparse: got struct task_struct [noderef] __rcu *curr >> kernel/sched/fair.c:7364:40: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct sched_entity *curr @@ got struct sched_entity [noderef] __rcu * @@ kernel/sched/fair.c:7364:40: sparse: expected struct sched_entity *curr kernel/sched/fair.c:7364:40: sparse: got struct sched_entity [noderef] __rcu * kernel/sched/fair.c:5387:35: sparse: sparse: marked inline, but without a definition kernel/sched/fair.c: note: in included file: kernel/sched/sched.h:2011:25: sparse: sparse: incompatible types in comparison expression (different address spaces): kernel/sched/sched.h:2011:25: sparse: struct task_struct [noderef] __rcu * kernel/sched/sched.h:2011:25: sparse: struct task_struct * kernel/sched/sched.h:2169:9: sparse: sparse: incompatible types in comparison expression (different address spaces): kernel/sched/sched.h:2169:9: sparse: struct task_struct [noderef] __rcu * kernel/sched/sched.h:2169:9: sparse: struct task_struct * kernel/sched/sched.h:2011:25: sparse: sparse: incompatible types in comparison expression (different address spaces): kernel/sched/sched.h:2011:25: sparse: struct task_struct [noderef] __rcu * kernel/sched/sched.h:2011:25: sparse: struct task_struct * kernel/sched/sched.h:2011:25: sparse: sparse: incompatible types in comparison expression (different address spaces): kernel/sched/sched.h:2011:25: sparse: struct task_struct [noderef] __rcu * kernel/sched/sched.h:2011:25: sparse: struct task_struct * vim +7364 kernel/sched/fair.c 7360 7361 static bool yield_to_task_fair(struct rq *rq, struct task_struct *p) 7362 { 7363 struct sched_entity *se = &p->se; > 7364 struct sched_entity *curr = &rq->curr->se; 7365 7366 /* throttled hierarchies are not runnable */ 7367 if (!se->on_rq || throttled_hierarchy(cfs_rq_of(se))) 7368 return false; 7369 7370 /* Tell the scheduler that we'd really like pse to run next. */ 7371 set_next_buddy(se); 7372 7373 yield_task_fair(rq); 7374 7375 /* 7376 * This path is special and only called from KVM. In contrast to yield, 7377 * in yield_to we really know that current is spinning and we know 7378 * (s390) or have good heuristics whom are we waiting for. There is 7379 * absolutely no point in continuing the current task, even if this 7380 * means to become unfairer. Let us give the current process some 7381 * "fake" penalty. 7382 */ 7383 curr->vruntime += sched_slice(cfs_rq_of(curr), curr); 7384 7385 return true; 7386 } 7387 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 36153 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH 1/1] sched/fair: improve yield_to vs fairness Date: Thu, 08 Jul 2021 02:07:59 +0800 [thread overview] Message-ID: <202107080102.8lX8XECK-lkp@intel.com> (raw) In-Reply-To: <20210707123402.13999-2-borntraeger@de.ibm.com> [-- Attachment #1: Type: text/plain, Size: 5696 bytes --] Hi Christian, I love your patch! Perhaps something to improve: [auto build test WARNING on tip/sched/core] [also build test WARNING on v5.13 next-20210707] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Christian-Borntraeger/sched-fair-improve-yield_to-vs-fairness/20210707-213440 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 031e3bd8986fffe31e1ddbf5264cccfe30c9abd7 config: i386-randconfig-s002-20210707 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-341-g8af24329-dirty # https://github.com/0day-ci/linux/commit/75196412f9c36f51144f4c333b2b02d57bb0ebde git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Christian-Borntraeger/sched-fair-improve-yield_to-vs-fairness/20210707-213440 git checkout 75196412f9c36f51144f4c333b2b02d57bb0ebde # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> sparse warnings: (new ones prefixed by >>) kernel/sched/fair.c:830:34: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct sched_entity *se @@ got struct sched_entity [noderef] __rcu * @@ kernel/sched/fair.c:830:34: sparse: expected struct sched_entity *se kernel/sched/fair.c:830:34: sparse: got struct sched_entity [noderef] __rcu * kernel/sched/fair.c:5458:38: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct task_struct *curr @@ got struct task_struct [noderef] __rcu *curr @@ kernel/sched/fair.c:5458:38: sparse: expected struct task_struct *curr kernel/sched/fair.c:5458:38: sparse: got struct task_struct [noderef] __rcu *curr kernel/sched/fair.c:7048:38: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct task_struct *curr @@ got struct task_struct [noderef] __rcu *curr @@ kernel/sched/fair.c:7048:38: sparse: expected struct task_struct *curr kernel/sched/fair.c:7048:38: sparse: got struct task_struct [noderef] __rcu *curr kernel/sched/fair.c:7332:38: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct task_struct *curr @@ got struct task_struct [noderef] __rcu *curr @@ kernel/sched/fair.c:7332:38: sparse: expected struct task_struct *curr kernel/sched/fair.c:7332:38: sparse: got struct task_struct [noderef] __rcu *curr >> kernel/sched/fair.c:7364:40: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct sched_entity *curr @@ got struct sched_entity [noderef] __rcu * @@ kernel/sched/fair.c:7364:40: sparse: expected struct sched_entity *curr kernel/sched/fair.c:7364:40: sparse: got struct sched_entity [noderef] __rcu * kernel/sched/fair.c:5387:35: sparse: sparse: marked inline, but without a definition kernel/sched/fair.c: note: in included file: kernel/sched/sched.h:2011:25: sparse: sparse: incompatible types in comparison expression (different address spaces): kernel/sched/sched.h:2011:25: sparse: struct task_struct [noderef] __rcu * kernel/sched/sched.h:2011:25: sparse: struct task_struct * kernel/sched/sched.h:2169:9: sparse: sparse: incompatible types in comparison expression (different address spaces): kernel/sched/sched.h:2169:9: sparse: struct task_struct [noderef] __rcu * kernel/sched/sched.h:2169:9: sparse: struct task_struct * kernel/sched/sched.h:2011:25: sparse: sparse: incompatible types in comparison expression (different address spaces): kernel/sched/sched.h:2011:25: sparse: struct task_struct [noderef] __rcu * kernel/sched/sched.h:2011:25: sparse: struct task_struct * kernel/sched/sched.h:2011:25: sparse: sparse: incompatible types in comparison expression (different address spaces): kernel/sched/sched.h:2011:25: sparse: struct task_struct [noderef] __rcu * kernel/sched/sched.h:2011:25: sparse: struct task_struct * vim +7364 kernel/sched/fair.c 7360 7361 static bool yield_to_task_fair(struct rq *rq, struct task_struct *p) 7362 { 7363 struct sched_entity *se = &p->se; > 7364 struct sched_entity *curr = &rq->curr->se; 7365 7366 /* throttled hierarchies are not runnable */ 7367 if (!se->on_rq || throttled_hierarchy(cfs_rq_of(se))) 7368 return false; 7369 7370 /* Tell the scheduler that we'd really like pse to run next. */ 7371 set_next_buddy(se); 7372 7373 yield_task_fair(rq); 7374 7375 /* 7376 * This path is special and only called from KVM. In contrast to yield, 7377 * in yield_to we really know that current is spinning and we know 7378 * (s390) or have good heuristics whom are we waiting for. There is 7379 * absolutely no point in continuing the current task, even if this 7380 * means to become unfairer. Let us give the current process some 7381 * "fake" penalty. 7382 */ 7383 curr->vruntime += sched_slice(cfs_rq_of(curr), curr); 7384 7385 return true; 7386 } 7387 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 36153 bytes --]
next prev parent reply other threads:[~2021-07-07 18:08 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-12 10:14 [PATCH v2 0/9] sched: Clean up SCHED_DEBUG Peter Zijlstra 2021-04-12 10:14 ` [PATCH v2 1/9] sched/numa: Allow runtime enabling/disabling of NUMA balance without SCHED_DEBUG Peter Zijlstra 2021-04-12 10:14 ` [PATCH v2 2/9] sched: Remove sched_schedstats sysctl out from under SCHED_DEBUG Peter Zijlstra 2021-04-16 15:53 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra 2021-04-12 10:14 ` [PATCH v2 3/9] sched: Dont make LATENCYTOP select SCHED_DEBUG Peter Zijlstra 2021-04-16 15:53 ` [tip: sched/core] sched: Don't " tip-bot2 for Peter Zijlstra 2021-04-12 10:14 ` [PATCH v2 4/9] sched: Move SCHED_DEBUG sysctl to debugfs Peter Zijlstra 2021-04-15 16:29 ` [PATCH] sched/debug: Rename the sched_debug parameter to sched_debug_verbose Peter Zijlstra 2021-04-19 19:26 ` Josh Don 2021-04-16 15:53 ` [tip: sched/core] sched: Move SCHED_DEBUG sysctl to debugfs tip-bot2 for Peter Zijlstra 2021-04-27 14:59 ` Christian Borntraeger 2021-04-27 15:09 ` Steven Rostedt 2021-04-27 15:17 ` Christian Borntraeger 2021-04-28 8:47 ` Peter Zijlstra 2021-04-28 8:46 ` Peter Zijlstra 2021-04-28 8:54 ` Christian Borntraeger 2021-04-28 8:58 ` Christian Borntraeger 2021-04-28 9:25 ` Peter Zijlstra 2021-04-28 9:31 ` Christian Borntraeger 2021-04-28 9:42 ` Christian Borntraeger 2021-04-28 12:38 ` Peter Zijlstra 2021-04-28 14:49 ` Christian Borntraeger 2021-07-07 12:34 ` [PATCH 0/1] Improve yield (was: sched: Move SCHED_DEBUG sysctl to debugfs) Christian Borntraeger 2021-07-07 12:34 ` [PATCH 1/1] sched/fair: improve yield_to vs fairness Christian Borntraeger 2021-07-07 18:07 ` kernel test robot [this message] 2021-07-07 18:07 ` kernel test robot 2021-07-23 9:35 ` Mel Gorman 2021-07-23 12:36 ` Christian Borntraeger 2021-07-23 16:21 ` Mel Gorman 2021-07-26 18:41 ` Christian Borntraeger 2021-07-26 19:32 ` Mel Gorman 2021-07-27 6:59 ` Christian Borntraeger 2021-07-27 18:57 ` Benjamin Segall 2021-07-28 16:23 ` Christian Borntraeger 2021-08-10 8:49 ` Vincent Guittot 2021-07-27 13:29 ` Peter Zijlstra 2021-07-27 13:33 ` Peter Zijlstra 2021-07-27 14:31 ` Mel Gorman 2021-04-12 10:14 ` [PATCH v2 5/9] sched,preempt: Move preempt_dynamic to debug.c Peter Zijlstra 2021-04-16 15:53 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra 2021-04-12 10:14 ` [PATCH v2 6/9] debugfs: Implement debugfs_create_str() Peter Zijlstra 2021-04-16 15:53 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra 2021-04-12 10:14 ` [PATCH v2 7/9] sched,debug: Convert sysctl sched_domains to debugfs Peter Zijlstra 2021-04-13 14:55 ` Valentin Schneider 2021-04-15 9:06 ` Peter Zijlstra 2021-04-15 12:16 ` Dietmar Eggemann 2021-04-15 12:34 ` Valentin Schneider 2021-04-15 13:02 ` Peter Zijlstra 2021-04-12 10:14 ` [PATCH v2 8/9] sched: Move /proc/sched_debug " Peter Zijlstra 2021-04-16 15:53 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra 2021-04-12 10:14 ` [PATCH v2 9/9] sched,fair: Alternative sched_slice() Peter Zijlstra 2021-04-12 10:26 ` Peter Zijlstra 2021-04-16 15:53 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202107080102.8lX8XECK-lkp@intel.com \ --to=lkp@intel.com \ --cc=borntraeger@de.ibm.com \ --cc=bristot@redhat.com \ --cc=bsegall@google.com \ --cc=dietmar.eggemann@arm.com \ --cc=joshdon@google.com \ --cc=juri.lelli@redhat.com \ --cc=kbuild-all@lists.01.org \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=peterz@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.