All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pulseaudio: Drop pulseaudio-conf
@ 2021-07-08 13:33 Marek Vasut
  0 siblings, 0 replies; only message in thread
From: Marek Vasut @ 2021-07-08 13:33 UTC (permalink / raw)
  To: openembedded-core; +Cc: ch, Marek Vasut, Tanu Kaskinen, Richard Purdie

The pulseaudio.inc currently contains these two assignments:
  FILES_${PN}-conf = "${sysconfdir}"
  FILES_${PN}-server = "... ${sysconfdir} ..."
This results in pulseaudio-server shipping the configuration
in /etc/pulse/ , and based on CONFFILES_${PN}-server and co.,
this is how it was intended to work.

However, that also means FILES_${PN}-conf is not useful. In fact,
FILES_${PN}-conf is likely meant for MACHINE specific configuration,
which would better be packaged in separate recipe like e.g. systemd
does in systemd-conf_%.bb . Better yet, such pulseaudio-conf_%.bb
could ship MACHINE specific configuration overrides, which according
to pulse-daemon.conf(5) are picked from /etc/pulse/daemon.conf.d ,
while pulseaudio-server would ship the default configuration files.

Remove FILES_${PN}-conf .

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Tanu Kaskinen <tanuk@iki.fi>
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-multimedia/pulseaudio/pulseaudio.inc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
index 005cb36b8e..2c9e8167c4 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
@@ -183,7 +183,6 @@ FILES_libpulse-simple = "${libdir}/libpulse-simple.so.*"
 FILES_libpulse-mainloop-glib = "${libdir}/libpulse-mainloop-glib.so.*"
 
 FILES_${PN}-dev += "${libdir}/pulse-${PV}/modules/*.la ${datadir}/vala ${libdir}/cmake"   
-FILES_${PN}-conf = "${sysconfdir}"
 FILES_${PN}-bin += "${sysconfdir}/default/volatiles/04_pulse"
 FILES_${PN}-pa-info = "${bindir}/pa-info"
 FILES_${PN}-server = "${bindir}/pulseaudio ${bindir}/start-* ${sysconfdir} ${bindir}/pactl */udev/rules.d/*.rules */*/udev/rules.d/*.rules ${systemd_user_unitdir}/*"
-- 
2.30.2


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2021-07-08 13:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-08 13:33 [PATCH] pulseaudio: Drop pulseaudio-conf Marek Vasut

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.