From: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: sean@mess.org, mchehab@kernel.org, robh+dt@kernel.org,
khilman@baylibre.com, Neil Armstrong <narmstrong@baylibre.com>,
jbrunet@baylibre.com, linux-media <linux-media@vger.kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, rockosov@gmail.com
Subject: Re: [PATCH v2 1/2] media: rc: meson-irblaster: document device tree bindings
Date: Thu, 8 Jul 2021 16:20:51 +0300 [thread overview]
Message-ID: <20210708162051.13953369@192.168.1.3> (raw)
In-Reply-To: <CAFBinCDgQHA1vmunNBdER0BfiKt8XYZ+-VBs3c21+S3bYP7GZQ@mail.gmail.com>
Hi Martin,
On Thu, 8 Jul 2021 15:09:30 +0200
Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> Hi Viktor,
>
> On Wed, Jul 7, 2021 at 4:13 PM Viktor Prutyanov
> <viktor.prutyanov@phystech.edu> wrote:
> >
> > This patch adds binding documentation for the IR transmitter
> > available in Amlogic Meson SoCs.
> >
> > Signed-off-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
> > ---
> > changes in v2:
> > - compatible = "amlogic,meson-g12a-irblaster" added
> > - clocks, clock-names and mod-clock updated
> thanks for updating this patch with my feedback!
>
> [...]
> > + mod-clock:
> > + maxItems: 1
> in the change-log for this patch you mentioned that mod-clock is
> updated as well I think that mod-clock (as a whole property) should
> only be added if it's an external input to the IR blaster IP block
There are 2 clocks connected to blaster module, and mod-clock is just a
selector between them. Meson IR blaster driver should choose one of the
modulation clocks. If not through a property, then how to do it?
>
>
> Best regards,
> Martin
Best regards,
Viktor
WARNING: multiple messages have this Message-ID (diff)
From: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: sean@mess.org, mchehab@kernel.org, robh+dt@kernel.org,
khilman@baylibre.com, Neil Armstrong <narmstrong@baylibre.com>,
jbrunet@baylibre.com, linux-media <linux-media@vger.kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, rockosov@gmail.com
Subject: Re: [PATCH v2 1/2] media: rc: meson-irblaster: document device tree bindings
Date: Thu, 8 Jul 2021 16:20:51 +0300 [thread overview]
Message-ID: <20210708162051.13953369@192.168.1.3> (raw)
In-Reply-To: <CAFBinCDgQHA1vmunNBdER0BfiKt8XYZ+-VBs3c21+S3bYP7GZQ@mail.gmail.com>
Hi Martin,
On Thu, 8 Jul 2021 15:09:30 +0200
Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> Hi Viktor,
>
> On Wed, Jul 7, 2021 at 4:13 PM Viktor Prutyanov
> <viktor.prutyanov@phystech.edu> wrote:
> >
> > This patch adds binding documentation for the IR transmitter
> > available in Amlogic Meson SoCs.
> >
> > Signed-off-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
> > ---
> > changes in v2:
> > - compatible = "amlogic,meson-g12a-irblaster" added
> > - clocks, clock-names and mod-clock updated
> thanks for updating this patch with my feedback!
>
> [...]
> > + mod-clock:
> > + maxItems: 1
> in the change-log for this patch you mentioned that mod-clock is
> updated as well I think that mod-clock (as a whole property) should
> only be added if it's an external input to the IR blaster IP block
There are 2 clocks connected to blaster module, and mod-clock is just a
selector between them. Meson IR blaster driver should choose one of the
modulation clocks. If not through a property, then how to do it?
>
>
> Best regards,
> Martin
Best regards,
Viktor
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: sean@mess.org, mchehab@kernel.org, robh+dt@kernel.org,
khilman@baylibre.com, Neil Armstrong <narmstrong@baylibre.com>,
jbrunet@baylibre.com, linux-media <linux-media@vger.kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, rockosov@gmail.com
Subject: Re: [PATCH v2 1/2] media: rc: meson-irblaster: document device tree bindings
Date: Thu, 8 Jul 2021 16:20:51 +0300 [thread overview]
Message-ID: <20210708162051.13953369@192.168.1.3> (raw)
In-Reply-To: <CAFBinCDgQHA1vmunNBdER0BfiKt8XYZ+-VBs3c21+S3bYP7GZQ@mail.gmail.com>
Hi Martin,
On Thu, 8 Jul 2021 15:09:30 +0200
Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> Hi Viktor,
>
> On Wed, Jul 7, 2021 at 4:13 PM Viktor Prutyanov
> <viktor.prutyanov@phystech.edu> wrote:
> >
> > This patch adds binding documentation for the IR transmitter
> > available in Amlogic Meson SoCs.
> >
> > Signed-off-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
> > ---
> > changes in v2:
> > - compatible = "amlogic,meson-g12a-irblaster" added
> > - clocks, clock-names and mod-clock updated
> thanks for updating this patch with my feedback!
>
> [...]
> > + mod-clock:
> > + maxItems: 1
> in the change-log for this patch you mentioned that mod-clock is
> updated as well I think that mod-clock (as a whole property) should
> only be added if it's an external input to the IR blaster IP block
There are 2 clocks connected to blaster module, and mod-clock is just a
selector between them. Meson IR blaster driver should choose one of the
modulation clocks. If not through a property, then how to do it?
>
>
> Best regards,
> Martin
Best regards,
Viktor
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2021-07-08 13:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 14:13 [PATCH v2 0/2] media: rc: add support for Amlogic Meson IR blaster Viktor Prutyanov
2021-07-07 14:13 ` Viktor Prutyanov
2021-07-07 14:13 ` Viktor Prutyanov
2021-07-07 14:13 ` [PATCH v2 1/2] media: rc: meson-irblaster: document device tree bindings Viktor Prutyanov
2021-07-07 14:13 ` Viktor Prutyanov
2021-07-07 14:13 ` Viktor Prutyanov
2021-07-08 13:09 ` Martin Blumenstingl
2021-07-08 13:09 ` Martin Blumenstingl
2021-07-08 13:09 ` Martin Blumenstingl
2021-07-08 13:20 ` Viktor Prutyanov [this message]
2021-07-08 13:20 ` Viktor Prutyanov
2021-07-08 13:20 ` Viktor Prutyanov
2021-07-08 13:57 ` Martin Blumenstingl
2021-07-08 13:57 ` Martin Blumenstingl
2021-07-08 13:57 ` Martin Blumenstingl
2021-07-07 14:13 ` [PATCH v2 2/2] media: rc: introduce Meson IR blaster driver Viktor Prutyanov
2021-07-07 14:13 ` Viktor Prutyanov
2021-07-07 14:13 ` Viktor Prutyanov
2021-07-07 14:29 ` Neil Armstrong
2021-07-07 14:29 ` Neil Armstrong
2021-07-07 14:29 ` Neil Armstrong
2021-07-07 15:11 ` Viktor Prutyanov
2021-07-07 15:11 ` Viktor Prutyanov
2021-07-07 15:11 ` Viktor Prutyanov
2021-07-07 17:18 ` [PATCH] fixup! " Viktor Prutyanov
2021-07-07 17:18 ` Viktor Prutyanov
2021-07-07 17:18 ` Viktor Prutyanov
2021-07-07 17:24 ` [PATCH v2 2/2] " kernel test robot
2021-07-07 17:24 ` kernel test robot
2021-07-08 10:16 ` Sean Young
2021-07-08 10:16 ` Sean Young
2021-07-08 10:16 ` Sean Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210708162051.13953369@192.168.1.3 \
--to=viktor.prutyanov@phystech.edu \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mchehab@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=rockosov@gmail.com \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.