* drivers/net/ethernet/mellanox/mlx5/core/main.c:1245 mlx5_init_one() warn: missing error code 'err'
@ 2021-07-08 12:46 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-07-08 12:46 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 5565 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Leon Romanovsky <leonro@nvidia.com>
CC: Saeed Mahameed <saeedm@nvidia.com>
CC: Moshe Shemesh <moshe@nvidia.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: e9f1cbc0c4114880090c7a578117d3b9cf184ad4
commit: 6dea2f7eff9659049f90922283756830364e6278 net/mlx5: Separate probe vs. reload flows
date: 4 months ago
:::::: branch date: 16 hours ago
:::::: commit date: 4 months ago
config: ia64-randconfig-m031-20210707 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/net/ethernet/mellanox/mlx5/core/main.c:1245 mlx5_init_one() warn: missing error code 'err'
Old smatch warnings:
drivers/net/ethernet/mellanox/mlx5/core/main.c:1322 mlx5_load_one() warn: missing error code 'err'
vim +/err +1245 drivers/net/ethernet/mellanox/mlx5/core/main.c
59211bd3b6329c Mohamad Haj Yahia 2016-09-09 1237
6dea2f7eff9659 Leon Romanovsky 2020-11-02 1238 int mlx5_init_one(struct mlx5_core_dev *dev)
a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1239 {
a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1240 int err = 0;
a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1241
a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1242 mutex_lock(&dev->intf_state_mutex);
a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1243 if (test_bit(MLX5_INTERFACE_STATE_UP, &dev->intf_state)) {
a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1244 mlx5_core_warn(dev, "interface is up, NOP\n");
a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 @1245 goto out;
1bde6e301cf621 Eli Cohen 2014-01-14 1246 }
a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1247 /* remove any previous indication of internal error */
a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1248 dev->state = MLX5_DEVICE_STATE_UP;
e126ba97dba9ed Eli Cohen 2013-07-07 1249
6dea2f7eff9659 Leon Romanovsky 2020-11-02 1250 err = mlx5_function_setup(dev, true);
a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1251 if (err)
4f7400d5cbaef6 Shay Drory 2020-05-06 1252 goto err_function;
e126ba97dba9ed Eli Cohen 2013-07-07 1253
a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1254 err = mlx5_init_once(dev);
a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1255 if (err) {
98a8e6fc482d96 Huy Nguyen 2019-03-29 1256 mlx5_core_err(dev, "sw objs init failed\n");
a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1257 goto function_teardown;
a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1258 }
cd23b14b654769 Eli Cohen 2013-07-18 1259
a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1260 err = mlx5_load(dev);
a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1261 if (err)
a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1262 goto err_load;
a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1263
98f91c45769302 Parav Pandit 2020-05-15 1264 set_bit(MLX5_INTERFACE_STATE_UP, &dev->intf_state);
98f91c45769302 Parav Pandit 2020-05-15 1265
a6f3b62386a02c Michael Guralnik 2019-11-20 1266 err = mlx5_devlink_register(priv_to_devlink(dev), dev->device);
a6f3b62386a02c Michael Guralnik 2019-11-20 1267 if (err)
a6f3b62386a02c Michael Guralnik 2019-11-20 1268 goto err_devlink_reg;
a925b5e309c9b9 Leon Romanovsky 2020-10-08 1269
a925b5e309c9b9 Leon Romanovsky 2020-10-08 1270 err = mlx5_register_device(dev);
a925b5e309c9b9 Leon Romanovsky 2020-10-08 1271 if (err)
a925b5e309c9b9 Leon Romanovsky 2020-10-08 1272 goto err_register;
a925b5e309c9b9 Leon Romanovsky 2020-10-08 1273
4162f58b476b24 Parav Pandit 2020-05-01 1274 mutex_unlock(&dev->intf_state_mutex);
4162f58b476b24 Parav Pandit 2020-05-01 1275 return 0;
a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1276
a925b5e309c9b9 Leon Romanovsky 2020-10-08 1277 err_register:
a925b5e309c9b9 Leon Romanovsky 2020-10-08 1278 mlx5_devlink_unregister(priv_to_devlink(dev));
a6f3b62386a02c Michael Guralnik 2019-11-20 1279 err_devlink_reg:
98f91c45769302 Parav Pandit 2020-05-15 1280 clear_bit(MLX5_INTERFACE_STATE_UP, &dev->intf_state);
a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1281 mlx5_unload(dev);
a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1282 err_load:
59211bd3b6329c Mohamad Haj Yahia 2016-09-09 1283 mlx5_cleanup_once(dev);
e161105e58da81 Saeed Mahameed 2019-03-29 1284 function_teardown:
6dea2f7eff9659 Leon Romanovsky 2020-11-02 1285 mlx5_function_teardown(dev, true);
4f7400d5cbaef6 Shay Drory 2020-05-06 1286 err_function:
89d44f0a6c732d Majd Dibbiny 2015-10-14 1287 dev->state = MLX5_DEVICE_STATE_INTERNAL_ERROR;
4162f58b476b24 Parav Pandit 2020-05-01 1288 out:
89d44f0a6c732d Majd Dibbiny 2015-10-14 1289 mutex_unlock(&dev->intf_state_mutex);
e126ba97dba9ed Eli Cohen 2013-07-07 1290 return err;
e126ba97dba9ed Eli Cohen 2013-07-07 1291 }
e126ba97dba9ed Eli Cohen 2013-07-07 1292
:::::: The code at line 1245 was first introduced by commit
:::::: a80d1b68c8b7a06b85434f89d138f0c28f3d27c9 net/mlx5: Break load_one into three stages
:::::: TO: Saeed Mahameed <saeedm@mellanox.com>
:::::: CC: Saeed Mahameed <saeedm@mellanox.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38803 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-07-08 12:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-08 12:46 drivers/net/ethernet/mellanox/mlx5/core/main.c:1245 mlx5_init_one() warn: missing error code 'err' kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.