* [PATCH 1/1] clk: lmk04832: drop redundant fallthrough statements
@ 2021-07-08 21:16 Liam Beguin
2021-07-27 18:52 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Liam Beguin @ 2021-07-08 21:16 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd; +Cc: Liam Beguin, linux-clk, linux-kernel
When the body of a case statement is empty, it is well understood that
it is intentional and explicit fallthrough statements are not required.
Drop them.
Signed-off-by: Liam Beguin <liambeguin@gmail.com>
---
drivers/clk/clk-lmk04832.c | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/clk/clk-lmk04832.c b/drivers/clk/clk-lmk04832.c
index c7a3a029fb1e..8f02c0b88000 100644
--- a/drivers/clk/clk-lmk04832.c
+++ b/drivers/clk/clk-lmk04832.c
@@ -269,23 +269,14 @@ static bool lmk04832_regmap_rd_regs(struct device *dev, unsigned int reg)
{
switch (reg) {
case LMK04832_REG_RST3W ... LMK04832_REG_ID_MASKREV:
- fallthrough;
case LMK04832_REG_ID_VNDR_MSB:
- fallthrough;
case LMK04832_REG_ID_VNDR_LSB:
- fallthrough;
case LMK04832_REG_CLKOUT_CTRL0(0) ... LMK04832_REG_PLL2_DLD_CNT_LSB:
- fallthrough;
case LMK04832_REG_PLL2_LD:
- fallthrough;
case LMK04832_REG_PLL2_PD:
- fallthrough;
case LMK04832_REG_PLL1R_RST:
- fallthrough;
case LMK04832_REG_CLR_PLL_LOST ... LMK04832_REG_RB_DAC_VAL_LSB:
- fallthrough;
case LMK04832_REG_RB_HOLDOVER:
- fallthrough;
case LMK04832_REG_SPI_LOCK:
return true;
default:
@@ -297,27 +288,18 @@ static bool lmk04832_regmap_wr_regs(struct device *dev, unsigned int reg)
{
switch (reg) {
case LMK04832_REG_RST3W:
- fallthrough;
case LMK04832_REG_POWERDOWN:
return true;
case LMK04832_REG_ID_DEV_TYPE ... LMK04832_REG_ID_MASKREV:
- fallthrough;
case LMK04832_REG_ID_VNDR_MSB:
- fallthrough;
case LMK04832_REG_ID_VNDR_LSB:
return false;
case LMK04832_REG_CLKOUT_CTRL0(0) ... LMK04832_REG_PLL2_DLD_CNT_LSB:
- fallthrough;
case LMK04832_REG_PLL2_LD:
- fallthrough;
case LMK04832_REG_PLL2_PD:
- fallthrough;
case LMK04832_REG_PLL1R_RST:
- fallthrough;
case LMK04832_REG_CLR_PLL_LOST ... LMK04832_REG_RB_DAC_VAL_LSB:
- fallthrough;
case LMK04832_REG_RB_HOLDOVER:
- fallthrough;
case LMK04832_REG_SPI_LOCK:
return true;
default:
--
2.30.1.489.g328c10930387
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] clk: lmk04832: drop redundant fallthrough statements
2021-07-08 21:16 [PATCH 1/1] clk: lmk04832: drop redundant fallthrough statements Liam Beguin
@ 2021-07-27 18:52 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2021-07-27 18:52 UTC (permalink / raw)
To: Liam Beguin, Michael Turquette; +Cc: Liam Beguin, linux-clk, linux-kernel
Quoting Liam Beguin (2021-07-08 14:16:45)
> When the body of a case statement is empty, it is well understood that
> it is intentional and explicit fallthrough statements are not required.
> Drop them.
>
> Signed-off-by: Liam Beguin <liambeguin@gmail.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-27 18:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-08 21:16 [PATCH 1/1] clk: lmk04832: drop redundant fallthrough statements Liam Beguin
2021-07-27 18:52 ` Stephen Boyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.