* [PATCH v1] drm/mediatek: add AAL output size configuration
@ 2021-07-09 5:56 ` jason-jh.lin
0 siblings, 0 replies; 4+ messages in thread
From: jason-jh.lin @ 2021-07-09 5:56 UTC (permalink / raw)
To: chunkuang.hu, matthias.bgg
Cc: linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group, fshao, jason-jh.lin,
nancy.lin, singo.chang
To avoid the output height is incorrect, AAL_OUTPUT_SIZE
configuration should be set.
Fixes: 0664d1392c26 ("drm/mediatek: Add AAL engine basic function")
Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
index 75bc00e17fc4..fc608d05f040 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
@@ -34,6 +34,7 @@
#define DISP_AAL_EN 0x0000
#define DISP_AAL_SIZE 0x0030
+#define DISP_AAL_OUTPUT_SIZE 0x04d8
#define DISP_DITHER_EN 0x0000
#define DITHER_EN BIT(0)
@@ -196,7 +197,12 @@ static void mtk_aal_config(struct device *dev, unsigned int w,
{
struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev);
- mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_SIZE);
+ mtk_ddp_write(cmdq_pkt, w << 16 | h,
+ &priv->cmdq_reg, priv->regs,
+ DISP_AAL_SIZE);
+ mtk_ddp_write(cmdq_pkt, w << 16 | h,
+ &priv->cmdq_reg, priv->regs,
+ DISP_AAL_OUTPUT_SIZE);
}
static void mtk_aal_gamma_set(struct device *dev, struct drm_crtc_state *state)
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v1] drm/mediatek: add AAL output size configuration
@ 2021-07-09 5:56 ` jason-jh.lin
0 siblings, 0 replies; 4+ messages in thread
From: jason-jh.lin @ 2021-07-09 5:56 UTC (permalink / raw)
To: chunkuang.hu, matthias.bgg
Cc: linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group, fshao, jason-jh.lin,
nancy.lin, singo.chang
To avoid the output height is incorrect, AAL_OUTPUT_SIZE
configuration should be set.
Fixes: 0664d1392c26 ("drm/mediatek: Add AAL engine basic function")
Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
index 75bc00e17fc4..fc608d05f040 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
@@ -34,6 +34,7 @@
#define DISP_AAL_EN 0x0000
#define DISP_AAL_SIZE 0x0030
+#define DISP_AAL_OUTPUT_SIZE 0x04d8
#define DISP_DITHER_EN 0x0000
#define DITHER_EN BIT(0)
@@ -196,7 +197,12 @@ static void mtk_aal_config(struct device *dev, unsigned int w,
{
struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev);
- mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_SIZE);
+ mtk_ddp_write(cmdq_pkt, w << 16 | h,
+ &priv->cmdq_reg, priv->regs,
+ DISP_AAL_SIZE);
+ mtk_ddp_write(cmdq_pkt, w << 16 | h,
+ &priv->cmdq_reg, priv->regs,
+ DISP_AAL_OUTPUT_SIZE);
}
static void mtk_aal_gamma_set(struct device *dev, struct drm_crtc_state *state)
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v1] drm/mediatek: add AAL output size configuration
2021-07-09 5:56 ` jason-jh.lin
@ 2021-08-10 1:52 ` CK Hu
-1 siblings, 0 replies; 4+ messages in thread
From: CK Hu @ 2021-08-10 1:52 UTC (permalink / raw)
To: jason-jh.lin
Cc: chunkuang.hu, matthias.bgg, linux-arm-kernel, linux-mediatek,
linux-kernel, Project_Global_Chrome_Upstream_Group, fshao,
nancy.lin, singo.chang
Hi, Jason:
On Fri, 2021-07-09 at 13:56 +0800, jason-jh.lin wrote:
> To avoid the output height is incorrect, AAL_OUTPUT_SIZE
> configuration should be set.
>
> Fixes: 0664d1392c26 ("drm/mediatek: Add AAL engine basic function")
>
> Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> index 75bc00e17fc4..fc608d05f040 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> @@ -34,6 +34,7 @@
>
> #define DISP_AAL_EN 0x0000
> #define DISP_AAL_SIZE 0x0030
> +#define DISP_AAL_OUTPUT_SIZE 0x04d8
>
> #define DISP_DITHER_EN 0x0000
> #define DITHER_EN BIT(0)
> @@ -196,7 +197,12 @@ static void mtk_aal_config(struct device *dev, unsigned int w,
> {
> struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev);
>
> - mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_SIZE);
> + mtk_ddp_write(cmdq_pkt, w << 16 | h,
> + &priv->cmdq_reg, priv->regs,
> + DISP_AAL_SIZE);
This modification break one line into multiple line. This is not related
to this patch.
> + mtk_ddp_write(cmdq_pkt, w << 16 | h,
> + &priv->cmdq_reg, priv->regs,
> + DISP_AAL_OUTPUT_SIZE);
One line.
Regards,
CK
> }
>
> static void mtk_aal_gamma_set(struct device *dev, struct drm_crtc_state *state)
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1] drm/mediatek: add AAL output size configuration
@ 2021-08-10 1:52 ` CK Hu
0 siblings, 0 replies; 4+ messages in thread
From: CK Hu @ 2021-08-10 1:52 UTC (permalink / raw)
To: jason-jh.lin
Cc: chunkuang.hu, matthias.bgg, linux-arm-kernel, linux-mediatek,
linux-kernel, Project_Global_Chrome_Upstream_Group, fshao,
nancy.lin, singo.chang
Hi, Jason:
On Fri, 2021-07-09 at 13:56 +0800, jason-jh.lin wrote:
> To avoid the output height is incorrect, AAL_OUTPUT_SIZE
> configuration should be set.
>
> Fixes: 0664d1392c26 ("drm/mediatek: Add AAL engine basic function")
>
> Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> index 75bc00e17fc4..fc608d05f040 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> @@ -34,6 +34,7 @@
>
> #define DISP_AAL_EN 0x0000
> #define DISP_AAL_SIZE 0x0030
> +#define DISP_AAL_OUTPUT_SIZE 0x04d8
>
> #define DISP_DITHER_EN 0x0000
> #define DITHER_EN BIT(0)
> @@ -196,7 +197,12 @@ static void mtk_aal_config(struct device *dev, unsigned int w,
> {
> struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev);
>
> - mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_SIZE);
> + mtk_ddp_write(cmdq_pkt, w << 16 | h,
> + &priv->cmdq_reg, priv->regs,
> + DISP_AAL_SIZE);
This modification break one line into multiple line. This is not related
to this patch.
> + mtk_ddp_write(cmdq_pkt, w << 16 | h,
> + &priv->cmdq_reg, priv->regs,
> + DISP_AAL_OUTPUT_SIZE);
One line.
Regards,
CK
> }
>
> static void mtk_aal_gamma_set(struct device *dev, struct drm_crtc_state *state)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-10 1:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-09 5:56 [PATCH v1] drm/mediatek: add AAL output size configuration jason-jh.lin
2021-07-09 5:56 ` jason-jh.lin
2021-08-10 1:52 ` CK Hu
2021-08-10 1:52 ` CK Hu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.