Re: [PATCH 9/9] irqchip: Add Loongson PCH LPC controller support

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3763 bytes --]

Hi Huacai,

I love your patch! Perhaps something to improve:

[auto build test WARNING on tip/irq/core]
[also build test WARNING on linux/master linus/master v5.13 next-20210708]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Huacai-Chen/irqchip-Add-LoongArch-related-irqchip-drivers/20210706-111309
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 3d2ce675aba7e2425710e23268579a5d76c7e725
config: mips-loongson2k_defconfig (attached as .config)
compiler: mips64el-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/4fbd48146047c7b30465004c71ffe4a711d5c5e8
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Huacai-Chen/irqchip-Add-LoongArch-related-irqchip-drivers/20210706-111309
        git checkout 4fbd48146047c7b30465004c71ffe4a711d5c5e8
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash drivers/irqchip/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/irqchip/irq-loongson-pch-lpc.c:148:13: warning: 'struct acpi_madt_lpc_pic' declared inside parameter list will not be visible outside of this definition or declaration
     148 |      struct acpi_madt_lpc_pic *acpi_pchlpc)
         |             ^~~~~~~~~~~~~~~~~
   drivers/irqchip/irq-loongson-pch-lpc.c:147:23: warning: no previous prototype for 'pch_lpc_acpi_init' [-Wmissing-prototypes]
     147 | struct fwnode_handle *pch_lpc_acpi_init(struct fwnode_handle *parent,
         |                       ^~~~~~~~~~~~~~~~~
   In file included from arch/mips/include/asm/mmiowb.h:5,
                    from include/linux/spinlock.h:61,
                    from include/linux/wait.h:9,
                    from include/linux/pid.h:6,
                    from include/linux/sched.h:14,
                    from include/linux/hardirq.h:9,
                    from include/linux/interrupt.h:11,
                    from drivers/irqchip/irq-loongson-pch-lpc.c:9:
   drivers/irqchip/irq-loongson-pch-lpc.c: In function 'pch_lpc_acpi_init':
   drivers/irqchip/irq-loongson-pch-lpc.c:163:34: error: dereferencing pointer to incomplete type 'struct acpi_madt_lpc_pic'
     163 |  priv->base = ioremap(acpi_pchlpc->address, acpi_pchlpc->size);
         |                                  ^~
   arch/mips/include/asm/io.h:180:16: note: in definition of macro 'ioremap'
     180 |  ioremap_prot((offset), (size), _CACHE_UNCACHED)
         |                ^~~~~~
   drivers/irqchip/irq-loongson-pch-lpc.c:187:20: error: 'GSI_MIN_PCH_IRQ' undeclared (first use in this function)
     187 |  fwspec.param[0] = GSI_MIN_PCH_IRQ + acpi_pchlpc->cascade;
         |                    ^~~~~~~~~~~~~~~
   drivers/irqchip/irq-loongson-pch-lpc.c:187:20: note: each undeclared identifier is reported only once for each function it appears in


vim +148 drivers/irqchip/irq-loongson-pch-lpc.c

   146	
   147	struct fwnode_handle *pch_lpc_acpi_init(struct fwnode_handle *parent,
 > 148						struct acpi_madt_lpc_pic *acpi_pchlpc)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31150 bytes --]