* [PATCH v1] fix vmwgfx compilation error due to a missing include
@ 2021-07-09 18:09 Tong Zhang
2021-07-09 19:57 ` Randy Dunlap
2021-07-09 20:04 ` Dave Airlie
0 siblings, 2 replies; 6+ messages in thread
From: Tong Zhang @ 2021-07-09 18:09 UTC (permalink / raw)
To: VMware Graphics, Roland Scheidegger, Zack Rusin, David Airlie,
Daniel Vetter, dri-devel, linux-kernel
Cc: Tong Zhang
This patch fixes vmwgfx driver compilation error due to a missing include
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function ‘vmw_vram_manager_init’:
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:678:8: error: implicit declaration of function ‘ttm_range_man_init’ [-Werror=implicit-function-declaration]
678 | ret = ttm_range_man_init(&dev_priv->bdev, TTM_PL_VRAM, false,
| ^~~~~~~~~~~~~~~~~~
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function ‘vmw_vram_manager_fini’:
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:690:2: error: implicit declaration of function ‘ttm_range_man_fini’ [-Werror=implicit-function-declaration]
690 | ttm_range_man_fini(&dev_priv->bdev, TTM_PL_VRAM);
| ^~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
---
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
index 6f5ea00973e0..6eb93aa2f311 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
@@ -37,6 +37,7 @@
#include <drm/drm_sysfs.h>
#include <drm/ttm/ttm_bo_driver.h>
#include <drm/ttm/ttm_placement.h>
+#include <drm/ttm/ttm_range_manager.h>
#include <generated/utsrelease.h>
#include "ttm_object.h"
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v1] fix vmwgfx compilation error due to a missing include
2021-07-09 18:09 [PATCH v1] fix vmwgfx compilation error due to a missing include Tong Zhang
@ 2021-07-09 19:57 ` Randy Dunlap
2021-07-09 20:04 ` Dave Airlie
1 sibling, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2021-07-09 19:57 UTC (permalink / raw)
To: Tong Zhang, VMware Graphics, Roland Scheidegger, Zack Rusin,
David Airlie, Daniel Vetter, dri-devel, linux-kernel
On 7/9/21 11:09 AM, Tong Zhang wrote:
> This patch fixes vmwgfx driver compilation error due to a missing include
>
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function ‘vmw_vram_manager_init’:
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:678:8: error: implicit declaration of function ‘ttm_range_man_init’ [-Werror=implicit-function-declaration]
> 678 | ret = ttm_range_man_init(&dev_priv->bdev, TTM_PL_VRAM, false,
> | ^~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function ‘vmw_vram_manager_fini’:
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:690:2: error: implicit declaration of function ‘ttm_range_man_fini’ [-Werror=implicit-function-declaration]
> 690 | ttm_range_man_fini(&dev_priv->bdev, TTM_PL_VRAM);
> | ^~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
> Signed-off-by: Tong Zhang <ztong0001@gmail.com>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> index 6f5ea00973e0..6eb93aa2f311 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> @@ -37,6 +37,7 @@
> #include <drm/drm_sysfs.h>
> #include <drm/ttm/ttm_bo_driver.h>
> #include <drm/ttm/ttm_placement.h>
> +#include <drm/ttm/ttm_range_manager.h>
> #include <generated/utsrelease.h>
>
> #include "ttm_object.h"
>
Yes, it's time to get one of these (3 or more) such patches
merged so that linux-next does not continue to have build errors,
like it has for about the last 2 weeks.
thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] fix vmwgfx compilation error due to a missing include
2021-07-09 18:09 [PATCH v1] fix vmwgfx compilation error due to a missing include Tong Zhang
@ 2021-07-09 20:04 ` Dave Airlie
2021-07-09 20:04 ` Dave Airlie
1 sibling, 0 replies; 6+ messages in thread
From: Dave Airlie @ 2021-07-09 20:04 UTC (permalink / raw)
To: Tong Zhang, Christian König
Cc: VMware Graphics, Roland Scheidegger, Zack Rusin, David Airlie,
Daniel Vetter, dri-devel, LKML
cc'ing Christian to fix this I assume it was ttm refactor?
>
> This patch fixes vmwgfx driver compilation error due to a missing include
>
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function ‘vmw_vram_manager_init’:
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:678:8: error: implicit declaration of function ‘ttm_range_man_init’ [-Werror=implicit-function-declaration]
> 678 | ret = ttm_range_man_init(&dev_priv->bdev, TTM_PL_VRAM, false,
> | ^~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function ‘vmw_vram_manager_fini’:
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:690:2: error: implicit declaration of function ‘ttm_range_man_fini’ [-Werror=implicit-function-declaration]
> 690 | ttm_range_man_fini(&dev_priv->bdev, TTM_PL_VRAM);
> | ^~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
> Signed-off-by: Tong Zhang <ztong0001@gmail.com>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> index 6f5ea00973e0..6eb93aa2f311 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> @@ -37,6 +37,7 @@
> #include <drm/drm_sysfs.h>
> #include <drm/ttm/ttm_bo_driver.h>
> #include <drm/ttm/ttm_placement.h>
> +#include <drm/ttm/ttm_range_manager.h>
> #include <generated/utsrelease.h>
>
> #include "ttm_object.h"
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] fix vmwgfx compilation error due to a missing include
@ 2021-07-09 20:04 ` Dave Airlie
0 siblings, 0 replies; 6+ messages in thread
From: Dave Airlie @ 2021-07-09 20:04 UTC (permalink / raw)
To: Tong Zhang, Christian König
Cc: David Airlie, Roland Scheidegger, LKML, dri-devel, VMware Graphics
cc'ing Christian to fix this I assume it was ttm refactor?
>
> This patch fixes vmwgfx driver compilation error due to a missing include
>
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function ‘vmw_vram_manager_init’:
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:678:8: error: implicit declaration of function ‘ttm_range_man_init’ [-Werror=implicit-function-declaration]
> 678 | ret = ttm_range_man_init(&dev_priv->bdev, TTM_PL_VRAM, false,
> | ^~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function ‘vmw_vram_manager_fini’:
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:690:2: error: implicit declaration of function ‘ttm_range_man_fini’ [-Werror=implicit-function-declaration]
> 690 | ttm_range_man_fini(&dev_priv->bdev, TTM_PL_VRAM);
> | ^~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
> Signed-off-by: Tong Zhang <ztong0001@gmail.com>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> index 6f5ea00973e0..6eb93aa2f311 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> @@ -37,6 +37,7 @@
> #include <drm/drm_sysfs.h>
> #include <drm/ttm/ttm_bo_driver.h>
> #include <drm/ttm/ttm_placement.h>
> +#include <drm/ttm/ttm_range_manager.h>
> #include <generated/utsrelease.h>
>
> #include "ttm_object.h"
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] fix vmwgfx compilation error due to a missing include
2021-07-09 20:04 ` Dave Airlie
@ 2021-07-09 20:34 ` Zack Rusin
-1 siblings, 0 replies; 6+ messages in thread
From: Zack Rusin @ 2021-07-09 20:34 UTC (permalink / raw)
To: Dave Airlie, Tong Zhang, Christian König, Thomas Zimmermann
Cc: VMware Graphics, Roland Scheidegger, David Airlie, Daniel Vetter,
dri-devel, LKML
On 7/9/21 4:04 PM, Dave Airlie wrote:
> cc'ing Christian to fix this I assume it was ttm refactor?
Yes, but it's on me because after fixing it I kept forgetting to queue it up for a merge. It's now in drm-misc/drm-misc-next-fixes.
Thomas, if you could make sure your next drm-misc-next-fixes pull request includes c26d6586e97a ("drm/vmwgfx: Fix implicit declaration error") that'd be great.
z
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v1] fix vmwgfx compilation error due to a missing include
@ 2021-07-09 20:34 ` Zack Rusin
0 siblings, 0 replies; 6+ messages in thread
From: Zack Rusin @ 2021-07-09 20:34 UTC (permalink / raw)
To: Dave Airlie, Tong Zhang, Christian König, Thomas Zimmermann
Cc: David Airlie, Roland Scheidegger, LKML, dri-devel, VMware Graphics
On 7/9/21 4:04 PM, Dave Airlie wrote:
> cc'ing Christian to fix this I assume it was ttm refactor?
Yes, but it's on me because after fixing it I kept forgetting to queue it up for a merge. It's now in drm-misc/drm-misc-next-fixes.
Thomas, if you could make sure your next drm-misc-next-fixes pull request includes c26d6586e97a ("drm/vmwgfx: Fix implicit declaration error") that'd be great.
z
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-09 20:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-09 18:09 [PATCH v1] fix vmwgfx compilation error due to a missing include Tong Zhang
2021-07-09 19:57 ` Randy Dunlap
2021-07-09 20:04 ` Dave Airlie
2021-07-09 20:04 ` Dave Airlie
2021-07-09 20:34 ` Zack Rusin
2021-07-09 20:34 ` Zack Rusin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.