All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: ux500: ab8500: Link USB PHY to USB controller node
@ 2021-07-09 18:22 ` Stephan Gerhold
  0 siblings, 0 replies; 4+ messages in thread
From: Stephan Gerhold @ 2021-07-09 18:22 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-arm-kernel, devicetree, Stephan Gerhold

At the moment the AB8500 USB PHY driver still uses the old USB PHY
subsystem instead of the generic PHY subsystem. This means that there
is no explicit link between the USB controller and the USB PHY.

In U-Boot the PHY driver is integrated in the generic PHY subsystem,
so we need to use the typical PHY device tree bindings to specify
which PHY belongs to the USB controller.

Add the link between USB controller and PHY to both ste-ab8500.dtsi
and ste-ab8505.dtsi. This is mainly for U-Boot for now and will just
be ignored in Linux. However, if the AB8500 USB PHY driver in Linux
is moved to the generic PHY subsystem at some point these device tree
changes can be used as well.

Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
---
 arch/arm/boot/dts/ste-ab8500.dtsi | 8 +++++++-
 arch/arm/boot/dts/ste-ab8505.dtsi | 6 ++++++
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/ste-ab8500.dtsi b/arch/arm/boot/dts/ste-ab8500.dtsi
index d0fe3f9aa183..bebcbb759794 100644
--- a/arch/arm/boot/dts/ste-ab8500.dtsi
+++ b/arch/arm/boot/dts/ste-ab8500.dtsi
@@ -217,7 +217,7 @@ ab8500_chargalg {
 					battery		= <&ab8500_battery>;
 				};
 
-				ab8500_usb {
+				ab8500_usb: ab8500_usb {
 					compatible = "stericsson,ab8500-usb";
 					interrupts = <90 IRQ_TYPE_LEVEL_HIGH>,
 						     <96 IRQ_TYPE_LEVEL_HIGH>,
@@ -238,6 +238,7 @@ ab8500_usb {
 					musb_1v8-supply = <&db8500_vsmps2_reg>;
 					clocks = <&prcmu_clk PRCMU_SYSCLK>;
 					clock-names = "sysclk";
+					#phy-cells = <0>;
 				};
 
 				ab8500-ponkey {
@@ -386,5 +387,10 @@ dsi@a0353000 {
 				vana-supply = <&ab8500_ldo_ana_reg>;
 			};
 		};
+
+		usb_per5@a03e0000 {
+			phys = <&ab8500_usb>;
+			phy-names = "usb";
+		};
 	};
 };
diff --git a/arch/arm/boot/dts/ste-ab8505.dtsi b/arch/arm/boot/dts/ste-ab8505.dtsi
index 0defc15b9bbc..fb30e247ac9c 100644
--- a/arch/arm/boot/dts/ste-ab8505.dtsi
+++ b/arch/arm/boot/dts/ste-ab8505.dtsi
@@ -201,6 +201,7 @@ ab8500_usb: ab8500_usb {
 					musb_1v8-supply = <&db8500_vsmps2_reg>;
 					clocks = <&prcmu_clk PRCMU_SYSCLK>;
 					clock-names = "sysclk";
+					#phy-cells = <0>;
 				};
 
 				ab8500-ponkey {
@@ -322,5 +323,10 @@ dsi@a0353000 {
 				vana-supply = <&ab8500_ldo_ana_reg>;
 			};
 		};
+
+		usb_per5@a03e0000 {
+			phys = <&ab8500_usb>;
+			phy-names = "usb";
+		};
 	};
 };
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] ARM: dts: ux500: ab8500: Link USB PHY to USB controller node
@ 2021-07-09 18:22 ` Stephan Gerhold
  0 siblings, 0 replies; 4+ messages in thread
From: Stephan Gerhold @ 2021-07-09 18:22 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-arm-kernel, devicetree, Stephan Gerhold

At the moment the AB8500 USB PHY driver still uses the old USB PHY
subsystem instead of the generic PHY subsystem. This means that there
is no explicit link between the USB controller and the USB PHY.

In U-Boot the PHY driver is integrated in the generic PHY subsystem,
so we need to use the typical PHY device tree bindings to specify
which PHY belongs to the USB controller.

Add the link between USB controller and PHY to both ste-ab8500.dtsi
and ste-ab8505.dtsi. This is mainly for U-Boot for now and will just
be ignored in Linux. However, if the AB8500 USB PHY driver in Linux
is moved to the generic PHY subsystem at some point these device tree
changes can be used as well.

Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
---
 arch/arm/boot/dts/ste-ab8500.dtsi | 8 +++++++-
 arch/arm/boot/dts/ste-ab8505.dtsi | 6 ++++++
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/ste-ab8500.dtsi b/arch/arm/boot/dts/ste-ab8500.dtsi
index d0fe3f9aa183..bebcbb759794 100644
--- a/arch/arm/boot/dts/ste-ab8500.dtsi
+++ b/arch/arm/boot/dts/ste-ab8500.dtsi
@@ -217,7 +217,7 @@ ab8500_chargalg {
 					battery		= <&ab8500_battery>;
 				};
 
-				ab8500_usb {
+				ab8500_usb: ab8500_usb {
 					compatible = "stericsson,ab8500-usb";
 					interrupts = <90 IRQ_TYPE_LEVEL_HIGH>,
 						     <96 IRQ_TYPE_LEVEL_HIGH>,
@@ -238,6 +238,7 @@ ab8500_usb {
 					musb_1v8-supply = <&db8500_vsmps2_reg>;
 					clocks = <&prcmu_clk PRCMU_SYSCLK>;
 					clock-names = "sysclk";
+					#phy-cells = <0>;
 				};
 
 				ab8500-ponkey {
@@ -386,5 +387,10 @@ dsi@a0353000 {
 				vana-supply = <&ab8500_ldo_ana_reg>;
 			};
 		};
+
+		usb_per5@a03e0000 {
+			phys = <&ab8500_usb>;
+			phy-names = "usb";
+		};
 	};
 };
diff --git a/arch/arm/boot/dts/ste-ab8505.dtsi b/arch/arm/boot/dts/ste-ab8505.dtsi
index 0defc15b9bbc..fb30e247ac9c 100644
--- a/arch/arm/boot/dts/ste-ab8505.dtsi
+++ b/arch/arm/boot/dts/ste-ab8505.dtsi
@@ -201,6 +201,7 @@ ab8500_usb: ab8500_usb {
 					musb_1v8-supply = <&db8500_vsmps2_reg>;
 					clocks = <&prcmu_clk PRCMU_SYSCLK>;
 					clock-names = "sysclk";
+					#phy-cells = <0>;
 				};
 
 				ab8500-ponkey {
@@ -322,5 +323,10 @@ dsi@a0353000 {
 				vana-supply = <&ab8500_ldo_ana_reg>;
 			};
 		};
+
+		usb_per5@a03e0000 {
+			phys = <&ab8500_usb>;
+			phy-names = "usb";
+		};
 	};
 };
-- 
2.32.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: ux500: ab8500: Link USB PHY to USB controller node
  2021-07-09 18:22 ` Stephan Gerhold
@ 2021-07-30  9:19   ` Linus Walleij
  -1 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2021-07-30  9:19 UTC (permalink / raw)
  To: Stephan Gerhold
  Cc: Linux ARM, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS

On Fri, Jul 9, 2021 at 8:23 PM Stephan Gerhold <stephan@gerhold.net> wrote:

> At the moment the AB8500 USB PHY driver still uses the old USB PHY
> subsystem instead of the generic PHY subsystem. This means that there
> is no explicit link between the USB controller and the USB PHY.
>
> In U-Boot the PHY driver is integrated in the generic PHY subsystem,
> so we need to use the typical PHY device tree bindings to specify
> which PHY belongs to the USB controller.
>
> Add the link between USB controller and PHY to both ste-ab8500.dtsi
> and ste-ab8505.dtsi. This is mainly for U-Boot for now and will just
> be ignored in Linux. However, if the AB8500 USB PHY driver in Linux
> is moved to the generic PHY subsystem at some point these device tree
> changes can be used as well.
>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>

Patch applied!

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: ux500: ab8500: Link USB PHY to USB controller node
@ 2021-07-30  9:19   ` Linus Walleij
  0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2021-07-30  9:19 UTC (permalink / raw)
  To: Stephan Gerhold
  Cc: Linux ARM, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS

On Fri, Jul 9, 2021 at 8:23 PM Stephan Gerhold <stephan@gerhold.net> wrote:

> At the moment the AB8500 USB PHY driver still uses the old USB PHY
> subsystem instead of the generic PHY subsystem. This means that there
> is no explicit link between the USB controller and the USB PHY.
>
> In U-Boot the PHY driver is integrated in the generic PHY subsystem,
> so we need to use the typical PHY device tree bindings to specify
> which PHY belongs to the USB controller.
>
> Add the link between USB controller and PHY to both ste-ab8500.dtsi
> and ste-ab8505.dtsi. This is mainly for U-Boot for now and will just
> be ignored in Linux. However, if the AB8500 USB PHY driver in Linux
> is moved to the generic PHY subsystem at some point these device tree
> changes can be used as well.
>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>

Patch applied!

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-07-30  9:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-09 18:22 [PATCH] ARM: dts: ux500: ab8500: Link USB PHY to USB controller node Stephan Gerhold
2021-07-09 18:22 ` Stephan Gerhold
2021-07-30  9:19 ` Linus Walleij
2021-07-30  9:19   ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.