From: kernel test robot <lkp@intel.com> To: Ulf Hansson <ulf.hansson@linaro.org>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, linux-pm@vger.kernel.org Cc: kbuild-all@lists.01.org, Bjorn Andersson <bjorn.andersson@linaro.org>, Stephen Boyd <sboyd@kernel.org>, Saravana Kannan <saravanak@google.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Kevin Hilman <khilman@kernel.org>, Geert Uytterhoeven <geert+renesas@glider.be>, Ulf Hansson <ulf.hansson@linaro.org>, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PM: domains: Don't attach a device to genpd that corresponds to a provider Date: Sat, 10 Jul 2021 02:49:43 +0800 [thread overview] Message-ID: <202107100247.hkdP9au8-lkp@intel.com> (raw) In-Reply-To: <20210709125611.135920-1-ulf.hansson@linaro.org> [-- Attachment #1: Type: text/plain, Size: 3241 bytes --] Hi Ulf, I love your patch! Perhaps something to improve: [auto build test WARNING on pm/linux-next] [also build test WARNING on v5.13 next-20210709] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Ulf-Hansson/PM-domains-Don-t-attach-a-device-to-genpd-that-corresponds-to-a-provider/20210709-205736 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next config: i386-randconfig-s001-20210709 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-341-g8af24329-dirty # https://github.com/0day-ci/linux/commit/5f3ae7877b4b3a9c2c4d96c2106c41b16b981958 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Ulf-Hansson/PM-domains-Don-t-attach-a-device-to-genpd-that-corresponds-to-a-provider/20210709-205736 git checkout 5f3ae7877b4b3a9c2c4d96c2106c41b16b981958 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> sparse warnings: (new ones prefixed by >>) >> drivers/base/power/domain.c:2704:24: sparse: sparse: incorrect type in return expression (different base types) @@ expected int @@ got void * @@ drivers/base/power/domain.c:2704:24: sparse: expected int drivers/base/power/domain.c:2704:24: sparse: got void * vim +2704 drivers/base/power/domain.c 2683 2684 /** 2685 * genpd_dev_pm_attach - Attach a device to its PM domain using DT. 2686 * @dev: Device to attach. 2687 * 2688 * Parse device's OF node to find a PM domain specifier. If such is found, 2689 * attaches the device to retrieved pm_domain ops. 2690 * 2691 * Returns 1 on successfully attached PM domain, 0 when the device don't need a 2692 * PM domain or when multiple power-domains exists for it, else a negative error 2693 * code. Note that if a power-domain exists for the device, but it cannot be 2694 * found or turned on, then return -EPROBE_DEFER to ensure that the device is 2695 * not probed and to re-try again later. 2696 */ 2697 int genpd_dev_pm_attach(struct device *dev) 2698 { 2699 if (!dev->of_node) 2700 return 0; 2701 2702 /* Don't try to attach a genpd provider. */ 2703 if (of_find_property(dev->of_node, "#power-domain-cells", NULL)) > 2704 return NULL; 2705 2706 /* 2707 * Devices with multiple PM domains must be attached separately, as we 2708 * can only attach one PM domain per device. 2709 */ 2710 if (of_count_phandle_with_args(dev->of_node, "power-domains", 2711 "#power-domain-cells") != 1) 2712 return 0; 2713 2714 return __genpd_dev_pm_attach(dev, dev, 0, true); 2715 } 2716 EXPORT_SYMBOL_GPL(genpd_dev_pm_attach); 2717 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 48549 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH] PM: domains: Don't attach a device to genpd that corresponds to a provider Date: Sat, 10 Jul 2021 02:49:43 +0800 [thread overview] Message-ID: <202107100247.hkdP9au8-lkp@intel.com> (raw) In-Reply-To: <20210709125611.135920-1-ulf.hansson@linaro.org> [-- Attachment #1: Type: text/plain, Size: 3317 bytes --] Hi Ulf, I love your patch! Perhaps something to improve: [auto build test WARNING on pm/linux-next] [also build test WARNING on v5.13 next-20210709] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Ulf-Hansson/PM-domains-Don-t-attach-a-device-to-genpd-that-corresponds-to-a-provider/20210709-205736 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next config: i386-randconfig-s001-20210709 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-341-g8af24329-dirty # https://github.com/0day-ci/linux/commit/5f3ae7877b4b3a9c2c4d96c2106c41b16b981958 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Ulf-Hansson/PM-domains-Don-t-attach-a-device-to-genpd-that-corresponds-to-a-provider/20210709-205736 git checkout 5f3ae7877b4b3a9c2c4d96c2106c41b16b981958 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> sparse warnings: (new ones prefixed by >>) >> drivers/base/power/domain.c:2704:24: sparse: sparse: incorrect type in return expression (different base types) @@ expected int @@ got void * @@ drivers/base/power/domain.c:2704:24: sparse: expected int drivers/base/power/domain.c:2704:24: sparse: got void * vim +2704 drivers/base/power/domain.c 2683 2684 /** 2685 * genpd_dev_pm_attach - Attach a device to its PM domain using DT. 2686 * @dev: Device to attach. 2687 * 2688 * Parse device's OF node to find a PM domain specifier. If such is found, 2689 * attaches the device to retrieved pm_domain ops. 2690 * 2691 * Returns 1 on successfully attached PM domain, 0 when the device don't need a 2692 * PM domain or when multiple power-domains exists for it, else a negative error 2693 * code. Note that if a power-domain exists for the device, but it cannot be 2694 * found or turned on, then return -EPROBE_DEFER to ensure that the device is 2695 * not probed and to re-try again later. 2696 */ 2697 int genpd_dev_pm_attach(struct device *dev) 2698 { 2699 if (!dev->of_node) 2700 return 0; 2701 2702 /* Don't try to attach a genpd provider. */ 2703 if (of_find_property(dev->of_node, "#power-domain-cells", NULL)) > 2704 return NULL; 2705 2706 /* 2707 * Devices with multiple PM domains must be attached separately, as we 2708 * can only attach one PM domain per device. 2709 */ 2710 if (of_count_phandle_with_args(dev->of_node, "power-domains", 2711 "#power-domain-cells") != 1) 2712 return 0; 2713 2714 return __genpd_dev_pm_attach(dev, dev, 0, true); 2715 } 2716 EXPORT_SYMBOL_GPL(genpd_dev_pm_attach); 2717 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 48549 bytes --]
next prev parent reply other threads:[~2021-07-09 18:50 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-09 12:56 [PATCH] PM: domains: Don't attach a device to genpd that corresponds to a provider Ulf Hansson 2021-07-09 13:06 ` Geert Uytterhoeven 2021-07-09 13:22 ` Ulf Hansson 2021-07-09 13:35 ` Geert Uytterhoeven 2021-07-09 13:48 ` Ulf Hansson 2021-07-09 13:57 ` Geert Uytterhoeven 2021-07-09 14:02 ` Ulf Hansson 2021-07-09 13:46 ` Bjorn Andersson 2021-07-09 13:58 ` Ulf Hansson 2021-07-09 14:16 ` Bjorn Andersson 2021-07-09 18:49 ` kernel test robot [this message] 2021-07-09 18:49 ` kernel test robot 2021-07-09 19:01 ` kernel test robot 2021-07-09 19:01 ` kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202107100247.hkdP9au8-lkp@intel.com \ --to=lkp@intel.com \ --cc=bjorn.andersson@linaro.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=geert+renesas@glider.be \ --cc=kbuild-all@lists.01.org \ --cc=khilman@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=rjw@rjwysocki.net \ --cc=saravanak@google.com \ --cc=sboyd@kernel.org \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.