All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miaohe Lin <linmiaohe@huawei.com>
To: <akpm@linux-foundation.org>
Cc: <hannes@cmpxchg.org>, <vbabka@suse.cz>, <mhocko@suse.com>,
	<axboe@kernel.dk>, <iamjoonsoo.kim@lge.com>, <alexs@kernel.org>,
	<apopple@nvidia.com>, <willy@infradead.org>, <minchan@kernel.org>,
	<david@redhat.com>, <shli@fb.com>, <hillf.zj@alibaba-inc.com>,
	<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
	<linmiaohe@huawei.com>
Subject: [PATCH 3/5] mm/vmscan: remove unneeded return value of kswapd_run()
Date: Sat, 10 Jul 2021 18:03:27 +0800	[thread overview]
Message-ID: <20210710100329.49174-4-linmiaohe@huawei.com> (raw)
In-Reply-To: <20210710100329.49174-1-linmiaohe@huawei.com>

The return value of kswapd_run() is unused now. Clean it up.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 include/linux/swap.h | 2 +-
 mm/vmscan.c          | 7 ++-----
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/include/linux/swap.h b/include/linux/swap.h
index 6f5a43251593..717e6e500929 100644
--- a/include/linux/swap.h
+++ b/include/linux/swap.h
@@ -408,7 +408,7 @@ static inline bool node_reclaim_enabled(void)
 
 extern void check_move_unevictable_pages(struct pagevec *pvec);
 
-extern int kswapd_run(int nid);
+extern void kswapd_run(int nid);
 extern void kswapd_stop(int nid);
 
 #ifdef CONFIG_SWAP
diff --git a/mm/vmscan.c b/mm/vmscan.c
index fbe53e60b248..c580bef6b885 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -4284,23 +4284,20 @@ unsigned long shrink_all_memory(unsigned long nr_to_reclaim)
  * This kswapd start function will be called by init and node-hot-add.
  * On node-hot-add, kswapd will moved to proper cpus if cpus are hot-added.
  */
-int kswapd_run(int nid)
+void kswapd_run(int nid)
 {
 	pg_data_t *pgdat = NODE_DATA(nid);
-	int ret = 0;
 
 	if (pgdat->kswapd)
-		return 0;
+		return;
 
 	pgdat->kswapd = kthread_run(kswapd, pgdat, "kswapd%d", nid);
 	if (IS_ERR(pgdat->kswapd)) {
 		/* failure at boot is fatal */
 		BUG_ON(system_state < SYSTEM_RUNNING);
 		pr_err("Failed to start kswapd on node %d\n", nid);
-		ret = PTR_ERR(pgdat->kswapd);
 		pgdat->kswapd = NULL;
 	}
-	return ret;
 }
 
 /*
-- 
2.23.0


  parent reply	other threads:[~2021-07-10 10:03 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-10 10:03 [PATCH 0/5] Cleanup and fixup for vmscan Miaohe Lin
2021-07-10 10:03 ` [PATCH 1/5] mm/vmscan: put the redirtied MADV_FREE pages back to anonymous LRU list Miaohe Lin
2021-07-10 23:22   ` Yu Zhao
2021-07-10 23:22     ` Yu Zhao
2021-07-12  7:11     ` Miaohe Lin
2021-07-13  7:25       ` Yu Zhao
2021-07-13  7:25         ` Yu Zhao
2021-07-13 13:16         ` Miaohe Lin
2021-07-12  7:22   ` Michal Hocko
2021-07-12 11:03     ` Miaohe Lin
2021-07-13  9:30       ` Michal Hocko
2021-07-13 13:13         ` Miaohe Lin
2021-07-13 13:34           ` Matthew Wilcox
2021-07-14 11:36             ` Miaohe Lin
2021-07-14 11:48               ` Matthew Wilcox
2021-07-14 19:43                 ` John Hubbard
2021-07-15 11:30                   ` Miaohe Lin
2021-07-16  0:01                     ` John Hubbard
2021-07-16  1:53                       ` Miaohe Lin
2021-07-10 10:03 ` [PATCH 2/5] mm/vmscan: remove misleading setting to sc->priority Miaohe Lin
2021-07-12  7:24   ` Michal Hocko
2021-07-12 11:10     ` Miaohe Lin
2021-07-10 10:03 ` Miaohe Lin [this message]
2021-07-12  7:25   ` [PATCH 3/5] mm/vmscan: remove unneeded return value of kswapd_run() Michal Hocko
2021-07-10 10:03 ` [PATCH 4/5] mm/vmscan: add 'else' to remove check_pending label Miaohe Lin
2021-07-12  7:26   ` Michal Hocko
2021-07-10 10:03 ` [PATCH 5/5] mm/vmscan: fix misleading comment in isolate_lru_pages() Miaohe Lin
2021-07-12  7:28   ` Michal Hocko
2021-07-12 11:16     ` Miaohe Lin
2021-07-13  9:32       ` Michal Hocko
2021-07-13 12:50         ` Miaohe Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210710100329.49174-4-linmiaohe@huawei.com \
    --to=linmiaohe@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexs@kernel.org \
    --cc=apopple@nvidia.com \
    --cc=axboe@kernel.dk \
    --cc=david@redhat.com \
    --cc=hannes@cmpxchg.org \
    --cc=hillf.zj@alibaba-inc.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=minchan@kernel.org \
    --cc=shli@fb.com \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.